UrlEncode Password when serializing to a connection string

Author: mythz

src/ServiceStack.Redis/RedisEndpoint.cs

@@ -54,7 +54,7 @@ public override string ToString()
             if (Client != null)
                 args.Add("Client=" + Client);
             if (Password != null)
-                args.Add("Password=" + Password);
+                args.Add("Password=" + Password.UrlEncode());
             if (Db != RedisConfig.DefaultDb)
                 args.Add("Db=" + Db);
             if (Ssl)

tests/ServiceStack.Redis.Tests/ConfigTests.cs

@@ -1,4 +1,5 @@
 using NUnit.Framework;
+using ServiceStack.Text;
 
 namespace ServiceStack.Redis.Tests
 {
@@ -81,6 +82,25 @@ public void Does_set_all_properties_on_Client_using_ClientsManagers()
             }
         }
 
+        [Test]
+        public void Does_encode_values_when_serializing_to_ConnectionString()
+        {
+            var config = new RedisEndpoint
+            {
+                Host = "host",
+                Port = 1,
+                Password = "p@55W0rd="
+            };
+
+            var connString = config.ToString();
+            Assert.That(connString, Is.EqualTo("host:1?Password=p%4055W0rd%3d"));
+
+            var fromConfig = connString.ToRedisEndpoint();
+            Assert.That(fromConfig.Host, Is.EqualTo(config.Host));
+            Assert.That(fromConfig.Port, Is.EqualTo(config.Port));
+            Assert.That(fromConfig.Password, Is.EqualTo(config.Password));
+        }
+
         private static void AssertClientManager(IRedisClientsManager redisManager, RedisEndpoint expected)
         {
             using (var readWrite = (RedisClient)redisManager.GetClient())