hmac: get rid of reflection in hmac calculation as well

Snawoot · Snawoot · commit 7aa10a3553d3 · 2024-11-30T15:18:01.000+02:00
diff --git a/hmac/hmac.go b/hmac/hmac.go
@@ -43,9 +43,13 @@ func VerifyHMACLoginAndPassword(mac hash.Hash, login, password []byte) bool {
 }
 
 func CalculateHMACSignature(mac hash.Hash, username []byte, expire int64) []byte {
+	var buf [unsafe.Sizeof(expire)]byte
+	binary.BigEndian.PutUint64(buf[:], uint64(expire))
+
 	mac.Reset()
 	mac.Write(hmacSignaturePrefix)
 	mac.Write(username)
-	binary.Write(mac, binary.BigEndian, expire)
+	mac.Write(buf[:])
+
 	return mac.Sum(nil)
 }

Original file line number	Diff line number	Diff line change
`@@ -43,9 +43,13 @@ func VerifyHMACLoginAndPassword(mac hash.Hash, login, password []byte) bool {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`func CalculateHMACSignature(mac hash.Hash, username []byte, expire int64) []byte {`
	`46`	`+ var buf [unsafe.Sizeof(expire)]byte`
	`47`	`+ binary.BigEndian.PutUint64(buf[:], uint64(expire))`
	`48`	`+`
`46`	`49`	`mac.Reset()`
`47`	`50`	`mac.Write(hmacSignaturePrefix)`
`48`	`51`	`mac.Write(username)`
`49`		`- binary.Write(mac, binary.BigEndian, expire)`
	`52`	`+ mac.Write(buf[:])`
	`53`	`+`
`50`	`54`	`return mac.Sum(nil)`
`51`	`55`	`}`