Merge pull request #536 from ChrisRackauckas-Claude/static-improvements-20260101-030315

Fix JET static analysis issues

Author: ChrisRackauckas

src/simple_regular_solve.jl

@@ -20,7 +20,7 @@ function DiffEqBase.solve(jump_prob::JumpProblem, alg::SimpleTauLeaping;
         error("SimpleTauLeaping can only be used with PureLeaping JumpProblems with only RegularJumps.")
 
     (; prob, rng) = jump_prob
-    (seed !== nothing) && seed!(rng, seed)
+    (seed !== nothing) && Random.seed!(rng, seed)
 
     rj = jump_prob.regular_jump
     rate = rj.rate # rate function rate(out,u,p,t)

src/spatial/flatten.jl

@@ -14,24 +14,26 @@ function flatten(ma_jump, prob::DiscreteProblem, spatial_system, hopping_constan
     end
     netstoch = ma_jump.net_stoch
     reactstoch = ma_jump.reactant_stoch
-    if isa(ma_jump, MassActionJump)
-        rx_rates = ma_jump.scaled_rates
+    rx_rates = if isa(ma_jump, MassActionJump)
+        ma_jump.scaled_rates
     elseif isa(ma_jump, SpatialMassActionJump)
         num_nodes = num_sites(spatial_system)
         if isnothing(ma_jump.uniform_rates) && isnothing(ma_jump.spatial_rates)
-            rx_rates = zeros(0, num_nodes)
+            zeros(0, num_nodes)
         elseif isnothing(ma_jump.uniform_rates)
-            rx_rates = ma_jump.spatial_rates
+            ma_jump.spatial_rates
         elseif isnothing(ma_jump.spatial_rates)
-            rx_rates = reshape(repeat(ma_jump.uniform_rates, num_nodes),
+            reshape(repeat(ma_jump.uniform_rates, num_nodes),
                 length(ma_jump.uniform_rates), num_nodes)
         else
             @assert size(ma_jump.spatial_rates, 2) == num_nodes
-            rx_rates = cat(dims = 1,
+            cat(dims = 1,
                 reshape(repeat(ma_jump.uniform_rates, num_nodes),
                     length(ma_jump.uniform_rates), num_nodes),
                 ma_jump.spatial_rates)
         end
+    else
+        error("flatten: unsupported jump type $(typeof(ma_jump))")
     end
     flatten(netstoch, reactstoch, rx_rates, spatial_system, u0, tspan, hopping_constants;
         scale_rates = false, kwargs...)

src/spatial/topology.jl

@@ -85,17 +85,16 @@ end
 """
 given a vector of hopping constants of length num_neighbors(grid, site), form the vector of size 2*(dimension of grid) with zeros at indices where the neighbor is out of bounds. Store it in to_pad
 """
-function pad_hop_vec!(to_pad::AbstractVector{F}, grid, site,
-        hop_vec::Vector{F}) where {F <: Number}
+function pad_hop_vec!(to_pad::AbstractVector, grid, site, hop_vec::AbstractVector)
     CI = grid.CI
     I = CI[site]
     nbr_counter = 1
-    for (i, off) in enumerate(grid.offsets)
+    @inbounds for (i, off) in enumerate(grid.offsets)
         if I + off in CI
             to_pad[i] = hop_vec[nbr_counter]
             nbr_counter += 1
         else
-            to_pad[i] = zero(F)
+            to_pad[i] = zero(eltype(to_pad))
         end
     end
     to_pad