finishing process binary feature

Author: anisiosts

.gitignore

@@ -0,0 +1,52 @@
+# Python
+__pycache__/
+*.py[cod]
+*$py.class
+*.so
+.Python
+build/
+develop-eggs/
+dist/
+downloads/
+eggs/
+.eggs/
+lib/
+lib64/
+parts/
+sdist/
+var/
+wheels/
+*.egg-info/
+.installed.cfg
+*.egg
+
+# Virtual Environment
+venv/
+ENV/
+env/
+.env/
+
+# IDE
+.idea/
+.vscode/
+*.swp
+*.swo
+
+# Binary Ninja specific
+*.bndb
+*.bndb.bak
+patchers/
+*.patch
+
+# Logs and databases
+*.log
+*.sqlite
+
+# OS specific
+.DS_Store
+.DS_Store?
+._*
+.Spotlight-V100
+.Trashes
+ehthumbs.db
+Thumbs.db 

features/configuration/__init__.py

@@ -1,7 +1,7 @@
 from binaryninja import PluginCommand, log_info
 from .config import Config
 from .config_dialog import ConfigDialog
-from ..base_auth_feature import BaseAuthFeature
+from revengai_bn.utils import BaseAuthFeature
 
 class ConfigurationFeature():
     def __init__(self):

features/configuration/config.py

@@ -38,13 +38,13 @@ def _load_config(self):
             "description" : "Configuration Status"}')
         settings.register_setting("revengai.binary_id", 
             '{"title" : "Binary ID",\
-            "type" : "string",\
-            "default" : "",\
+            "type" : "number",\
+            "default" : 0,\
             "description" : "Current Binary ID"}')
         settings.register_setting("revengai.analysis_id", 
             '{"title" : "Analysis ID",\
-            "type" : "string",\
-            "default" : "",\
+            "type" : "number",\
+            "default" : 0,\
             "description" : "Current Analysis ID"}')
 
         self.host = settings.get_string("revengai.host", None)
@@ -71,11 +71,14 @@ def save_config(self) -> bool:
             settings.set_string("revengai.host", self.host)
             settings.set_string("revengai.api_key", self.api_key)
             settings.set_string("revengai.is_configured", self.is_configured)
-    
+
             return True
 
         except Exception as e:
             log_info(f"RevEng.AI | Failed to save API key: {str(e)}")
+            self.is_configured = "False"
+            settings = Settings()
+            settings.set_string("revengai.is_configured", self.is_configured)
             return False
 
 
@@ -86,14 +89,14 @@ def clear_config(self):
         self.is_configured = False
         self.save_config() 
 
-    def set_binary_id(self, binary_id: str):
+    def set_binary_id(self, binary_id: int):
         """Set the binary ID and store it in settings."""
         self.binary_id = binary_id
         settings = Settings()
         settings.set_integer("revengai.binary_id", self.binary_id)
         return
 
-    def set_analysis_id(self, analysis_id: str):
+    def set_analysis_id(self, analysis_id: int):
         """Set the analysis ID and store it in settings."""
         self.analysis_id = analysis_id
         settings = Settings()

features/configuration/config_dialog.py

@@ -1,10 +1,11 @@
 from PySide6.QtWidgets import (QDialog, QVBoxLayout, QHBoxLayout, QLabel, 
-                                 QLineEdit, QPushButton, QMessageBox, QProgressDialog, QProgressBar)
+                                 QLineEdit, QPushButton, QMessageBox)
 from PySide6.QtCore import Qt
 from PySide6.QtGui import QPixmap
 from binaryninja import log_info, log_error, log_warn
 import os
 from .config_save_thread import ConfigSaveThread
+from revengai_bn.utils import create_progress_dialog
 
 class ConfigDialog(QDialog):
     def __init__(self, config):
@@ -14,6 +15,7 @@ def __init__(self, config):
         self.progress = None
         self.init_ui()
 
+        
     def init_ui(self):
         self.setWindowTitle("RevEng.AI Configuration Wizard")
         self.setMinimumWidth(500)
@@ -95,6 +97,7 @@ def init_ui(self):
         layout.addLayout(button_layout)
 
         self.setLayout(layout)
+
 
     def save_config(self):
         api_key = self.api_key_input.text().strip()
@@ -119,36 +122,15 @@ def save_config(self):
                 QMessageBox.Ok
             )
             return
-            
-        # Create and show progress dialog
-        self.progress = QProgressDialog("Testing API key...", None, 0, 0, self)
-        self.progress.setWindowTitle("RevEng.AI Configuration")
-        self.progress.setWindowModality(Qt.WindowModal)
-        self.progress.setCancelButton(None)
-        self.progress.setMinimumWidth(400)
-        self.progress.setMinimumHeight(100)
-        self.progress.findChild(QProgressBar).setMinimumWidth(250)
-        self.progress.findChild(QProgressBar).setMinimumHeight(20)
-        self.progress.setStyleSheet("""
-                QProgressBar {
-                    border: 1px solid #cccccc;
-                    border-radius: 4px;
-                    text-align: center;
-                    background-color: #f0f0f0;
-                    min-width: 250px;
-                    min-height: 20px;
-                }
-                QProgressBar::chunk {
-                    background-color: #007bff;
-                    border-radius: 3px;
-                }
-        """)
+
+        self.progress = create_progress_dialog(self, "RevEng.AI Configuration", "Testing API key...")
 
         self.save_thread = ConfigSaveThread(self.config, api_key, host)
         self.save_thread.finished.connect(self._on_save_finished)
         self.save_thread.start()
 
         self.progress.show()
+
 
     def _on_save_finished(self, success, error_message):
         self.progress.close()

features/upload/__init__.py

@@ -1,7 +1,7 @@
 from binaryninja import PluginCommand, log_info, BinaryView
 from .upload import BinaryUploader
 from .upload_dialog import UploadDialog
-from ..base_auth_feature import BaseAuthFeature
+from revengai_bn.utils import BaseAuthFeature
 
 class UploadFeature(BaseAuthFeature):
     def __init__(self, config=None):

features/upload/upload.py

@@ -1,5 +1,6 @@
 from binaryninja import BinaryView, log_info, log_error, log_debug, SymbolType, BinaryViewType
 from reait.api import RE_models, RE_upload, RE_analysis_lookup, RE_analyse
+from revengai_bn.utils import PeriodicChecker
 import json
 
 class BinaryUploader:
@@ -45,7 +46,12 @@ def get_models(self, bv: BinaryView):
 
     def upload_binary(self, bv: BinaryView, options: dict):
         try:
+
             log_info(f"RevEng.AI | Uploading binary {bv.file.filename}.")
+            log_info(f"RevEng.AI | File size: {bv.parent_view.length} bytes")
+            if bv.parent_view.length > 10 * 1024 ** 2:
+                log_error(f"RevEng.AI | File size is too large. Please upload a file smaller than 10MB.")
+                return False
 
             upload = RE_upload(bv.file.filename).json()   
 
@@ -57,47 +63,46 @@ def upload_binary(self, bv: BinaryView, options: dict):
 
             sha_256_hash = upload["sha_256_hash"]
             log_info(f"RevEng.AI | SHA-256 hash: {sha_256_hash}")
-            
-            # Convert symbols to a list of dictionaries with hex strings
-            symbols = []
-            log_info(f"RevEng.AI | Image Base: {bv.image_base:x}")
-            for key, value in bv.symbols.items():
-                if value[0].type == SymbolType.FunctionSymbol:
-                    func = bv.get_function_at(value[0].address)
-                    symbols.append({
+
+            symbols = {
+                "base_addr": bv.image_base, 
+                "functions": []
+            }
+
+            for func in bv.functions:
+                symbols["functions"].append({
                         "name": func.name,
-                        "start": func.start,
-                        "end": func.start + func.total_bytes,
-                    })
-                    log_info(f"RevEng.AI | Name: {key} | Start: {func.start:x} | End: {func.start + func.total_bytes:x} | Size: {func.total_bytes}")
-
-            # Log all analysis parameters
-            log_info("RevEng.AI | Analysis parameters:")
-            log_info(f"RevEng.AI | - File path: {bv.file.filename}")
-            log_info(f"RevEng.AI | - Binary scope: {'PRIVATE' if options['is_private'] else 'PUBLIC'}")
-            log_info(f"RevEng.AI | - Debug info path: {options.get('debug_info', None)}")
-            log_info(f"RevEng.AI | - Model name: {options['model']}")
-            log_info(f"RevEng.AI | - Tags: {options.get('tags', [])}")
-            log_info(f"RevEng.AI | - Number of symbols: {len(symbols)}")
-                
+                        "start_addr": func.start,
+                        "end_addr": func.start + func.total_bytes,
+                })
+            
             analysis = RE_analyse(
                 fpath=bv.file.filename,
                 binary_scope= "PRIVATE" if options["is_private"] else "PUBLIC",
                 model_name=options["model"],
                 tags=options["tags"],
-                symbols=symbols
+                debug_fpath=options["debug_info"],
+                symbols=symbols,
+                skip_scraping=True,
+                skip_sbom=True,
+                skip_capabilities=True,
+                advanced_analysis=False
             ).json()
 
             log_info(f"RevEng.AI | Analysis response: {analysis}")
 
-            binary_id = analysis["binary_id"]
-            analysis_info = RE_analysis_lookup(str(binary_id)).json()
+            analysis_info = RE_analysis_lookup(str(analysis["binary_id"])).json()
 
-            log_info(f"RevEng.AI | Analysis info: {analysis_info}")
+            log_info(f"RevEng.AI | Binary ID: {analysis['binary_id']}")
+            log_info(f"RevEng.AI | Analysis ID: {analysis_info['analysis_id']}")
 
-            self.config.set_binary_id(binary_id)
+            self.config.set_binary_id(analysis["binary_id"])
             self.config.set_analysis_id(analysis_info["analysis_id"])
-                
+
+            # Start periodic status checking
+            checker = PeriodicChecker()
+            checker.start_checking(bv, analysis["binary_id"])
+
             return True
 
         except Exception as e:

features/upload/upload_dialog.py

@@ -1,10 +1,12 @@
 from PySide6.QtWidgets import (QDialog, QVBoxLayout, QHBoxLayout, QLabel, 
                               QComboBox, QPushButton, QRadioButton, QButtonGroup,
-                              QLineEdit, QGroupBox, QFileDialog, QProgressDialog, QMessageBox)
-from PySide6.QtCore import Qt
+                              QLineEdit, QGroupBox, QFileDialog, QMessageBox)
+from PySide6.QtCore import Qt, QCoreApplication
 from binaryninja import log_info, log_error, log_warn
 from .model_load_thread import ModelLoadThread
 from .upload_binary_thread import UploadBinaryThread
+from revengai_bn.utils import create_progress_dialog
+import time
 
 class UploadDialog(QDialog):
     def __init__(self, config, uploader, bv):
@@ -15,10 +17,8 @@ def __init__(self, config, uploader, bv):
         self.model_thread = None
         self.upload_thread = None
         self.progress = None
-        self.load_models()
         self.init_ui()
 
-        
     def init_ui(self):
         self.setWindowTitle("RevEng.AI: Process Binary")
         self.setMinimumWidth(500)
@@ -81,37 +81,25 @@ def init_ui(self):
         layout.addLayout(button_layout)
 
         self.setLayout(layout)
+        
+        # Show and process the dialog first
+        self.show()
+        QCoreApplication.processEvents()
+        
+        # Now start loading models
+        self.load_models()
 
     def load_models(self):
         """Start loading models in background"""
-        # Create and show progress dialog
-        self.progress = QProgressDialog("Loading available models...", None, 0, 0, self)
-        self.progress.setWindowTitle("RevEng.AI")
-        self.progress.setWindowModality(Qt.WindowModal)
-        self.progress.setCancelButton(None)
-        self.progress.setMinimumWidth(400)
-        self.progress.setMinimumHeight(100)
-        self.progress.setStyleSheet("""
-            QProgressBar {
-                border: 1px solid #cccccc;
-                border-radius: 4px;
-                text-align: center;
-                background-color: #f0f0f0;
-                min-width: 250px;
-                min-height: 20px;
-            }
-            QProgressBar::chunk {
-                background-color: #007bff;
-                border-radius: 3px;
-            }
-        """)
+        self.progress = create_progress_dialog(self, "RevEng.AI", "Loading available models...")
 
         self.model_thread = ModelLoadThread(self.uploader, self.bv)
         self.model_thread.finished.connect(self._on_models_loaded)
         self.model_thread.error.connect(self._on_model_load_error)
         self.model_thread.start()
-        
+
         self.progress.show()
+        QCoreApplication.processEvents()
 
     def _on_models_loaded(self, models):
         """Handle successful model loading"""
@@ -144,34 +132,16 @@ def upload_binary(self):
             )
             return
 
-        # Create and show progress dialog
-        self.progress = QProgressDialog("Uploading binary to RevEng.AI...", None, 0, 0, self)
-        self.progress.setWindowTitle("RevEng.AI Upload")
-        self.progress.setWindowModality(Qt.WindowModal)
-        self.progress.setCancelButton(None)
-        self.progress.setMinimumWidth(400)
-        self.progress.setMinimumHeight(100)
-        self.progress.setStyleSheet("""
-            QProgressBar {
-                border: 1px solid #cccccc;
-                border-radius: 4px;
-                text-align: center;
-                background-color: #f0f0f0;
-                min-width: 250px;
-                min-height: 20px;
-            }
-            QProgressBar::chunk {
-                background-color: #007bff;
-                border-radius: 3px;
-            }
-        """)
+        # Create and show progress dialog using utility function
+        self.progress = create_progress_dialog(self, "RevEng.AI Upload", "Uploading binary to RevEng.AI...")
 
         # Create and start upload thread
         self.upload_thread = UploadBinaryThread(self.uploader, self.bv, self.get_upload_options())
         self.upload_thread.finished.connect(self._on_upload_finished)
         self.upload_thread.start()
 
         self.progress.show()
+        QCoreApplication.processEvents()
 
     def _on_upload_finished(self, success, error_message):
         """Handle upload completion"""