Skip to content

Commit 670cfe4

Browse files
robertmarsalrobertmarsal
committed
fix: standard labels
1 parent 25eda27 commit 670cfe4

3 files changed

Lines changed: 14 additions & 16 deletions

File tree

‎reai_toolkit/features/match_current_function/match_current_function_dialog.py‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def _write_selected_binaries(self, final_string):
4848

4949

5050
def init_ui(self):
51-
self.setWindowTitle("RevEng.AI: Match Functions")
51+
self.setWindowTitle("RevEng.AI: Function matching")
5252
self.setMinimumSize(1000, 700)
5353
self.resize(1400, 950)
5454
self.selected_collections = []
@@ -71,7 +71,7 @@ def init_ui(self):
7171
info_layout = QVBoxLayout()
7272
title_label = QLabel("Function Matching")
7373
title_label.setStyleSheet("font-size: 18px; font-weight: bold;")
74-
description_label = QLabel("Select functions and run ANN; Review results per function.")
74+
description_label = QLabel("Match functions in this binary against previously seen samples")
7575
description_label.setWordWrap(True)
7676
info_layout.addWidget(title_label)
7777
info_layout.addWidget(description_label)
@@ -268,7 +268,7 @@ def init_ui(self):
268268
def start_matching(self):
269269
log_info("RevEng.AI | Starting function matching process")
270270

271-
self.progress = create_cancellable_progress_dialog(self, "RevEng.AI Match Functions", "Matching functions...", self.match_functions.cancel)
271+
self.progress = create_cancellable_progress_dialog(self, "RevEng.AI: Function matching", "Matching functions...", self.match_functions.cancel)
272272
self.progress.show()
273273
QCoreApplication.processEvents()
274274

@@ -295,17 +295,16 @@ def on_matching_finished(self, success, data):
295295
skipped_count = data["skipped"]
296296
failed_count = data["failed"]
297297
total_count = successful_count + skipped_count + failed_count
298-
299-
#QMessageBox.information(self, "RevEng.AI Match Functions", f"Function matching completed successfully!\nSuccessful matches: {successful_count}\nNot enough confidence: {failed_count}\nSkipped: {skipped_count}\nTotal functions analyzed: {total_count}", QMessageBox.Ok)
298+
300299
if successful_count > 0 and self.edit_datatypes.isChecked():
301300
self.start_fetching_data_types()
302301
else:
303-
QMessageBox.information(self, "RevEng.AI Match Functions", f"Function matching completed successfully!\nSuccessful matches: {successful_count}\nNot enough confidence: {failed_count}\nSkipped: {skipped_count}\nTotal functions analyzed: {total_count}", QMessageBox.Ok)
302+
QMessageBox.information(self, "RevEng.AI: Function matching", f"Function matching completed successfully!\nSuccessful matches: {successful_count}\nNot enough confidence: {failed_count}\nSkipped: {skipped_count}\nTotal functions analyzed: {total_count}", QMessageBox.Ok)
304303

305304
else:
306305
self.populate_results_table([])
307306
log_error(f"RevEng.AI | Function matching failed: {data}")
308-
QMessageBox.critical(self, "RevEng.AI Match Functions Error", f"Failed to match functions:\n{data}", QMessageBox.Ok)
307+
QMessageBox.critical(self, "RevEng.AI: Function matching", f"Failed to match functions:\n{data}", QMessageBox.Ok)
309308

310309

311310
def populate_results_table(self, results):

‎reai_toolkit/features/match_functions/__init__.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ def __init__(self, config=None):
1111

1212
def register(self):
1313
PluginCommand.register(
14-
"RevEng.AI\\\u200b\u200bMatch Functions",
15-
"Search and match functions against RevEng.AI database",
14+
"RevEng.AI\\\u200b\u200bFunction matching",
15+
"Search and match functions against the RevEng.AI database",
1616
self.show_match_functions_dialog,
1717
self.is_valid
1818
)

‎reai_toolkit/features/match_functions/match_functions_dialog.py‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def _write_selected_binaries(self, final_string):
4646

4747

4848
def init_ui(self):
49-
self.setWindowTitle("RevEng.AI: Match Functions")
49+
self.setWindowTitle("RevEng.AI: Function matching")
5050
self.setMinimumSize(1000, 700)
5151
self.resize(1400, 950)
5252
self.selected_collections = []
@@ -69,7 +69,7 @@ def init_ui(self):
6969
info_layout = QVBoxLayout()
7070
title_label = QLabel("Function Matching")
7171
title_label.setStyleSheet("font-size: 18px; font-weight: bold;")
72-
description_label = QLabel("Select functions and run ANN; Review results per function.")
72+
description_label = QLabel("Match functions in this binary against previously seen samples")
7373
description_label.setWordWrap(True)
7474
info_layout.addWidget(title_label)
7575
info_layout.addWidget(description_label)
@@ -266,7 +266,7 @@ def init_ui(self):
266266
def start_matching(self):
267267
log_info("RevEng.AI | Starting function matching process")
268268

269-
self.progress = create_cancellable_progress_dialog(self, "RevEng.AI Match Functions", "Matching functions...", self.match_functions.cancel)
269+
self.progress = create_cancellable_progress_dialog(self, "RevEng.AI: Function matching", "Matching functions...", self.match_functions.cancel)
270270
self.progress.show()
271271
QCoreApplication.processEvents()
272272

@@ -293,17 +293,16 @@ def on_matching_finished(self, success, data):
293293
skipped_count = data["skipped"]
294294
failed_count = data["failed"]
295295
total_count = successful_count + skipped_count + failed_count
296-
297-
#QMessageBox.information(self, "RevEng.AI Match Functions", f"Function matching completed successfully!\nSuccessful matches: {successful_count}\nNot enough confidence: {failed_count}\nSkipped: {skipped_count}\nTotal functions analyzed: {total_count}", QMessageBox.Ok)
296+
298297
if successful_count > 0 and self.edit_datatypes.isChecked():
299298
self.start_fetching_data_types()
300299
else:
301-
QMessageBox.information(self, "RevEng.AI Match Functions", f"Function matching completed successfully!\nSuccessful matches: {successful_count}\nNot enough confidence: {failed_count}\nSkipped: {skipped_count}\nTotal functions analyzed: {total_count}", QMessageBox.Ok)
300+
QMessageBox.information(self, "RevEng.AI: Function matching", f"Function matching completed successfully!\nSuccessful matches: {successful_count}\nNot enough confidence: {failed_count}\nSkipped: {skipped_count}\nTotal functions analyzed: {total_count}", QMessageBox.Ok)
302301

303302
else:
304303
self.populate_results_table([])
305304
log_error(f"RevEng.AI | Function matching failed: {data}")
306-
QMessageBox.critical(self, "RevEng.AI Match Functions Error", f"Failed to match functions:\n{data}", QMessageBox.Ok)
305+
QMessageBox.critical(self, "RevEng.AI: Function matching", f"Failed to match functions:\n{data}", QMessageBox.Ok)
307306

308307

309308
def populate_results_table(self, results):

0 commit comments

Comments
 (0)