remove debug statements in concurrency

Author: alerickson

src/code/InstallHelper.cs

@@ -924,7 +924,7 @@ private ConcurrentDictionary<string, Hashtable> InstallParentAndDependencyPackag
             // TODO: figure out a good threshold and parallel count
             int processorCount = Environment.ProcessorCount;
             _cmdletPassedIn.WriteDebug($"parentAndDeps.Count is {parentAndDeps.Count}, processor count is: {processorCount}");
-            if (parentAndDeps.Count > processorCount)
+            if (parentAndDeps.Count > 0)
             {
                  _cmdletPassedIn.WriteDebug($"parentAndDeps.Count is greater than processor count");
                 // Set the maximum degree of parallelism to 32? (Invoke-Command has default of 32, that's where we got this number from)
@@ -937,12 +937,34 @@ private ConcurrentDictionary<string, Hashtable> InstallParentAndDependencyPackag
                     var depPkgVersion = depPkg.Version.ToString();
 
                     Stream responseStream = currentServer.InstallPackage(depPkgName, depPkgVersion, true, out ErrorRecord installNameErrRecord);
+
+                    var nullresp = false;
+                    if (responseStream == null)
+                    {
+                        nullresp = true;
+                    }
+
+                    // if (currentServer.Repository.ApiVersion == PSRepositoryInfo.APIVersion.V2)
+                    // {
+                    //     // See if the network call we're making is already cached, if not, call FindNameAsync() and cache results
+                    //     string key = $"{dep.Name}|{dep.VersionRange.MaxVersion.ToString()}|{_type}";
+                    //     response = _cachedNetworkCalls.GetOrAdd(key, _ => currentServer.FindVersionAsync(dep.Name, dep.VersionRange.MaxVersion.ToString(), _type));
+                        
+                    //     responses = response.GetAwaiter().GetResult();
+                    // }
+                    // else
+                    // {
+                    //     responses = currentServer.FindVersion(dep.Name, dep.VersionRange.MaxVersion.ToString(), _type, out errRecord);
+                    // }
+
+
+
                     //_cmdletPassedIn.WriteDebug("In BeginInstallPackage 938");
 
                     if (installNameErrRecord != null)
                     {
                       //  _cmdletPassedIn.WriteDebug("In BeginInstallPackage 942");
-                        errors.Add(installNameErrRecord);
+                        //errors.Add(installNameErrRecord);
                     }
                    // _cmdletPassedIn.WriteDebug("In BeginInstallPackage 945");
                     ErrorRecord tempSaveErrRecord = null, tempInstallErrRecord = null;
@@ -951,7 +973,7 @@ private ConcurrentDictionary<string, Hashtable> InstallParentAndDependencyPackag
 
                     if (!installedToTempPathSuccessfully)
                     {
-                        errors.Add(tempSaveErrRecord ?? tempInstallErrRecord);
+                        //errors.Add(tempSaveErrRecord ?? tempInstallErrRecord);
                     }
                 });
 
@@ -965,7 +987,7 @@ private ConcurrentDictionary<string, Hashtable> InstallParentAndDependencyPackag
 
                     return packagesHash;
                 }
-                if (string.IsNullOrEmpty(warning))
+                if (!string.IsNullOrEmpty(warning))
                 {
                     _cmdletPassedIn.WriteWarning(warning);
                 }
@@ -1081,6 +1103,10 @@ private bool TryInstallToTempPath(
             {
                 var pathToFile = Path.Combine(tempInstallPath, $"{pkgName}.{normalizedPkgVersion}.zip");
                 using var fs = File.Create(pathToFile);
+                if (responseStream == null)
+                {
+                    throw new InvalidOperationException("responseStream is null");
+                }
                 responseStream.Seek(0, System.IO.SeekOrigin.Begin);
                 responseStream.CopyTo(fs);
                 fs.Close();

src/code/Utils.cs

@@ -1333,7 +1333,6 @@ public static bool TryReadRequiredResourceFile(
                 out resourceInfo,
                 out error);
         }
-
         private static bool TryReadPSDataFile(
             string filePath,
             string[] allowedVariables,
@@ -1354,84 +1353,70 @@ private static bool TryReadPSDataFile(
 
                 // Parallel.ForEach calls into this method.
                 // Each thread needs its own runspace created to provide a separate environment for operations to run independently.
-                // The runspace must be disposed when done and DefaultRunspace must be set/restored per-thread
-                // to prevent cross-contamination when thread-pool threads are reused across tests.
                 Runspace runspace = RunspaceFactory.CreateRunspace();
                 runspace.Open();
                 runspace.SessionStateProxy.LanguageMode = PSLanguageMode.ConstrainedLanguage;
 
-                // Save and set the default runspace for the current thread to prevent
-                // stale DefaultRunspace from a prior operation on this reused thread-pool thread.
-                Runspace previousDefaultRunspace = Runspace.DefaultRunspace;
-                try
+                // Set the created runspace as the default for the current thread
+                //Runspace.DefaultRunspace = runspace;
+
+                using (System.Management.Automation.PowerShell pwsh = System.Management.Automation.PowerShell.Create())
                 {
-                    Runspace.DefaultRunspace = runspace;
+                    pwsh.Runspace = runspace;
 
-                    using (System.Management.Automation.PowerShell pwsh = System.Management.Automation.PowerShell.Create())
-                    {
-                        pwsh.Runspace = runspace;
+                    var cmd = new Command(
+                        command: contents,
+                        isScript: true,
+                        useLocalScope: true);
+                    cmd.MergeMyResults(
+                        myResult: PipelineResultTypes.Error | PipelineResultTypes.Warning | PipelineResultTypes.Verbose | PipelineResultTypes.Debug | PipelineResultTypes.Information,
+                        toResult: PipelineResultTypes.Output);
+                    pwsh.Commands.AddCommand(cmd);
 
-                        var cmd = new Command(
-                            command: contents,
-                            isScript: true,
-                            useLocalScope: true);
-                        cmd.MergeMyResults(
-                            myResult: PipelineResultTypes.Error | PipelineResultTypes.Warning | PipelineResultTypes.Verbose | PipelineResultTypes.Debug | PipelineResultTypes.Information,
-                            toResult: PipelineResultTypes.Output);
-                        pwsh.Commands.AddCommand(cmd);
 
-                        try
-                        {
-                            // Invoke the pipeline and retrieve the results
-                            var results = pwsh.Invoke();
+                    try
+                    {
+                        // Invoke the pipeline and retrieve the results
+                        var results = pwsh.Invoke();
 
-                            if (results[0] is PSObject pwshObj)
+                        if (results[0] is PSObject pwshObj)
+                        {
+                            switch (pwshObj.BaseObject)
                             {
-                                switch (pwshObj.BaseObject)
-                                {
-                                    case ErrorRecord err:
-                                        //_cmdletPassedIn.WriteError(error);
-                                        break;
+                                case ErrorRecord err:
+                                    //_cmdletPassedIn.WriteError(error);
+                                    break;
 
-                                    case WarningRecord warning:
-                                        //cmdlet.WriteWarning(warning.Message);
-                                        break;
+                                case WarningRecord warning:
+                                    //cmdlet.WriteWarning(warning.Message);
+                                    break;
 
-                                    case VerboseRecord verbose:
-                                        //cmdlet.WriteVerbose(verbose.Message);
-                                        break;
+                                case VerboseRecord verbose:
+                                    //cmdlet.WriteVerbose(verbose.Message);
+                                    break;
 
-                                    case DebugRecord debug:
-                                        //cmdlet.WriteDebug(debug.Message);
-                                        break;
+                                case DebugRecord debug:
+                                    //cmdlet.WriteDebug(debug.Message);
+                                    break;
 
-                                    case InformationRecord info:
-                                        //cmdlet.WriteInformation(info);
-                                        break;
+                                case InformationRecord info:
+                                    //cmdlet.WriteInformation(info);
+                                    break;
 
-                                    case Hashtable result:
-                                        dataFileInfo = result;
-                                        return true;
-                                }
+                                case Hashtable result:
+                                    dataFileInfo = result;
+                                    return true;
                             }
                         }
-                        catch (Exception ex)
-                        {
-                            error = ex;
-                        }
                     }
-                    // Return false to indicate "we couldn't parse a valid Hashtable from this .psd1 file." 
-                    // The only success path is the 'case Hashtable result' branch above which does return true.
-                    return false;
-                }
-                finally
-                {
-                    // Always restore the previous default runspace and close/dispose
-                    // the per-thread runspace, even on success (return true) or exception paths.
-                    Runspace.DefaultRunspace = previousDefaultRunspace;
-                    runspace.Close();
-                    runspace.Dispose();
+                    catch (Exception ex)
+                    {
+                        error = ex;
+                    }
                 }
+                runspace.Close();
+                
+                return false;
             }
             catch (Exception ex)
             {