Add tests for Save-PSResource and Install-PSResource

Author: anamnavi

src/code/InstallHelper.cs

@@ -1632,21 +1632,24 @@ private bool RetrieveExternalModuleDependenciesForModule(string pkgName, Hashtab
             Hashtable privateData = moduleMetadata.ContainsKey("PrivateData") ? moduleMetadata["PrivateData"] as Hashtable : new Hashtable(StringComparer.InvariantCultureIgnoreCase);
             Hashtable psData = privateData.ContainsKey("PSData") ? privateData["PSData"] as Hashtable : new Hashtable(StringComparer.InvariantCultureIgnoreCase);
             object[] externalModDepObjects = psData.ContainsKey("ExternalModuleDependencies") ? psData["ExternalModuleDependencies"] as object[] : new object[0];
-            foreach (var dep in externalModDepObjects)
+            if (externalModDepObjects != null)
             {
-                string dependencyName = dep as string;
-                if (dependencyName.Contains("="))
+                foreach (var dep in externalModDepObjects)
                 {
-                    error = new ErrorRecord(
-                    new ArgumentException($"Package '{pkgName}' could not be installed: ExternalModuleDependencies should only contain module names, not other metadata. Invalid entry: '{dependencyName}'"),
-                    "ExternalModuleDependencyInvalidEntry",
-                    ErrorCategory.ReadError,
-                    _cmdletPassedIn);
+                    string dependencyName = dep as string;
+                    if (dependencyName.Contains("="))
+                    {
+                        error = new ErrorRecord(
+                        new ArgumentException($"Package '{pkgName}' could not be installed: ExternalModuleDependencies should only contain module names, not other metadata. Invalid entry: '{dependencyName}'"),
+                        "ExternalModuleDependencyInvalidEntry",
+                        ErrorCategory.ReadError,
+                        _cmdletPassedIn);
 
-                    return false;
-                }
+                        return false;
+                    }
 
-                externalModuleDependenciesForPkg.Add(dependencyName);
+                    externalModuleDependenciesForPkg.Add(dependencyName);
+                }
             }
 
             externalModuleDependencies = externalModuleDependenciesForPkg.ToArray();

test/InstallPSResourceTests/InstallPSResourceV2Server.Tests.ps1

@@ -646,7 +646,15 @@ Describe 'Test Install-PSResource for V2 Server scenarios' -tags 'CI' {
         $depRes = Get-InstalledPSResource $depPkgName1, $depPkgName2
         $depRes.Name | Should -Contain $depPkgName1
         $depRes.Name | Should -Contain $depPkgName2
-    }    
+    }
+
+    It "Install resource and dependency, while skipping dependency that is listed as external module dependency" {
+        $testParentModule = "test_module_ext_dep"
+        $requiredDependency = "test_module10"
+        $res = Install-PSresource -Name "test_module_ext_dep" -Repository $PSGalleryName -TrustRepository -PassThru
+        $res.Name | Should -Contain $testParentModule
+        $res.Name | Should -Contain $requiredDependency
+    }
 }
 
 Describe 'Test Install-PSResource for V2 Server scenarios' -tags 'ManualValidationOnly' {

test/SavePSResourceTests/SavePSResourceV2.Tests.ps1

@@ -214,4 +214,20 @@ Describe 'Test HTTP Save-PSResource for V2 Server Protocol' -tags 'CI' {
         $err.Count | Should -BeGreaterThan 0
         $err[0].FullyQualifiedErrorId | Should -BeExactly 'ErrorFilteringNamesForUnsupportedWildcards,Microsoft.PowerShell.PSResourceGet.Cmdlets.SavePSResource'
     }
+
+    It "Save resource and dependency, while skipping dependency that is listed as external module dependency" {
+        $testParentModule = "test_module_ext_dep"
+        $requiredDependency = "test_module10"
+        $res = Save-PSresource -Name "test_module_ext_dep" -Repository $PSGalleryName -Path $SaveDir -TrustRepository -PassThru
+        $res.Name | Should -Contain $testParentModule
+        $res.Name | Should -Contain $requiredDependency
+    }
+
+    It "Save resource and dependency, as .nupkg, while skipping dependency that is listed as external module dependency" {
+        $testParentModule = "test_module_ext_dep"
+        $requiredDependency = "test_module10"
+        $res = Save-PSresource -Name "test_module_ext_dep" -Repository $PSGalleryName -AsNupkg -Path $SaveDir -TrustRepository -PassThru
+        $res.Name | Should -Contain $testParentModule
+        $res.Name | Should -Contain $requiredDependency
+    }
 }