Merge pull request #233 from GeVa2072/bugfix/missing_error_message_on_not_writable_filesystem

xbgmsharp · web-flow · commit 4b70df527155 · 2023-08-03T11:39:32.000+02:00
Fix missing error report on installation when file system not writable.
diff --git a/maintain.class.php b/maintain.class.php
@@ -157,7 +157,10 @@ function install($plugin_version, &$errors=array())
   include_once( PHPWG_ROOT_PATH. 'plugins/piwigo-openstreetmap/osmmap3.php');
 ?>
 EOF;
-      file_put_contents(PHPWG_ROOT_PATH.'osmmap.php', $c);
+      if (!file_put_contents(PHPWG_ROOT_PATH.'osmmap.php', $c)) {
+        error_reporting($_error_reporting);
+        throw new SmartyException("unable to write file {$PHPWG_ROOT_PATH.'osmmap.php'}");
+      }      
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,10 @@ function install($plugin_version, &$errors=array())`
`157`	`157`	`include_once( PHPWG_ROOT_PATH. 'plugins/piwigo-openstreetmap/osmmap3.php');`
`158`	`158`	`?>`
`159`	`159`	`EOF;`
`160`		`- file_put_contents(PHPWG_ROOT_PATH.'osmmap.php', $c);`
	`160`	`+ if (!file_put_contents(PHPWG_ROOT_PATH.'osmmap.php', $c)) {`
	`161`	`+ error_reporting($_error_reporting);`
	`162`	`+ throw new SmartyException("unable to write file {$PHPWG_ROOT_PATH.'osmmap.php'}");`
	`163`	`+ }`
`161`	`164`	`}`
`162`	`165`	`}`
`163`	`166`