Login options testing

Author: ReightI

l10n/app_en.arb

@@ -79,8 +79,11 @@
     "login_connectionChanged": "Connection Changed!",
     "loginHTTP_title": "HTTP Credentials",
     "loginHTTP_message": "Basic access authentification is required by the Piwigo server:",
+    "loginHTTP_enable": "Enable HTTP Basic",
     "loginHTTPuser_placeholder": "Username",
     "loginHTTPpwd_placeholder": "Password",
+    "loginCert_title": "Self Signed Certificates",
+    "loginCert_enable": "Allow SSL",
     "loginCertFailed_title": "Connection Not Private",
     "loginCertFailed_message": "Piwigo warns you when a website has a certificate that is not valid. Do you still want to accept this certificate?",
     "loginHTTPSfailed_title": "Secure Connection Failed",

l10n/app_fr.arb

@@ -50,8 +50,11 @@
     "login_connectionChanged": "Connexion Modifiée !",
     "loginHTTP_title": "Identification HTTP",
     "loginHTTP_message": "L'authentification HTTP est requise par le serveur Piwigo:",
+    "loginHTTP_enable": "Activer HTTP Basic",
     "loginHTTPuser_placeholder": "Identifiant",
     "loginHTTPpwd_placeholder": "Mot de Passe",
+    "loginCert_title": "Certificats auto-signés",
+    "loginCert_enable": "Authoriser les SSL",
     "loginCertFailed_title": "Connexion Non Privée",
     "loginCertFailed_message": "Piwigo vous avertit lorsqu'un site web a un certificat non valide. Voulez-vous toujours accepter ce certificat ?",
     "loginHTTPSfailed_title": "Échec de la Connexion Sécurisée",

lib/api/api_interceptor.dart

@@ -1,4 +1,5 @@
 import 'dart:convert';
+import 'dart:io';
 
 import 'package:dio/dio.dart';
 import 'package:flutter/material.dart';
@@ -44,6 +45,13 @@ class ApiInterceptor extends Interceptor {
     debugPrint(
         "[${err.response?.statusCode}] ${err.requestOptions.queryParameters['method']}");
     debugPrint('${err.error}\n${err.stackTrace}');
+    if (err.error is HandshakeException) {
+      HandshakeException handshakeError = err.error as HandshakeException;
+      String? message = handshakeError.osError?.message;
+      if (message != null && message.contains('CERTIFICATE_VERIFY_FAILED')) {
+        // Invalid SSL
+      }
+    }
     switch (err.response?.statusCode) {
       case null:
         App.scaffoldMessengerKey.currentState?.showSnackBar(

lib/components/fields/settings_field.dart

@@ -10,12 +10,14 @@ class SettingsField extends StatelessWidget {
     this.keyboardType,
     this.padding,
     this.focusNode,
+    this.isObscure = false,
   }) : super(key: key);
 
   final TextEditingController? controller;
   final FocusNode? focusNode;
   final TextInputType? keyboardType;
   final String? hint;
+  final bool isObscure;
   final EdgeInsets? padding;
   final Function(String)? onChanged;
   final Function(String)? onFieldSubmitted;
@@ -32,6 +34,7 @@ class SettingsField extends StatelessWidget {
         onChanged: onChanged,
         onFieldSubmitted: onFieldSubmitted,
         style: Theme.of(context).textTheme.bodyMedium,
+        obscureText: isObscure,
         decoration: InputDecoration(
           border: InputBorder.none,
           hintText: hint,

lib/components/sections/settings_section.dart

@@ -404,11 +404,13 @@ class SettingsSectionItemField extends StatefulWidget {
     required this.onChanged,
     this.hint,
     required this.value,
+    this.isObscure = false,
   }) : super(key: key);
 
   final String? title;
   final String? hint;
   final String value;
+  final bool isObscure;
   final Function(String) onChanged;
 
   @override
@@ -428,11 +430,11 @@ class _SettingsSectionItemFieldState extends State<SettingsSectionItemField> {
   @override
   Widget build(BuildContext context) {
     return SettingsSectionItem(
-      // title: widget.title,
       expandedChild: true,
       child: SettingsField(
         controller: _controller,
         hint: widget.hint,
+        isObscure: widget.isObscure,
         onChanged: widget.onChanged,
       ),
     );

lib/views/authentication/login_settings_page.dart

@@ -46,10 +46,10 @@ class _LoginSettingsPageState extends State<LoginSettingsPage> {
         ),
         children: [
           SettingsSection(
-            title: 'Invalid Certificates', // todo : translate
+            title: appStrings.loginCert_title,
             children: [
               SettingsSectionItemSwitch(
-                title: 'Enable SSL', // todo : translate
+                title: appStrings.loginCert_enable,
                 value: _sslEnabled,
                 onChanged: (value) => setState(() {
                   _sslEnabled = value;
@@ -62,10 +62,10 @@ class _LoginSettingsPageState extends State<LoginSettingsPage> {
             ],
           ),
           SettingsSection(
-            title: 'HTTP Authorization', // todo : translate
+            title: appStrings.loginHTTP_title,
             children: [
               SettingsSectionItemSwitch(
-                title: 'Enable Basic Auth', // todo : translate
+                title: appStrings.loginHTTP_enable,
                 value: _basiAuth,
                 onChanged: (value) => setState(() {
                   _basiAuth = value;
@@ -83,7 +83,7 @@ class _LoginSettingsPageState extends State<LoginSettingsPage> {
                     return Column(
                       children: [
                         SettingsSectionItemField(
-                          hint: 'Username', // todo : translate
+                          hint: appStrings.loginHTTPuser_placeholder,
                           value: _basicAuthUsername,
                           onChanged: (value) => setState(() {
                             _basicAuthUsername = value;
@@ -98,8 +98,9 @@ class _LoginSettingsPageState extends State<LoginSettingsPage> {
                           thickness: 1,
                         ),
                         SettingsSectionItemField(
-                          hint: 'Password', // todo : translate
+                          hint: appStrings.loginHTTPpwd_placeholder,
                           value: _basicAuthPassword,
+                          isObscure: true,
                           onChanged: (value) => setState(() {
                             _basicAuthPassword = value;
                             appPreferences.setString(