Skip to content

Commit b520740

Browse files
committed
Make keystore properties cast nullable
In groovy there is no need to cast to string but in kotlin you cast keystoreProperties["XXXX"] to String which fail on null, there is two solution force every user who want to contribute to have a keystore or allow nullable keystoreProperties. I went with the latter to limit contributor friction.
1 parent 19b2b8c commit b520740

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

android/app/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@ android {
4545

4646
signingConfigs {
4747
create("release") {
48-
keyAlias = keystoreProperties["keyAlias"] as String
49-
keyPassword = keystoreProperties["keyPassword"] as String
48+
keyAlias = keystoreProperties["keyAlias"] as? String
49+
keyPassword = keystoreProperties["keyPassword"] as? String
5050
storeFile = keystoreProperties["storeFile"]?.let { file(it) }
51-
storePassword = keystoreProperties["storePassword"] as String
51+
storePassword = keystoreProperties["storePassword"] as? String
5252
}
5353
}
5454

0 commit comments

Comments
 (0)