Skip to content

Commit 5046dc8

Browse files
committed
Add DEBUG-TODO.md file
1 parent 2105600 commit 5046dc8

1 file changed

Lines changed: 34 additions & 0 deletions

File tree

DEBUG-TODO.md

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# Debug TODO
2+
3+
## Deferred: `PiwigoAPI.checkPhoto` tri-state handling
4+
5+
Goal: avoid duplicate uploads when `checkPhoto` fails for transient/API reasons.
6+
7+
### Proposed approach
8+
9+
- Classify `checkPhoto` outcomes as:
10+
- `exists`
11+
- `not_found` (authoritative missing)
12+
- `check_failed` (network/session/timeout/unknown response)
13+
- In `PublishTaskImageProcessing.processRenderedPhotos`:
14+
- Upload only on confirmed `not_found`
15+
- Retry (or relogin + retry) on `check_failed`
16+
- If still uncertain after retry, fail/defer safely instead of assuming missing
17+
- Add clear logging for outcome class at each decision point.
18+
19+
### Safety / rollout
20+
21+
- Do not change `PiwigoAPI.checkPhoto` behavior globally until all call sites are reviewed.
22+
- Start with local handling at the `processRenderedPhotos` call site.
23+
- Then review all other `checkPhoto` call sites for compatibility before shared API changes.
24+
25+
## Deferred: render optimization
26+
27+
- Investigate skipping the first default render when per-album custom settings are enabled.
28+
- Revisit `rendition:skipRender()` reliability and callback behavior.
29+
- Consider applying the same skip strategy to association/no-upload scenarios.
30+
31+
## Current status
32+
33+
- Custom re-render resize path is working (confirmed upload at 1024x683).
34+
- Property table wrapper (`"< contents >"`) is now being unwrapped for custom render settings.

0 commit comments

Comments
 (0)