fix(denoise): bypass xarray/dask quantile — compute eagerly via numpy

Both the xarray→nanquantile and xarray→dask→map_blocks quantile paths
in dask 2024.12.x pass the removed 'interpolation' kwarg to numpy 2.x.
Bypass the entire xarray/dask quantile dispatch and compute eagerly with
np.nanquantile(method='linear') on materialised values.

Author: beatfactor

oceanstream/echodata/denoise/background_noise.py

@@ -190,16 +190,21 @@ def background_noise_mask(
     if depth_stat == "min":
         noise_1d_db = binned_db.min(dim=range_dim, skipna=True)
     elif depth_stat == "quantile":
-        # Use skipna=False to avoid the xarray → dask → np.nanquantile
-        # code path where dask 2024.12.x passes the removed 'interpolation'
-        # kwarg to numpy 2.x's nanquantile.  We drop NaN slices ourselves
-        # before computing the quantile.
-        _binned = binned_db.fillna(0.0) if binned_db.isnull().any() else binned_db
-        noise_1d_db = _binned.quantile(
-            depth_quantile, dim=range_dim, method="linear", skipna=False
-        )
-        if "quantile" in noise_1d_db.dims:
-            noise_1d_db = noise_1d_db.squeeze("quantile", drop=True)
+        # Bypass xarray/dask quantile entirely — dask 2024.12.x passes the
+        # removed 'interpolation' kwarg to numpy 2.x in both the nanquantile
+        # and map_blocks/quantile code paths.  Compute eagerly via numpy.
+        import numpy as _np
+
+        _vals = binned_db.values if hasattr(binned_db, 'values') else binned_db
+        _vals = _np.asarray(_vals, dtype=_np.float64)
+        axis = binned_db.dims.index(range_dim)
+        noise_arr = _np.nanquantile(_vals, depth_quantile, axis=axis, method="linear")
+        remaining_dims = [d for d in binned_db.dims if d != range_dim]
+        remaining_coords = {
+            k: v for k, v in binned_db.coords.items()
+            if k in remaining_dims
+        }
+        noise_1d_db = xr.DataArray(noise_arr, dims=remaining_dims, coords=remaining_coords)
     else:
         raise ValueError("depth_stat must be 'min' or 'quantile'.")