fix: use HandleDamage for explosive kill weapon attribution (#68)

* fix: use HandleDamage for explosive kill weapon attribution

lastFired is a per-killer variable that gets overwritten by any
subsequent fire event. This makes it unreliable for explosive kills
where there is a temporal gap between detonation and the kill handler
reading the value (e.g. player fires weapon after placing mine but
before mine detonates and kills).

Instead, add a HandleDamage EH to tracked units that stores the ammo
classname on the victim. At kill time, check if the damage ammo
indicates an explosive (indirectHitRange > 1) and derive the display
name from CfgAmmo config. Fall back to lastFired for bullet kills
where it works correctly.

- Add HandleDamage EH via CBA Class EH with Local EH lifecycle
- Read lastDamageAmmo from victim in kill handler
- Check for explosive ammo before existing lastFired logic
- Remove redundant lastFired override from ACE Explode EH

* add debug logging for kill weapon attribution

KILL_DEBUG: logs victim, instigator, lastDamageAmmo, lastFired, and
resolved eventText for every kill when debug mode is enabled.

WEAPON_EXPLOSIVE: logs when HandleDamage ammo is used for explosive
kill attribution instead of lastFired.

* make kill attribution debug logs unconditional for dev testing

* switch debug logs to diag_log for RPT output

* remove dev debug logging for kill attribution

Author: fank

addons/recorder/fnc_aceExplosives.sqf

@@ -67,10 +67,6 @@ _explosive addEventHandler ["Explode", {
 
   _data params ["_explosiveDisp", "_unit", "_placedPos", "_markName", "_int"];
 
-  // Set unit who placed's lastFired var as the explosive so kills are registered to the explosive
-  // Broadcast to server (owner 2) so kill handler can read it
-  _unit setVariable [QGVARMAIN(lastFired), ["", _explosiveDisp, ""], 2];
-
   if (GVARMAIN(isDebug)) then {
     format["Removed explosive placed marker, %1, %2", _markName, _explosiveDisp] SYSCHAT;
     OCAPEXTLOG(ARR3("Removed explosive placed marker",_markName,_explosiveDisp));

addons/recorder/fnc_eh_fired_server.sqf

@@ -46,6 +46,16 @@ missionNamespace setVariable [QFUNCMAIN(addBulletEH), FUNC(eh_fired_clientBullet
     }];
     _entity setVariable [QGVARMAIN(firedManEHExists), true];
     _entity setVariable [QGVARMAIN(firedManEH), _id];
+
+    // HandleDamage stores the ammo classname on the victim for kill attribution
+    private _hdId = _entity addEventHandler ["HandleDamage", {
+      params ["_unit", "", "", "", "_projectile"];
+      if (_projectile isNotEqualTo "" && {_projectile isNotEqualTo (_unit getVariable [QGVARMAIN(lastDamageAmmo), ""])}) then {
+        _unit setVariable [QGVARMAIN(lastDamageAmmo), _projectile, 2];
+      };
+    }];
+    _entity setVariable [QGVARMAIN(handleDamageEHExists), true];
+    _entity setVariable [QGVARMAIN(handleDamageEH), _hdId];
   } else {
     [_entity, {
       private _id = _this addEventHandler ["FiredMan", {
@@ -55,6 +65,15 @@ missionNamespace setVariable [QFUNCMAIN(addBulletEH), FUNC(eh_fired_clientBullet
       }];
       _this setVariable [QGVARMAIN(firedManEHExists), true];
       _this setVariable [QGVARMAIN(firedManEH), _id];
+
+      private _hdId = _this addEventHandler ["HandleDamage", {
+        params ["_unit", "", "", "", "_projectile"];
+        if (_projectile isNotEqualTo "" && {_projectile isNotEqualTo (_unit getVariable [QGVARMAIN(lastDamageAmmo), ""])}) then {
+          _unit setVariable [QGVARMAIN(lastDamageAmmo), _projectile, 2];
+        };
+      }];
+      _this setVariable [QGVARMAIN(handleDamageEHExists), true];
+      _this setVariable [QGVARMAIN(handleDamageEH), _hdId];
     }] remoteExec ["call", owner _entity];
   };
 
@@ -67,13 +86,19 @@ missionNamespace setVariable [QFUNCMAIN(addBulletEH), FUNC(eh_fired_clientBullet
     // If the unit is NO LONGER local, remove the EH and the CBA EH.
     // We need to see if it exists already.
     private _firedManEHExists = _entity getVariable [QGVARMAIN(firedManEHExists), false];
+    private _handleDamageEHExists = _entity getVariable [QGVARMAIN(handleDamageEHExists), false];
 
     // If the unit is NO LONGER local, and the EH exists, remove it.
     if (!_isLocal && _firedManEHExists) then {
       _entity removeEventHandler ["FiredMan", _entity getVariable QGVARMAIN(firedManEH)];
       _entity setVariable [QGVARMAIN(firedManEHExists), false];
       _entity setVariable [QGVARMAIN(firedManEH), nil];
     };
+    if (!_isLocal && _handleDamageEHExists) then {
+      _entity removeEventHandler ["HandleDamage", _entity getVariable QGVARMAIN(handleDamageEH)];
+      _entity setVariable [QGVARMAIN(handleDamageEHExists), false];
+      _entity setVariable [QGVARMAIN(handleDamageEH), nil];
+    };
 
     // If the unit is NOW local and the EH doesn't exist, add it.
     if (_isLocal && !_firedManEHExists) then {
@@ -86,6 +111,16 @@ missionNamespace setVariable [QFUNCMAIN(addBulletEH), FUNC(eh_fired_clientBullet
       _entity setVariable [QGVARMAIN(firedManEHExists), true];
       _entity setVariable [QGVARMAIN(firedManEH), _id];
     };
+    if (_isLocal && !_handleDamageEHExists) then {
+      private _hdId = _entity addEventHandler ["HandleDamage", {
+        params ["_unit", "", "", "", "_projectile"];
+        if (_projectile isNotEqualTo "" && {_projectile isNotEqualTo (_unit getVariable [QGVARMAIN(lastDamageAmmo), ""])}) then {
+          _unit setVariable [QGVARMAIN(lastDamageAmmo), _projectile, 2];
+        };
+      }];
+      _entity setVariable [QGVARMAIN(handleDamageEHExists), true];
+      _entity setVariable [QGVARMAIN(handleDamageEH), _hdId];
+    };
   }];
 
 // for the class event handler,

addons/recorder/fnc_eh_killed.sqf

@@ -71,7 +71,9 @@ if !(_victim getvariable [QGVARMAIN(isKilled),false]) then {
       _killerId = _instigator getVariable [QGVARMAIN(id), -1];
       if (_killerId == -1) exitWith {};
 
-      private _eventText = [_instigator] call FUNC(getEventWeaponText);
+      private _lastDamageAmmo = _victim getVariable [QGVARMAIN(lastDamageAmmo), ""];
+      private _eventText = [_instigator, _lastDamageAmmo] call FUNC(getEventWeaponText);
+
       private _killerInfo = [];
       // if (_instigator isKindOf "CAManBase") then {
         _killerInfo = [

addons/recorder/fnc_getEventWeaponText.sqf

@@ -27,7 +27,7 @@ Author:
 ---------------------------------------------------------------------------- */
 #include "script_component.hpp"
 
-params ["_instigator"];
+params ["_instigator", ["_damageAmmo", ""]];
 
 if (isNull _instigator) exitWith {["", "", ""]};
 
@@ -40,6 +40,24 @@ if !(_instigator call CBA_fnc_isPerson) then {
   };
 };
 
+// Check HandleDamage ammo for explosive kills (mines, placed explosives)
+// Only for on-foot instigators — vehicle kills use turret weapon info below
+private _explosiveWeaponText = [];
+if (_damageAmmo isNotEqualTo "" && {_instigator call CBA_fnc_isPerson} && {isNull objectParent _instigator}) then {
+  private _indirectHitRange = getNumber(configFile >> "CfgAmmo" >> _damageAmmo >> "indirectHitRange");
+  if (_indirectHitRange > 1) then {
+    private _mag = getText(configFile >> "CfgAmmo" >> _damageAmmo >> "defaultMagazine");
+    private _magDisp = getText(configFile >> "CfgMagazines" >> _mag >> "displayName");
+    if (_magDisp isEqualTo "") then {
+      _magDisp = getText(configFile >> "CfgAmmo" >> _damageAmmo >> "displayName");
+    };
+    if (_magDisp isNotEqualTo "") then {
+      _explosiveWeaponText = ["", _magDisp, ""];
+    };
+  };
+};
+if (_explosiveWeaponText isNotEqualTo []) exitWith {_explosiveWeaponText};
+
 if (_instigator call CBA_fnc_isPerson) then {
   private _personalWeapon = {
     (_instigator weaponstate (currentWeapon _instigator)) params ["_weapon", "_muzzle", "_mode", "_magazine"];