feat(perps): sync controller code with extension (#28509)

## **Description**

Makes `@metamask/perps-controller` safe to consume from the MetaMask
extension without pulling `@myx-trade/sdk` into the static webpack
bundle or violating the LavaMoat policy. Mobile owns the source-of-truth
for the perps controller package via
`scripts/perps/validate-core-sync.sh`, so the fix is made in mobile and
then rsync'd to core on a matching branch.

Companion core PR: MetaMask/core#8398 —
supersedes MetaMask/core#8374.

### What changed

1. **`app/controllers/perps/PerpsController.ts`** — add `/*
webpackIgnore: true */` magic comment to the `MYXProvider` dynamic
`import()` so webpack (extension) skips static resolution of the
intentionally-unshipped module. Metro (mobile) ignores the magic
comment, so runtime behavior on mobile is unchanged.

2. **`app/controllers/perps/index.ts`** — remove 8 MYX adapter functions
from the public barrel (`adaptMarketFromMYX`, `adaptPriceFromMYX`,
`adaptMarketDataFromMYX`, `filterMYXExclusiveMarkets`,
`isOverlappingMarket`, `buildPoolSymbolMap`, `buildSymbolPoolsMap`,
`extractSymbolFromPoolId`). These are still used internally by
`MYXProvider`, which imports them via relative path
`../utils/myxAdapter`. No runtime change in mobile — the functions are
still available to MYXProvider.

3. **`app/controllers/perps/utils/index.ts`** — drop the `export * from
'./myxAdapter'` barrel re-export so the utils index no longer
transitively re-exports MYX symbols.

4. **Drift fix — `perpsConnectionAttemptContext`** — moved from
`app/util/perpsConnectionAttemptContext.ts` into
`app/controllers/perps/utils/perpsConnectionAttemptContext.ts` and
exported from `@metamask/perps-controller` so:
- `HyperLiquidClientService` (inside the perps package) imports it via a
relative path that stays inside the synced directory — required for the
core sync to build.
- `PerpsConnectionManager` (outside the perps package) imports it from
`@metamask/perps-controller` — satisfies the `no-restricted-imports`
rule for code outside `app/controllers/perps/`.

5. **`.eslintrc.js` — align mobile perps override with core's base
rules.** Added `BinaryExpression[operator='in']`, `WithStatement`, and
`SequenceExpression` selectors to the existing `no-restricted-syntax`
rule in the `app/controllers/perps/**` override. Mobile's override was
missing these, which meant `'x' in y` type-guards passed mobile lint
silently and then landed in core as new `no-restricted-syntax`
suppressions at sync time. The override now mirrors what
`@metamask/eslint-config` enforces in core, catching the violations at
source.

6. **Replace `'x' in y` with `hasProperty(y, 'x')` across 8
perps-controller files** — `HyperLiquidProvider.ts`,
`HyperLiquidSubscriptionService.ts`, `TradingService.ts`,
`marketDataTransform.ts`, `hyperLiquidAdapter.ts`, `types/index.ts`,
`types/transactionTypes.ts`, `utils/errorUtils.ts`. Uses `hasProperty`
from `@metamask/utils` (the idiomatic replacement documented in core's
eslint config). 24 of the 28 occurrences were converted cleanly; the
remaining 4 are kept as `'in'` behind `/* eslint-disable
no-restricted-syntax */` blocks because `hasProperty` narrows the KEY
but not the discriminated-union branch — losing access to `.filled`,
`.resting`, `.oid`, `.totalSz` on the HyperLiquid SDK types and losing
`keyof typeof HYPERLIQUID_ASSET_CONFIGS` narrowing. Each disable comment
is documented with the narrowing rationale.

7. **`scripts/perps/validate-core-sync.sh` — hardened preflight +
per-file suppression delta check.**
- **Preflight freshness check** (`chore(perps-sync): hard-fail sync
script when core main has drift`): the previous preflight only compared
the core working tree against `.sync-state.json.lastSyncedCoreCommit`,
so it could not detect that someone else had merged a competing
perps-controller change into `origin/main` while this branch was in
review. That gap let [#8398](MetaMask/core#8398)
land in a conflicting state with
[#8333](MetaMask/core#8333). The new check at
the top of `step_conflict_check` fetches `origin/main`, runs `git
rev-list --count HEAD..origin/main -- packages/perps-controller/`, and
**hard-fails** (not warns) with the offending commit list + a merge
suggestion if any such commits exist. Gracefully degrades to `WARN` if
offline or if `origin/main` is missing.
- **Per-file/per-rule suppression delta check** (`chore(perps-sync):
hard-fail on per-file suppression delta increase`): step 6 now snapshots
the per-file/per-rule suppression counts from `eslint-suppressions.json`
BEFORE running `--fix` / `--suppress-all` / `--prune-suppressions`, then
diffs against the post-run counts and hard-fails if any (file, rule)
pair's count INCREASED. Reducing counts (mobile fixes removing
previously-suppressed violations) is always allowed. Increases mean the
current sync is introducing NEW violations that would land in core as
fresh suppressions and must be fixed at source. The script prints every
offending file+rule pair and points at `hasProperty()` from
`@metamask/utils` as the canonical replacement. Replaces the old "WARN
if count > 20" heuristic. This is the canonical local detection point
for the problem that *"it should have been detected locally!"* — a
violation now fails the sync script at step 6 BEFORE the core PR is
opened.

### Not included (intentional)

An earlier draft of this PR also declared
`MetaMetricsController:trackEvent` in `PerpsControllerAllowedActions` to
let the extension drop a type cast. That change was **reverted** because
mobile has no `MetaMetricsController` — it uses a `MetaMetrics`
singleton (`app/core/Analytics/MetaMetrics.ts`) — so adding the action
to the allowed-actions union forced `@metamask/messenger`'s parent type
to narrow to `never` and broke
`app/core/Engine/messengers/perps-controller-messenger/index.ts`. The
extension keeps its existing `as unknown as
PackagePerpsControllerMessenger` cast workaround until both host apps
share a real `MetaMetricsController`.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes:
[TAT-2863](https://consensyssoftware.atlassian.net/browse/TAT-2863)
Related: MetaMask/core#8374 (superseded by
companion core PR #8398)

## **Manual testing steps**

```gherkin
Feature: Perps controller behavior unchanged after MYX export cleanup

  Scenario: User opens the Perps tab on testnet
    Given the wallet is unlocked and funded on HyperLiquid testnet
    When user navigates to the Perps tab
    Then the markets list loads
    And the HyperLiquid provider is selected by default

  Scenario: User opens and closes a BTC long position
    Given the wallet has testnet funds
    When user opens a $11 BTC long market order
    Then a position appears in the positions list
    When user closes the position at 100%
    Then the position is removed from the positions list
```

Automated verification (all passing locally):
- `yarn lint` on all touched files — clean
- `NODE_OPTIONS='--max-old-space-size=8192' npx tsc --noEmit` — clean
(full, no incremental cache)
- `yarn jest app/controllers/perps/PerpsController.test.ts
app/controllers/perps/services/HyperLiquidSubscriptionService.test.ts
app/controllers/perps/services/TradingService.test.ts` — 412 passing
- `bash scripts/perps/validate-core-sync.sh --core-path …/core` — all 9
steps PASS. Suppression count drops from 30 → **6** after the lint
cleanup.

## **Screenshots/Recordings**

N/A — this PR is a bundler / import-graph + lint cleanup with zero UI
impact. Mobile runtime behavior is unchanged because:
- The `webpackIgnore` magic comment is extension/webpack-only; Metro
ignores it.
- The 8 removed exports are still used internally by `MYXProvider` via
relative import.
- `perpsConnectionAttemptContext` keeps its module-level state, just at
a new file path.
- `hasProperty(obj, key)` is runtime-equivalent to `key in obj` for
plain objects (both delegate to `Object.prototype.hasOwnProperty`
semantics via the prototype chain).

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable (existing tests untouched; new
location for moved test file is covered by the same suite)
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Medium risk because it changes perps controller module
boundaries/exports and touches trading/provider code paths (type-guard
refactors and a few scoped lint suppressions), plus alters sync script
behavior that can block releases if misconfigured.
> 
> **Overview**
> Improves extension-safe consumption of `@metamask/perps-controller` by
ensuring the optional `MYXProvider` stays excluded from webpack’s static
bundle and by removing MYX adapter re-exports from the public perps
barrels.
> 
> Aligns mobile’s perps linting with core by restricting the `in`
operator (and a couple of other syntaxes) and refactors multiple perps
files to use `hasProperty()` instead of `'key' in obj`, keeping a few
documented `in` usages behind targeted `no-restricted-syntax` disables
where TypeScript narrowing is required.
> 
> Moves/exports `perpsConnectionAttemptContext` under the perps utils
surface so in-package code imports remain sync-safe and out-of-package
callers use the package export, and hardens
`scripts/perps/validate-core-sync.sh` with an `origin/main` freshness
check plus a per-file/per-rule eslint suppression delta hard-fail
(including prettier formatting of `eslint-suppressions.json`).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1f90a9b. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: abretonc7s

.eslintrc.js

@@ -287,6 +287,22 @@ module.exports = {
             message:
               'Use ES private class fields (#field) instead of TypeScript private keyword.',
           },
+          // Mirror @metamask/eslint-config base rule — prevents `'x' in obj`
+          // type-guards that would land in core as new `no-restricted-syntax`
+          // suppressions. Use `hasProperty()` from `@metamask/utils` instead.
+          {
+            selector: "BinaryExpression[operator='in']",
+            message:
+              'The "in" operator is not allowed. Use `hasProperty()` from `@metamask/utils` instead.',
+          },
+          {
+            selector: 'WithStatement',
+            message: 'With statements are not allowed',
+          },
+          {
+            selector: 'SequenceExpression',
+            message: 'Sequence expressions are not allowed',
+          },
         ],
         'id-denylist': [
           'error',

app/components/UI/Perps/services/PerpsConnectionManager.ts

@@ -25,6 +25,7 @@ import {
   PERPS_ERROR_CODES,
   wait,
   TradingReadinessCache,
+  withPerpsConnectionAttemptContext,
   type ReconnectOptions,
 } from '@metamask/perps-controller';
 import { getStreamManagerInstance } from '../providers/PerpsStreamManager';
@@ -34,7 +35,6 @@ import {
 } from '../selectors/perpsController';
 import { selectHip3ConfigVersion } from '../selectors/featureFlags';
 import { ensureError } from '../../../../util/errorUtils';
-import { withPerpsConnectionAttemptContext } from '../../../../util/perpsConnectionAttemptContext';
 import { PERPS_CONNECTION_SOURCE } from '../constants/perpsConfig';
 
 interface ConnectOptions {

app/controllers/perps/PerpsController.ts

@@ -1694,7 +1694,9 @@ export class PerpsController extends BaseController<
       // IMPORTANT: Must use import() — NOT require() — for core/extension tree-shaking.
       // require() is synchronous and bundlers include it in the main bundle.
       // import() enables true code splitting so MYX is excluded when not enabled.
-      this.#myxRegistrationPromise = import('./providers/MYXProvider')
+      this.#myxRegistrationPromise = import(
+        /* webpackIgnore: true */ './providers/MYXProvider'
+      )
         .then(({ MYXProvider }) => {
           this.registerMYXProvider(MYXProvider);
           return undefined;

app/controllers/perps/index.ts

@@ -464,15 +464,10 @@ export {
 } from './utils';
 export type { HyperLiquidMarketData } from './utils';
 export {
-  adaptMarketFromMYX,
-  adaptPriceFromMYX,
-  adaptMarketDataFromMYX,
-  filterMYXExclusiveMarkets,
-  isOverlappingMarket,
-  buildPoolSymbolMap,
-  buildSymbolPoolsMap,
-  extractSymbolFromPoolId,
-} from './utils';
+  getPerpsConnectionAttemptContext,
+  withPerpsConnectionAttemptContext,
+} from './utils/perpsConnectionAttemptContext';
+export type { PerpsConnectionAttemptContext } from './utils/perpsConnectionAttemptContext';
 export {
   MAX_MARKET_PATTERN_LENGTH,
   escapeRegex,

app/controllers/perps/providers/HyperLiquidProvider.ts

@@ -1,4 +1,4 @@
-import { CaipAccountId } from '@metamask/utils';
+import { CaipAccountId, hasProperty } from '@metamask/utils';
 import type { Hex } from '@metamask/utils';
 import { v4 as uuidv4 } from 'uuid';
 
@@ -1968,14 +1968,19 @@ export class HyperLiquidProvider implements PerpsProvider {
 
       // Check order status
       const status = result.response?.data?.statuses?.[0];
-      if (isStatusObject(status) && 'error' in status) {
+      if (isStatusObject(status) && hasProperty(status, 'error')) {
         return { success: false, error: String(status.error) };
       }
 
+      // Note: `in` narrows the HyperLiquid SDK discriminated union to the
+      // branch that has `filled`; `hasProperty` only narrows the key and
+      // types `status.filled` as `unknown`, which loses access to `.totalSz`.
+      /* eslint-disable no-restricted-syntax */
       const filledSize =
         isStatusObject(status) && 'filled' in status
           ? parseFloat(status.filled?.totalSz ?? '0')
           : 0;
+      /* eslint-enable no-restricted-syntax */
 
       this.#deps.debugLogger.log(
         'HyperLiquidProvider: USDC→USDH swap completed',
@@ -3426,10 +3431,15 @@ export class HyperLiquidProvider implements PerpsProvider {
       }
 
       const status = result.response?.data?.statuses?.[0];
+      // Note: `in` narrows the HyperLiquid SDK discriminated union to the
+      // branch that has the property; `hasProperty` types the property as
+      // `unknown`, losing downstream access to `.oid`, `.totalSz`, `.avgPx`.
+      /* eslint-disable no-restricted-syntax */
       const restingOrder =
         isStatusObject(status) && 'resting' in status ? status.resting : null;
       const filledOrder =
         isStatusObject(status) && 'filled' in status ? status.filled : null;
+      /* eslint-enable no-restricted-syntax */
 
       // Success - auto-rebalance excess funds
       if (isHip3Order && transferInfo && dexName) {
@@ -4143,7 +4153,8 @@ export class HyperLiquidProvider implements PerpsProvider {
       const { statuses } = result.response.data;
       const successCount = statuses.filter(
         (stat) =>
-          isStatusObject(stat) && ('filled' in stat || 'resting' in stat),
+          isStatusObject(stat) &&
+          (hasProperty(stat, 'filled') || hasProperty(stat, 'resting')),
       ).length;
       const failureCount = statuses.length - successCount;
 
@@ -4153,7 +4164,7 @@ export class HyperLiquidProvider implements PerpsProvider {
           const status = statuses[i];
           const isSuccess =
             isStatusObject(status) &&
-            ('filled' in status || 'resting' in status);
+            (hasProperty(status, 'filled') || hasProperty(status, 'resting'));
 
           if (isSuccess && hip3Transfers[i]) {
             const { sourceDex, freedMargin } = hip3Transfers[i];
@@ -4179,9 +4190,9 @@ export class HyperLiquidProvider implements PerpsProvider {
           symbol: positionsToClose[index].symbol,
           success:
             isStatusObject(status) &&
-            ('filled' in status || 'resting' in status),
+            (hasProperty(status, 'filled') || hasProperty(status, 'resting')),
           error:
-            isStatusObject(status) && 'error' in status
+            isStatusObject(status) && hasProperty(status, 'error')
               ? String(status.error)
               : undefined,
         })),
@@ -5998,7 +6009,7 @@ export class HyperLiquidProvider implements PerpsProvider {
       // Extract HIP-3 DEX names (filter out null which is main DEX)
       const hip3DexNames: string[] = [];
       allDexs.forEach((dex) => {
-        if (dex !== null && 'name' in dex) {
+        if (dex !== null && hasProperty(dex, 'name')) {
           hip3DexNames.push(dex.name);
         }
       });

app/controllers/perps/services/HyperLiquidClientService.ts

@@ -7,7 +7,6 @@ import {
   WebSocketTransport,
 } from '@nktkas/hyperliquid';
 
-import { getPerpsConnectionAttemptContext } from '../../../util/perpsConnectionAttemptContext';
 import { CandlePeriod, calculateCandleCount } from '../constants/chartConfig';
 import { HYPERLIQUID_TRANSPORT_CONFIG } from '../constants/hyperLiquidConfig';
 import { PERPS_CONSTANTS } from '../constants/perpsConfig';
@@ -20,6 +19,7 @@ import type {
 import type { HyperLiquidNetwork } from '../types/config';
 import type { CandleData } from '../types/perps-types';
 import { ensureError } from '../utils/errorUtils';
+import { getPerpsConnectionAttemptContext } from '../utils/perpsConnectionAttemptContext';
 
 /**
  * Maximum number of reconnection attempts before giving up.

app/controllers/perps/services/HyperLiquidSubscriptionService.ts

@@ -1,4 +1,5 @@
 import type { CaipAccountId } from '@metamask/utils';
+import { hasProperty } from '@metamask/utils';
 import type {
   ISubscription,
   AllMidsWsEvent,
@@ -2583,9 +2584,9 @@ export class HyperLiquidSubscriptionService {
             const isPerpsContext = (
               event: ActiveAssetCtxWsEvent | ActiveSpotAssetCtxWsEvent,
             ): event is ActiveAssetCtxWsEvent =>
-              'funding' in event.ctx &&
-              'openInterest' in event.ctx &&
-              'oraclePx' in event.ctx;
+              hasProperty(event.ctx, 'funding') &&
+              hasProperty(event.ctx, 'openInterest') &&
+              hasProperty(event.ctx, 'oraclePx');
 
             const { ctx } = data;
 
@@ -2904,7 +2905,7 @@ export class HyperLiquidSubscriptionService {
         // Use cached meta to map ctxs array indices to symbols (no REST API call!)
         validatedMeta.universe.forEach((asset, index) => {
           const ctx = data.ctxs[index];
-          if (ctx && 'funding' in ctx) {
+          if (ctx && hasProperty(ctx, 'funding')) {
             // This is a perps context
             const ctxPrice = ctx.midPx ?? ctx.markPx;
             const openInterestUSD = calculateOpenInterestUSD(

app/controllers/perps/services/TradingService.ts

@@ -1516,7 +1516,6 @@ export class TradingService {
 
       this.#deps.debugLogger.log('[closePositions] Batch method check', {
         providerType: provider.protocolId,
-        hasBatchMethod: 'closePositions' in provider,
         providerKeys: Object.keys(provider).filter((key) =>
           key.includes('close'),
         ),

app/controllers/perps/types/index.ts

@@ -1,3 +1,4 @@
+import { hasProperty } from '@metamask/utils';
 import type {
   CaipAccountId,
   CaipChainId,
@@ -1643,8 +1644,8 @@ export function isVersionGatedFeatureFlag(
   return (
     typeof value === 'object' &&
     value !== null &&
-    'enabled' in value &&
-    'minimumVersion' in value &&
+    hasProperty(value, 'enabled') &&
+    hasProperty(value, 'minimumVersion') &&
     typeof (value as { enabled: unknown }).enabled === 'boolean' &&
     typeof (value as { minimumVersion: unknown }).minimumVersion === 'string'
   );

app/controllers/perps/types/transactionTypes.ts

@@ -2,6 +2,7 @@
  * Shared transaction types for Perps deposits and withdrawals
  * Provides a unified structure while maintaining separate use cases
  */
+import { hasProperty } from '@metamask/utils';
 
 /**
  * Base type with core properties shared between all transaction results
@@ -62,7 +63,7 @@ export type TransactionRecord = {
 export function isTransactionRecord(
   result: LastTransactionResult | TransactionRecord,
 ): result is TransactionRecord {
-  return 'id' in result && 'status' in result;
+  return hasProperty(result, 'id') && hasProperty(result, 'status');
 }
 
 /**
@@ -74,5 +75,5 @@ export function isTransactionRecord(
 export function isLastTransactionResult(
   result: LastTransactionResult | TransactionRecord,
 ): result is LastTransactionResult {
-  return !('id' in result) || !('status' in result);
+  return !hasProperty(result, 'id') || !hasProperty(result, 'status');
 }