Makefile

#! /bin/bash

# MACH1 SPATIAL SYSTEM MakeFile

.PHONY: help show-arch
help:
	@echo "MACH1 SPATIAL SYSTEM - Available Commands:"
	@echo ""
	@echo "Version Management:"
	@echo "  make update-version VERSION=<version>  - Update central version and regenerate all components"
	@echo "  make update-versions                   - Regenerate component versions from current base"
	@echo ""
	@echo "Development:"
	@echo "  make dev                              - Setup development environment for all components"
	@echo "  make clean                            - Clean all build directories"
	@echo "  make configure                        - Configure for release build"
	@echo "  make build                            - Build all components"
	@echo "  make build-vlc                        - Build VLC from source (for m1-player)"
	@echo ""
	@echo "Cross-compilation (macOS only - requires x86_64 Homebrew at /usr/local):"
	@echo "  make dev-player-x86                   - Configure m1-player for x86_64 (dev build)"
	@echo "  make configure-player-x86             - Configure m1-player for x86_64 (release build)"
	@echo "  make build-player-x86                 - Build m1-player for x86_64"
	@echo "  make show-arch                        - Show current build architecture info"
	@echo ""
	@echo "Packaging:"
	@echo "  make package                          - Full local build (configure, build, codesign, notarize, installer)"
	@echo "  make package-from-ci VERSION=x.x.x    - Download CI builds, sign AAX locally, create installer"
	@echo "  make package-from-ci COMMIT=abc123    - Same as above, but by commit SHA"
	@echo "  make list-ci-builds                   - List available CI builds in S3"
	@echo "  make installer-pkg                    - Build installer packages only"
	@echo ""
	@echo "CI/CD Testing (local simulation):"
	@echo "  make test-ci-build                    - Simulate full CI build locally"
	@echo "  make test-ci-build-player-only        - Test just m1-player build (fastest)"
	@echo "  make test-ci-yaml                     - Validate workflow YAML syntax"
	@echo "  make test-ci-act-arm                  - Run macOS ARM64 job with act"
	@echo "  make test-ci-act-arm DRYRUN=1         - Dry-run (show what would run)"
	@echo ""
	@echo "Code Signing:"
	@echo "  make codesign                         - Sign all binaries (macOS/Windows)"
	@echo "  make codesign-vst3                    - Sign VST3 plugins only"
	@echo "  make codesign-apps                    - Sign applications only"
	@echo "  make test-azure-signing               - Test Azure Trusted Signing setup (Windows)"
	@echo "  make verify-win-signing               - Verify all Windows signatures including installer"
	@echo ""
	@echo "For more details, see the Makefile or run individual commands with --help"

# Show current build architecture (useful for CI/CD and distribution)
show-arch:
ifeq ($(detected_OS),Darwin)
	@echo "=== Build Architecture Information ==="
	@echo "Host OS: macOS"
	@echo "Host Architecture: $$(uname -m)"
	@if [ "$$(uname -m)" = "arm64" ]; then \
		echo "Target: Apple Silicon (ARM64)"; \
		echo "Homebrew: /opt/homebrew"; \
		echo "Deployment Target: macOS 11.0+"; \
	else \
		echo "Target: Intel (x86_64)"; \
		echo "Homebrew: /usr/local"; \
		echo "Deployment Target: macOS 10.14+"; \
	fi
	@echo ""
	@echo "NOTE: m1-player builds for HOST architecture only."
	@echo "      For distribution, build on each target platform separately."
else ifeq ($(detected_OS),Windows)
	@echo "=== Build Architecture Information ==="
	@echo "Host OS: Windows"
	@if "%PROCESSOR_ARCHITECTURE%"=="AMD64" echo "Architecture: x86_64 (64-bit)"
	@if "%PROCESSOR_ARCHITECTURE%"=="x86" echo "Architecture: x86 (32-bit)"
else
	@echo "=== Build Architecture Information ==="
	@echo "Host OS: $(detected_OS)"
	@echo "Architecture: $$(uname -m)"
endif

# Auto-generate Makefile.variables from example if it doesn't exist
Makefile.variables:
	@if [ ! -f "Makefile.variables" ] && [ -f "Makefile.variables.example" ]; then \
		echo "Makefile.variables not found, creating from example..."; \
		cp Makefile.variables.example Makefile.variables; \
		echo "Created Makefile.variables from example"; \
		echo " Please review and update Makefile.variables with your actual values"; \
	elif [ ! -f "Makefile.variables.example" ]; then \
		echo " Neither Makefile.variables nor Makefile.variables.example found"; \
		exit 1; \
	fi

# Make sure you fill all the needed variables and paths
-include ./Makefile.variables

# getting OS type
ifeq ($(OS),Windows_NT)
	detected_OS := Windows
else
	detected_OS := $(shell uname)
endif

.PHONY: update-versions update-versions-internal
update-versions:
ifneq ($(detected_OS),Windows)
	@chmod +x ./installer/generate_version.sh
	@./installer/generate_version.sh --commit-version
endif

update-versions-internal:
ifneq ($(detected_OS),Windows)
	@chmod +x ./installer/generate_version.sh
	@./installer/generate_version.sh
endif

.PHONY: update-version
update-version:
ifneq ($(detected_OS),Windows)
	@if [ -z "$(VERSION)" ]; then \
		echo "Usage: make update-version VERSION=<new_version>"; \
		echo "Example: make update-version VERSION=2.1"; \
		echo "Current version: $$(cat VERSION)"; \
		echo ""; \
		echo "This command updates the central VERSION file and regenerates all component versions."; \
		exit 1; \
	fi
	@echo "Updating central version from $$(cat VERSION) to $(VERSION)"
	@echo "$(VERSION)" > VERSION
	@echo "Regenerating all component versions..."
	@chmod +x ./installer/generate_version.sh
	@./installer/generate_version.sh --commit-version
	@echo "Version update complete!"
	@echo "Current versions:"
	@echo "Central: $$(cat VERSION)"
	@echo "m1-panner: $$(cat m1-panner/VERSION)"
	@echo "m1-monitor: $$(cat m1-monitor/VERSION)"
	@echo "m1-player: $$(cat m1-player/VERSION)"
	@echo "m1-orientationmanager: $$(cat m1-orientationmanager/VERSION)"
	@echo "m1-system-helper: $$(cat services/m1-system-helper/VERSION)"
	@echo "m1-transcoder: $$(cat m1-transcoder/VERSION)"
	@echo ""
	@echo "Installer versions updated:"
	@echo "macOS: $$(grep -c "$(VERSION)" installer/osx/Mach1\ Spatial\ System\ Installer.pkgproj) packages"
	@echo "Windows: $$(grep AppVersion installer/win/installer.iss)"
else
	@echo "Version updates are not supported on Windows"
endif

.PHONY: test-aax-monitor test-aax-panner test-aax-plugins test-aax-release
.PHONY: verify-aax-signing diagnose-aax
.PHONY: test-ci-build test-ci-build-player-only test-ci-yaml
.PHONY: test-ci-act-arm
.PHONY: package-from-ci download-ci-artifacts install-arch-artifacts sign-aax-local installer-pkg-from-ci

pull:
	git pull --recurse-submodules

git-submodule-clean:
	git submodule foreach --recursive git clean -x -f -d
	make pull

git-nuke:
	@echo "WARNING: This will completely nuke and re-fetch ALL submodules!"
	@echo "This is intended for users who have old submodule histories after a rewrite."
	@echo "Press Ctrl+C now if you want to cancel..."
	@sleep 3
	@echo " Deinitializing all submodules..."
	git submodule deinit --all --force || true
	@echo "Removing .git/modules to clear cached submodule references..."
	rm -rf .git/modules
	@echo " Removing submodule directories..."
	git submodule foreach --recursive 'rm -rf "$$PWD"' || true
	@echo "Re-initializing and updating all submodules from scratch..."
	git submodule update --init --recursive --force
	@echo "All submodules have been nuked and re-fetched successfully!"
	@echo "TIP: You may want to run 'make clean' and 'make setup' after this."

setup:
ifeq ($(detected_OS),Darwin)
	# Assumes you have installed Homebrew package manager
	brew install yasm cmake p7zip ninja act pre-commit launchcontrol
	# VLC 3.x build dependencies (use FFmpeg 6.x for compatibility)
	brew install autoconf automake libtool pkg-config
	brew install ffmpeg@6 && brew link ffmpeg@6
	npm install -g nodemon
	cd m1-transcoder && ./scripts/setup.sh
	cd m1-panner && pre-commit install
	cd m1-monitor && pre-commit install
else ifeq ($(detected_OS),Windows)
	@choco version >nul || (echo "chocolately is not working or installed" && exit 1)
	@echo "choco is installed and working"
	@choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System' --apply-install-arguments-to-dependencies
	@choco install pkgconfiglite autoconf automake libtool
	@pip3 install meson
	@if not exist "$(pip show pre-commit)" (pip install pre-commit)
	npm install -g nodemon
	cd m1-panner && pre-commit install
	cd m1-monitor && pre-commit install
endif

setup-codeisgning:
ifeq ($(detected_OS),Darwin)
	security find-identity -p basic -v
	xcrun notarytool store-credentials 'notarize-app' --apple-id $(APPLE_USERNAME) --team-id $(APPLE_TEAM_CODE) --password $(ALTOOL_APPPASS)
endif

setup-services: clean-services
ifeq ($(detected_OS),Darwin)
	sudo mkdir -p /Library/Application\ Support/Mach1
	sudo cp m1-orientationmanager/Resources/settings.json /Library/Application\ Support/Mach1/settings.json
	sudo cp m1-orientationmanager/Resources/com.mach1.spatial.orientationmanager.plist /Library/LaunchAgents/com.mach1.spatial.orientationmanager.plist
	sudo cp services/m1-system-helper/com.mach1.spatial.helper.plist /Library/LaunchAgents/com.mach1.spatial.helper.plist
endif

clean-services:
ifeq ($(detected_OS),Darwin)
	sudo rm -f /Library/Application\ Support/Mach1/settings.json
	sudo rm -f /Library/LaunchAgents/com.mach1.spatial.orientationmanager.plist
	sudo rm -f /Library/LaunchAgents/com.mach1.spatial.helper.plist
	killall m1-system-helper || true
	killall m1-orientationmanager || true
endif

clean:
ifeq ($(detected_OS),Darwin)
	rm -rf installer/osx/build
endif
ifeq ($(detected_OS),Windows)
	@if exist m1-monitor\\build (rmdir /s /q m1-monitor\\build)
	@if exist m1-panner\\build (rmdir /s /q m1-panner\\build)
	@if exist m1-player\\build (rmdir /s /q m1-player\\build)
	@if exist m1-transcoder\\dist (rmdir /s /q m1-transcoder\\dist)
	@if exist m1-orientationmanager\\build (rmdir /s /q m1-orientationmanager\\build)
	@if exist services\\m1-system-helper\\build (rmdir /s /q services\\m1-system-helper\\build)
else
	rm -rf m1-monitor/build
	rm -rf m1-panner/build
	rm -rf m1-player/build
	rm -rf m1-transcoder/dist
	rm -rf m1-orientationmanager/build
	rm -rf services/m1-system-helper/build
endif

clean-dev:
ifeq ($(detected_OS),Darwin)
	rm -rf installer/osx/build
endif
ifeq ($(detected_OS),Windows)
	@if exist m1-monitor\\build-dev (rmdir /s /q m1-monitor\\build-dev)
	@if exist m1-panner\\build-dev (rmdir /s /q m1-panner\\build-dev)
	@if exist m1-player\\build-dev (rmdir /s /q m1-player\\build-dev)
	@if exist m1-transcoder\\dist (rmdir /s /q m1-transcoder\\dist)
	@if exist m1-orientationmanager\\build-dev (rmdir /s /q m1-orientationmanager\\build-dev)
	@if exist services\\m1-system-helper\\build-dev (rmdir /s /q services\\m1-system-helper\\build-dev)
else
	rm -rf m1-monitor/build-dev
	rm -rf m1-panner/build-dev
	rm -rf m1-player/build-dev
	rm -rf m1-transcoder/dist
	rm -rf m1-orientationmanager/build-dev
	rm -rf services/m1-system-helper/build-dev
endif

clean-installs:
ifeq ($(detected_OS),Darwin)
	sudo rm -rf /Applications/Mach1\ Spatial\ System
	sudo rm -rf /Applications/Mach1
	sudo rm -rf /Library/LaunchAgents/com.mach1.spatial.orientationmanager.plist
	sudo rm -rf /Library/LaunchAgents/com.mach1.spatial.helper.plist
	sudo rm -rf /Library/Application\ Support/Mach1
	# removing global
	sudo rm -rf "/Library/Application Support/Avid/Audio/Plug-Ins/M1-Monitor.aaxplugin"
	sudo rm -rf "/Library/Application Support/Avid/Audio/Plug-Ins/M1-Panner.aaxplugin"
	sudo rm -rf "/Library/Audio/Plug-Ins/VST/M1-Monitor.vst"
	sudo rm -rf "/Library/Audio/Plug-Ins/VST/M1-Panner.vst"
	sudo rm -rf "/Library/Audio/Plug-Ins/VST3/M1-Monitor.vst3"
	sudo rm -rf "/Library/Audio/Plug-Ins/VST3/M1-Panner.vst3"
	sudo rm -rf "/Library/Audio/Plug-Ins/Components/M1-Monitor.component"
	sudo rm -rf "/Library/Audio/Plug-Ins/Components/M1-Panner.component"
	# removing local user
	rm -rf ~/Library/Application\ Support/Avid/Audio/Plug-Ins/M1-Monitor.aaxplugin
	rm -rf ~/Library/Application\ Support/Avid/Audio/Plug-Ins/M1-Panner.aaxplugin
	rm -rf ~/Library/Audio/Plug-Ins/VST/M1-Monitor.vst
	rm -rf ~/Library/Audio/Plug-Ins/VST/M1-Panner.vst
	rm -rf ~/Library/Audio/Plug-Ins/VST3/M1-Monitor.vst3
	rm -rf ~/Library/Audio/Plug-Ins/VST3/M1-Panner.vst3
	rm -rf ~/Library/Audio/Plug-Ins/Components/M1-Monitor.component
	rm -rf ~/Library/Audio/Plug-Ins/Components/M1-Panner.component
else ifeq ($(detected_OS),Windows)
	@echo "WARNING: You must run this command as Administrator to remove system files!"
	@takeown /f "$(ProgramFiles)\Mach1" /r /d y >nul 2>&1
	@icacls "$(ProgramFiles)\Mach1" /grant %USERNAME%:F /t >nul 2>&1
	@if exist "$(ProgramFiles)\Mach1" (rmdir /s /q "$(ProgramFiles)\Mach1")
	@takeown /f "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Monitor.aaxplugin" /r /d y >nul 2>&1
	@icacls "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Monitor.aaxplugin" /grant %USERNAME%:F /t >nul 2>&1
	@if exist "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Monitor.aaxplugin" (rmdir /s /q "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Monitor.aaxplugin")
	@takeown /f "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Panner.aaxplugin" /r /d y >nul 2>&1
	@icacls "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Panner.aaxplugin" /grant %USERNAME%:F /t >nul 2>&1
	@if exist "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Panner.aaxplugin" (rmdir /s /q "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-Panner.aaxplugin")
	@takeown /f "$(ProgramFiles)\Steinberg\VstPlugins\M1-Monitor.dll" /d y >nul 2>&1
	@icacls "$(ProgramFiles)\Steinberg\VstPlugins\M1-Monitor.dll" /grant %USERNAME%:F >nul 2>&1
	@if exist "$(ProgramFiles)\Steinberg\VstPlugins\M1-Monitor.dll" (del /f /q "$(ProgramFiles)\Steinberg\VstPlugins\M1-Monitor.dll")
	@takeown /f "$(ProgramFiles)\Steinberg\VstPlugins\M1-Panner.dll" /d y >nul 2>&1
	@icacls "$(ProgramFiles)\Steinberg\VstPlugins\M1-Panner.dll" /grant %USERNAME%:F >nul 2>&1
	@if exist "$(ProgramFiles)\Steinberg\VstPlugins\M1-Panner.dll" (del /f /q "$(ProgramFiles)\Steinberg\VstPlugins\M1-Panner.dll")
	@takeown /f "$(ProgramFiles)\Common Files\VST3\M1-Monitor.vst3" /r /d y >nul 2>&1
	@icacls "$(ProgramFiles)\Common Files\VST3\M1-Monitor.vst3" /grant %USERNAME%:F /t >nul 2>&1
	@if exist "$(ProgramFiles)\Common Files\VST3\M1-Monitor.vst3" (rmdir /s /q "$(ProgramFiles)\Common Files\VST3\M1-Monitor.vst3")
	@takeown /f "$(ProgramFiles)\Common Files\VST3\M1-Panner.vst3" /r /d y >nul 2>&1
	@icacls "$(ProgramFiles)\Common Files\VST3\M1-Panner.vst3" /grant %USERNAME%:F /t >nul 2>&1
	@if exist "$(ProgramFiles)\Common Files\VST3\M1-Panner.vst3" (rmdir /s /q "$(ProgramFiles)\Common Files\VST3\M1-Panner.vst3")
	@takeown /f "$(ProgramData)\Mach1" /r /d y >nul 2>&1
	@icacls "$(ProgramData)\Mach1" /grant %USERNAME%:F /t >nul 2>&1
	@if exist "$(ProgramData)\Mach1" (rmdir /s /q "$(ProgramData)\Mach1")
endif

# Add these helper functions at the top of the Makefile
define kill_port
	@lsof -ti:$(1) | xargs kill -9 2>/dev/null || true
endef

# Force target to always run
FORCE:

clean-docs-ports:
ifeq ($(detected_OS),Darwin)
	@lsof -ti:$(docs_port) | xargs kill -9 2>/dev/null || true
else ifeq ($(detected_OS),Windows)
	@for /f "tokens=5" %%a in ('netstat -aon ^| findstr :$(docs_port)') do taskkill /PID %%a /F 2>nul || exit 0
else
	@lsof -ti:$(docs_port) | xargs kill -9 2>/dev/null || true
endif

clean-docs-dist:
ifeq ($(detected_OS),Windows)
	@if exist installer\resources\docs\dist (rmdir /s /q installer\resources\docs\dist)
else
	@echo "Cleaning documentation dist folder..."
	rm -rf installer/resources/docs/dist
endif

# Documentation deployment commands
docs-build: clean-docs-dist FORCE
	@echo "Building documentation..."
ifeq ($(detected_OS),Windows)
	cd installer\resources\docs && node build-docs.js
else
	cd installer/resources/docs && node build-docs.js
endif

docs-deploy: docs-build
	@echo "Deploying documentation to spatialsystem.mach1.tech..."
	aws s3 sync installer/resources/docs/dist/ s3://$(docs_s3_bucket_name)/ \
		--cache-control "public, max-age=3600"
	@echo "Invalidating CloudFront cache..."
	@aws cloudfront create-invalidation \
		--distribution-id $(docs_cloudfront_id) \
		--paths "/*" \
		--output json \
		--query 'Invalidation.{Status:Status,CreateTime:CreateTime,Id:Id}' || (echo "CloudFront invalidation failed" && exit 1)
	@echo "Documentation deployed to spatialsystem.mach1.tech"

docs-stage: docs-build
	@echo "Deploying documentation to staging..."
	aws s3 sync installer/resources/docs/dist/ s3://$(docs_s3_stage_bucket_name)/ \
		--cache-control "no-cache"
	@echo "Invalidating CloudFront cache..."
	@aws cloudfront create-invalidation \
		--distribution-id $(docs_stage_cloudfront_id) \
		--paths "/*" \
		--output json \
		--query 'Invalidation.{Status:Status,CreateTime:CreateTime,Id:Id}' || (echo "CloudFront invalidation failed" && exit 1)
	@echo "Documentation deployed to staging.spatialsystem.mach1.tech"

docs-local: clean-docs-ports docs-build
	@echo "Starting local documentation server..."
	cd installer/resources/docs/dist && python3 -m http.server $(docs_port)
	@echo "Documentation available at http://localhost:$(docs_port)"

docs-verify:
	@echo "🔍 Verifying documentation deployment..."
	@echo "Testing CloudFront direct URL..."
	@curl -I -s https://$(shell aws cloudfront get-distribution --id $(docs_cloudfront_id) --query 'Distribution.DomainName' --output text) | head -1
	@echo "Testing custom domain URL..."
	@curl -I -s https://spatialsystem.mach1.tech | head -1 || echo "Custom domain not accessible"
	@echo "DNS lookup for spatialsystem.mach1.tech:"
	@dig spatialsystem.mach1.tech CNAME +short || nslookup spatialsystem.mach1.tech

# configure for debug and setup dev envs with common IDEs
dev: clean-dev dev-monitor dev-panner dev-player dev-orientationmanager dev-system-helper dev-transcoder

dev-monitor:
ifeq ($(detected_OS),Darwin)
	cmake m1-monitor -Bm1-monitor/build-dev -G "Xcode" -DJUCE_COPY_PLUGIN_AFTER_BUILD=ON -DBUILD_VST3=ON -DBUILD_AAX=ON -DBUILD_AU=ON -DBUILD_VST=ON -DVST2_PATH=$(VST2_PATH) -DBUILD_STANDALONE=ON
else
	cmake m1-monitor -Bm1-monitor/build-dev -DJUCE_COPY_PLUGIN_AFTER_BUILD=ON -DBUILD_VST3=ON -DBUILD_STANDALONE=ON
endif

dev-panner:
ifeq ($(detected_OS),Darwin)
	cmake m1-panner -Bm1-panner/build-dev -G "Xcode" -DJUCE_COPY_PLUGIN_AFTER_BUILD=ON -DBUILD_VST3=ON -DBUILD_AAX=ON -DBUILD_AU=ON -DBUILD_VST=ON -DVST2_PATH=$(VST2_PATH) -DBUILD_STANDALONE=ON
else
	cmake m1-panner -Bm1-panner/build-dev -DJUCE_COPY_PLUGIN_AFTER_BUILD=ON -DBUILD_VST3=ON -DBUILD_AAX=ON -DBUILD_STANDALONE=ON
endif

dev-player:
ifeq ($(detected_OS),Darwin)
	@echo "Configuring m1-player (dev)..."
	cmake m1-player -Bm1-player/build-dev -G "Xcode" -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF || true
	@if [ ! -f "m1-player/build-dev/vlc-install/lib/libvlc.dylib" ]; then \
		echo ""; \
		echo "VLC libraries not found. Building VLC from source..."; \
		echo ""; \
		cd m1-player && ./build_vlc.sh build-dev && \
		echo "" && \
		echo "VLC build complete! Reconfiguring CMake..." && \
		echo "" && \
		cd .. && cmake m1-player -Bm1-player/build-dev -G "Xcode" -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF; \
	fi
else ifeq ($(detected_OS),Windows)
	@echo "Configuring m1-player (dev)..."
	-cmake m1-player -Bm1-player/build-dev -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF
	@if not exist "m1-player\build-dev\vlc-install\lib\libvlc.lib" ( \
		echo. & \
		echo VLC libraries not found. Run build_vlc.ps1 to download VLC SDK... & \
		echo. & \
		powershell -ExecutionPolicy Bypass -File m1-player\build_vlc.ps1 -BuildDir build-dev & \
		echo. & \
		echo VLC setup complete! Reconfiguring CMake... & \
		echo. & \
		cmake m1-player -Bm1-player/build-dev -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF \
	)
else
	@echo "Configuring m1-player (dev)..."
	cmake m1-player -Bm1-player/build-dev -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF || true
	@if [ ! -f "m1-player/build-dev/vlc-install/lib/libvlc.lib" ] && [ ! -f "m1-player/build-dev/vlc-install/lib/libvlc.dll.a" ]; then \
		echo ""; \
		echo "VLC libraries not found. Building VLC from source..."; \
		echo "This will take 20-40 minutes..."; \
		echo ""; \
		cd m1-player && ./build_vlc.sh build-dev && \
		echo "" && \
		echo "VLC build complete! Reconfiguring CMake..." && \
		echo "" && \
		cd .. && cmake m1-player -Bm1-player/build-dev -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF; \
	fi
endif

# Cross-compile m1-player for x86_64 on Apple Silicon (via Rosetta 2)
# Requires x86_64 Homebrew installed at /usr/local with all VLC dependencies
dev-player-x86:
ifeq ($(detected_OS),Darwin)
	@echo "Configuring m1-player for x86_64 (cross-compilation via Rosetta)..."
	@if [ ! -d "/usr/local/bin" ]; then \
		echo "ERROR: x86_64 Homebrew not found at /usr/local"; \
		echo "Install it with:"; \
		echo "  arch -x86_64 /bin/bash -c \"\$$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)\""; \
		exit 1; \
	fi
	arch -x86_64 cmake m1-player -Bm1-player/build-dev-x86 -G "Xcode" \
		-DCMAKE_OSX_ARCHITECTURES=x86_64 \
		-DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF || true
	@if [ ! -f "m1-player/build-dev-x86/vlc-install/lib/libvlc.dylib" ]; then \
		echo ""; \
		echo "VLC libraries not found. Building VLC for x86_64..."; \
		echo ""; \
		cd m1-player && arch -x86_64 ./build_vlc.sh build-dev-x86 && \
		echo "" && \
		echo "VLC build complete! Reconfiguring CMake..." && \
		echo "" && \
		cd .. && arch -x86_64 cmake m1-player -Bm1-player/build-dev-x86 -G "Xcode" \
			-DCMAKE_OSX_ARCHITECTURES=x86_64 \
			-DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF; \
	fi
else
	@echo "ERROR: dev-player-x86 is only available on macOS"
	@exit 1
endif

dev-orientationmanager:
ifeq ($(detected_OS),Darwin)
	cmake m1-orientationmanager -Bm1-orientationmanager/build-dev -G "Xcode" -DENABLE_DEBUG_EMULATOR_DEVICE=ON -DCMAKE_INSTALL_PREFIX="/Library/Application Support/Mach1"
	sudo mkdir -p /Library/Application\ Support/Mach1
	sudo cp m1-orientationmanager/Resources/settings.json /Library/Application\ Support/Mach1/settings.json
else ifeq ($(detected_OS),Windows)
	cmake m1-orientationmanager -Bm1-orientationmanager/build-dev -DENABLE_DEBUG_EMULATOR_DEVICE=ON -DCMAKE_INSTALL_PREFIX="\Documents and Settings\All Users\Application Data\Mach1"
else
	cmake m1-orientationmanager -Bm1-orientationmanager/build-dev -DENABLE_DEBUG_EMULATOR_DEVICE=ON -DCMAKE_INSTALL_PREFIX="/opt/Mach1"
endif

dev-oscclient:
ifeq ($(detected_OS),Darwin)
	cmake m1-orientationmanager/osc_client -Bm1-orientationmanager/osc_client/build-dev -G "Xcode"
else
	cmake m1-orientationmanager/osc_client -Bm1-orientationmanager/osc_client/build-dev
endif

dev-system-helper:
ifeq ($(detected_OS),Darwin)
	cmake services/m1-system-helper -Bservices/m1-system-helper/build-dev -G "Xcode" -DCMAKE_INSTALL_PREFIX="/Library/Application Support/Mach1"
	sudo mkdir -p /Library/Application\ Support/Mach1
	sudo cp m1-orientationmanager/Resources/settings.json /Library/Application\ Support/Mach1/settings.json
else ifeq ($(detected_OS),Windows)
	cmake services/m1-system-helper -Bservices/m1-system-helper/build-dev -DCMAKE_INSTALL_PREFIX="\Documents and Settings\All Users\Application Data\Mach1"
else
	cmake services/m1-system-helper -Bservices/m1-system-helper/build-dev -DCMAKE_INSTALL_PREFIX="/opt/Mach1"
endif

dev-transcoder:
ifeq ($(detected_OS),Windows)
	cd m1-transcoder && scripts\setup.sh && npm install
else 
	cd m1-transcoder && ./scripts/setup.sh && npm install
endif

dev-transcoder-plugin:
ifeq ($(detected_OS),Darwin)
	cmake m1-transcoder/juce_plugin -Bm1-transcoder/juce_plugin/build-dev -G "Xcode" -DJUCE_COPY_PLUGIN_AFTER_BUILD=ON -DBUILD_VST3=ON -DBUILD_AAX=ON -DBUILD_AU=ON -DBUILD_VST=ON -DVST2_PATH=$(VST2_PATH) -DBUILD_STANDALONE=ON
else
	cmake m1-transcoder/juce_plugin -Bm1-transcoder/juce_plugin/build-dev -DJUCE_COPY_PLUGIN_AFTER_BUILD=ON -DBUILD_VST3=ON -DBUILD_AAX=ON -DBUILD_STANDALONE=ON
endif

overlay-debug:
	cd m1-panner/Resources/overlay_debug && ./run_simulator.sh --title "Avid Video Engine"

# =============================================================================
# Release Packaging
# =============================================================================
# Full local build: configure → build → sign → notarize → installer
package: update-versions-internal build docs-build codesign notarize installer-pkg

# =============================================================================
# Hybrid CI/CD Release (Recommended)
# =============================================================================
# Downloads pre-built artifacts from CI/CD, then signs AAX locally and creates installer.
# This is the recommended workflow since AAX signing requires a physical USB iLok dongle.
#
# Usage:
#   make package-from-ci VERSION=2.1           # By version tag
#   make package-from-ci COMMIT=abc12345       # By commit SHA
#
# Prerequisites:
#   - AWS CLI configured with access to mach1-build-artifacts bucket
#   - USB iLok dongle connected for AAX signing
#   - Apple Developer certificate in keychain for macOS
#
ARTIFACTS_BUCKET ?= mach1-build-artifacts
CI_ARTIFACTS_DIR ?= ci-artifacts

# Release artifact path resolution
# CI packaging preserves the native contents of each *_artefacts directory, while
# local builds may emit app/binary payloads at slightly different depths depending
# on generator and target type. Resolve the paths once so signing/notarization and
# package-from-ci can use the same locations.
MAC_PLAYER_APP_PATH := $(or $(firstword $(wildcard m1-player/build/M1-Player_artefacts/Release/M1-Player.app)),m1-player/build/M1-Player_artefacts/Release/M1-Player.app)
MAC_PLAYER_APP_DIR := $(patsubst %/,%,$(dir $(MAC_PLAYER_APP_PATH)))
MAC_ORIENTATION_BIN_PATH := $(or $(firstword $(wildcard m1-orientationmanager/build/m1-orientationmanager_artefacts/m1-orientationmanager)),m1-orientationmanager/build/m1-orientationmanager_artefacts/Release/m1-orientationmanager)
MAC_HELPER_APP_PATH := $(or $(firstword $(wildcard services/m1-system-helper/build/m1-system-helper_artefacts/m1-system-helper.app)),services/m1-system-helper/build/m1-system-helper_artefacts/Release/m1-system-helper.app)
MAC_MONITOR_ENTITLEMENTS := m1-monitor/Resources/entitlements.mac.plist
MAC_PANNER_ENTITLEMENTS := m1-panner/Resources/entitlements.mac.plist
WIN_PLAYER_EXE_PATH := $(or $(firstword $(wildcard m1-player/build/M1-Player_artefacts/Release/M1-Player.exe)),m1-player/build/M1-Player_artefacts/M1-Player.exe)
WIN_ORIENTATION_EXE_PATH := $(or $(firstword $(wildcard m1-orientationmanager/build/m1-orientationmanager_artefacts/Release/m1-orientationmanager.exe)),m1-orientationmanager/build/m1-orientationmanager_artefacts/m1-orientationmanager.exe)
WIN_HELPER_EXE_PATH := $(or $(firstword $(wildcard services/m1-system-helper/build/m1-system-helper_artefacts/Release/m1-system-helper.exe)),services/m1-system-helper/build/m1-system-helper_artefacts/m1-system-helper.exe)

package-from-ci: download-ci-artifacts sign-aax-local installer-pkg-from-ci
	@echo ""
	@echo "========================================"
	@echo "Release Complete!"
	@echo "========================================"
ifeq ($(detected_OS),Darwin)
	@echo ""
	@echo "macOS installers ready:"
	@ls -la installer/osx/build/signed/*.pkg
endif
	@echo ""

download-ci-artifacts: clean-ci-artifacts
	@echo "========================================"
	@echo "Downloading CI Build Artifacts"
	@echo "========================================"
ifeq ($(detected_OS),Darwin)
	@if [ -z "$(VERSION)" ] && [ -z "$(COMMIT)" ]; then \
		echo "ERROR: Specify VERSION or COMMIT"; \
		echo "  make package-from-ci VERSION=2.1"; \
		echo "  make package-from-ci COMMIT=abc12345"; \
		exit 1; \
	fi
	@mkdir -p $(CI_ARTIFACTS_DIR)
	@# Download BOTH macOS architectures
	@if [ -n "$(VERSION)" ]; then \
		echo "Downloading version $(VERSION) artifacts (both architectures)..."; \
		echo ""; \
		echo "Downloading ARM64 (Apple Silicon) builds..."; \
		aws s3 cp "s3://$(ARTIFACTS_BUCKET)/builds/$(VERSION)/macos-arm64-builds.tar.gz" \
			"$(CI_ARTIFACTS_DIR)/macos-arm64-builds.tar.gz" --region us-east-1 || \
			(echo "ERROR: ARM64 artifacts not found for version $(VERSION)" && exit 1); \
		echo ""; \
		echo "Downloading x86_64 (Intel) builds..."; \
		aws s3 cp "s3://$(ARTIFACTS_BUCKET)/builds/$(VERSION)/macos-x86-builds.tar.gz" \
			"$(CI_ARTIFACTS_DIR)/macos-x86-builds.tar.gz" --region us-east-1 || \
			(echo "ERROR: x86_64 artifacts not found for version $(VERSION)" && exit 1); \
	elif [ -n "$(COMMIT)" ]; then \
		echo "Downloading commit $(COMMIT) artifacts (both architectures)..."; \
		echo ""; \
		echo "Downloading ARM64 (Apple Silicon) builds..."; \
		aws s3 cp "s3://$(ARTIFACTS_BUCKET)/commits/$(COMMIT)/macos-arm64-builds.tar.gz" \
			"$(CI_ARTIFACTS_DIR)/macos-arm64-builds.tar.gz" --region us-east-1 || \
			(echo "ERROR: ARM64 artifacts not found for commit $(COMMIT)" && exit 1); \
		echo ""; \
		echo "Downloading x86_64 (Intel) builds..."; \
		aws s3 cp "s3://$(ARTIFACTS_BUCKET)/commits/$(COMMIT)/macos-x86-builds.tar.gz" \
			"$(CI_ARTIFACTS_DIR)/macos-x86-builds.tar.gz" --region us-east-1 || \
			(echo "ERROR: x86_64 artifacts not found for commit $(COMMIT)" && exit 1); \
	fi
	@echo ""
	@echo "Extracting artifacts..."
	@cd $(CI_ARTIFACTS_DIR) && tar -xzf macos-arm64-builds.tar.gz
	@cd $(CI_ARTIFACTS_DIR) && tar -xzf macos-x86-builds.tar.gz
	@echo ""
	@echo "Both architectures downloaded:"
	@echo "  - $(CI_ARTIFACTS_DIR)/macos-arm64/"
	@echo "  - $(CI_ARTIFACTS_DIR)/macos-x86/"
else ifeq ($(detected_OS),Windows)
	@echo "Downloading Windows artifacts..."
	@if not defined VERSION if not defined COMMIT ( \
		echo ERROR: Specify VERSION or COMMIT && \
		echo   make package-from-ci VERSION=2.1 && \
		echo   make package-from-ci COMMIT=abc12345 && \
		exit 1 \
	)
	@if not exist $(CI_ARTIFACTS_DIR) mkdir $(CI_ARTIFACTS_DIR)
	@if defined VERSION ( \
		aws s3 cp "s3://$(ARTIFACTS_BUCKET)/builds/$(VERSION)/windows-builds.zip" \
			"$(CI_ARTIFACTS_DIR)\windows-builds.zip" --region us-east-1 \
	) else ( \
		aws s3 cp "s3://$(ARTIFACTS_BUCKET)/commits/$(COMMIT)/windows-builds.zip" \
			"$(CI_ARTIFACTS_DIR)\windows-builds.zip" --region us-east-1 \
	)
	@7z x -y "$(CI_ARTIFACTS_DIR)\windows-builds.zip" -o"$(CI_ARTIFACTS_DIR)"
	@echo Artifacts downloaded and extracted
endif

# Helper to install artifacts for a specific architecture
# Usage: make install-arch-artifacts ARCH=arm64
# Note: CI packages artifacts without the _artefacts suffix, but installer expects it
install-arch-artifacts:
ifeq ($(detected_OS),Darwin)
	@if [ -z "$(ARCH)" ]; then \
		echo "ERROR: Specify ARCH (arm64 or x86)"; \
		exit 1; \
	fi
	@if [ "$(ARCH)" = "arm64" ]; then \
		ARCH_DIR="macos-arm64"; \
	else \
		ARCH_DIR="macos-x86"; \
	fi; \
	echo "Installing $$ARCH_DIR artifacts to build directories..."; \
	rm -rf m1-monitor/build m1-panner/build m1-player/build; \
	rm -rf m1-orientationmanager/build services/m1-system-helper/build; \
	mkdir -p m1-monitor/build/M1-Monitor_artefacts; \
	mkdir -p m1-panner/build/M1-Panner_artefacts; \
	mkdir -p m1-player/build/M1-Player_artefacts; \
	mkdir -p m1-orientationmanager/build/m1-orientationmanager_artefacts; \
	mkdir -p services/m1-system-helper/build/m1-system-helper_artefacts; \
	if [ -d "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/M1-Monitor" ]; then \
		ditto "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/M1-Monitor" "m1-monitor/build/M1-Monitor_artefacts"; \
	fi; \
	if [ -d "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/M1-Panner" ]; then \
		ditto "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/M1-Panner" "m1-panner/build/M1-Panner_artefacts"; \
	fi; \
	if [ -d "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/M1-Player" ]; then \
		ditto "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/M1-Player" "m1-player/build/M1-Player_artefacts"; \
	fi; \
	if [ -d "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/m1-orientationmanager" ]; then \
		ditto "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/m1-orientationmanager" "m1-orientationmanager/build/m1-orientationmanager_artefacts"; \
	fi; \
	if [ -d "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/m1-system-helper" ]; then \
		ditto "$(CI_ARTIFACTS_DIR)/$$ARCH_DIR/m1-system-helper" "services/m1-system-helper/build/m1-system-helper_artefacts"; \
	fi; \
	if [ -d "$(MAC_PLAYER_APP_PATH)" ]; then \
		codesign --verify --deep --strict --verbose=2 "$(MAC_PLAYER_APP_PATH)"; \
	fi; \
	echo "Artifacts installed for $$ARCH_DIR"
endif

sign-aax-local:
	@echo ""
	@echo "========================================"
	@echo "Signing AAX Plugins (USB iLok Required)"
	@echo "========================================"
ifeq ($(detected_OS),Darwin)
	@echo "Ensure your USB iLok dongle is connected..."
	@echo ""
	@if [ -d "m1-monitor/build/M1-Monitor_artefacts/AAX" ] || [ -d "m1-monitor/build/AAX" ]; then \
		echo "Signing M1-Monitor AAX..."; \
		AAX_PATH=$$(find m1-monitor/build -name "M1-Monitor.aaxplugin" -type d | head -1); \
		if [ -n "$$AAX_PATH" ]; then \
			codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_MONITOR_ENTITLEMENTS) --timestamp "$$AAX_PATH"; \
			$(WRAPTOOL) sign --verbose --account $(PACE_ACCOUNT) --wcguid "$(MONITOR_FREE_GUID)" \
				--signid $(APPLE_CODESIGN_ID) --in "$$AAX_PATH" --out "$$AAX_PATH" --autoinstall on; \
			echo "M1-Monitor AAX signed"; \
		else \
			echo "M1-Monitor.aaxplugin not found"; \
		fi; \
	fi
	@if [ -d "m1-panner/build/M1-Panner_artefacts/AAX" ] || [ -d "m1-panner/build/AAX" ]; then \
		echo "Signing M1-Panner AAX..."; \
		AAX_PATH=$$(find m1-panner/build -name "M1-Panner.aaxplugin" -type d | head -1); \
		if [ -n "$$AAX_PATH" ]; then \
			codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_PANNER_ENTITLEMENTS) --timestamp "$$AAX_PATH"; \
			$(WRAPTOOL) sign --verbose --account $(PACE_ACCOUNT) --wcguid "$(PANNER_FREE_GUID)" \
				--signid $(APPLE_CODESIGN_ID) --in "$$AAX_PATH" --out "$$AAX_PATH" --autoinstall on; \
			echo "M1-Panner AAX signed"; \
		else \
			echo "M1-Panner.aaxplugin not found"; \
		fi; \
	fi
	@echo ""
	@echo "AAX signing complete!"
else ifeq ($(detected_OS),Windows)
	@echo "Signing AAX plugins on Windows..."
	@echo "Ensure iLok License Manager is running..."
	@if exist "m1-monitor\build\M1-Monitor_artefacts\Release\AAX\M1-Monitor.aaxplugin" ( \
		set SIGNTOOL_PATH=$(WIN_SIGNTOOL_PATH) && \
		set ACS_DLIB=$(AZURE_DLIB_PATH) && \
		set ACS_JSON=$(AZURE_METADATA_PATH) && \
		set AZURE_TENANT_ID=$(AZURE_TENANT_ID) && \
		set AZURE_CLIENT_ID=$(AZURE_CLIENT_ID) && \
		set AZURE_SECRET_ID=$(AZURE_CLIENT_SECRET) && \
		$(WRAPTOOL) sign --signtool "$(CURDIR)/installer/win/aax-signtool.bat" --signid 1 --verbose \
			--installedbinaries --account $(PACE_ACCOUNT) --wcguid "$(MONITOR_FREE_GUID)" \
			--in m1-monitor\build\M1-Monitor_artefacts\Release\AAX\M1-Monitor.aaxplugin \
			--out m1-monitor\build\M1-Monitor_artefacts\Release\AAX\M1-Monitor.aaxplugin \
	)
	@if exist "m1-panner\build\M1-Panner_artefacts\Release\AAX\M1-Panner.aaxplugin" ( \
		set SIGNTOOL_PATH=$(WIN_SIGNTOOL_PATH) && \
		set ACS_DLIB=$(AZURE_DLIB_PATH) && \
		set ACS_JSON=$(AZURE_METADATA_PATH) && \
		set AZURE_TENANT_ID=$(AZURE_TENANT_ID) && \
		set AZURE_CLIENT_ID=$(AZURE_CLIENT_ID) && \
		set AZURE_SECRET_ID=$(AZURE_CLIENT_SECRET) && \
		$(WRAPTOOL) sign --signtool "$(CURDIR)/installer/win/aax-signtool.bat" --signid 1 --verbose \
			--installedbinaries --account $(PACE_ACCOUNT) --wcguid "$(PANNER_FREE_GUID)" \
			--in m1-panner\build\M1-Panner_artefacts\Release\AAX\M1-Panner.aaxplugin \
			--out m1-panner\build\M1-Panner_artefacts\Release\AAX\M1-Panner.aaxplugin \
	)
endif

installer-pkg-from-ci: sign-aax-local
	@echo ""
	@echo "========================================"
	@echo "Creating Installer Packages"
	@echo "========================================"
ifeq ($(detected_OS),Darwin)
	@echo "Building installers for BOTH macOS architectures..."
	@echo ""
	@# === ARM64 (Apple Silicon) ===
	@echo "========================================"
	@echo "Building ARM64 (Apple Silicon) Installer"
	@echo "========================================"
	@$(MAKE) install-arch-artifacts ARCH=arm64
	@$(MAKE) sign-aax-local
	@echo "Building installer package..."
	packagesbuild -v installer/osx/Mach1\ Spatial\ System\ Installer.pkgproj
	codesign --force --sign $(APPLE_CODESIGN_CODE) --timestamp installer/osx/build/Mach1\ Spatial\ System\ Installer.pkg
	mkdir -p installer/osx/build/signed
	productsign --sign $(APPLE_CODESIGN_INSTALLER_ID) \
		"installer/osx/build/Mach1 Spatial System Installer.pkg" \
		"installer/osx/build/signed/Mach1 Spatial System Installer.pkg"
	@echo "Notarizing ARM64 installer..."
	@NOTARY_JSON=$$(mktemp); \
	if ! xcrun notarytool submit --wait --output-format json --keychain-profile 'notarize-app' \
		--apple-id $(APPLE_USERNAME) --password $(ALTOOL_APPPASS) --team-id $(APPLE_TEAM_CODE) \
		"installer/osx/build/signed/Mach1 Spatial System Installer.pkg" > "$$NOTARY_JSON" 2>&1; then \
		cat "$$NOTARY_JSON"; \
		rm -f "$$NOTARY_JSON"; \
		echo "Notarization did not complete successfully; skipping stapling."; \
		exit 1; \
	fi; \
	cat "$$NOTARY_JSON"; \
	NOTARY_STATUS=$$(/usr/bin/python3 -c 'import json,sys; print(json.load(open(sys.argv[1]))["status"])' "$$NOTARY_JSON"); \
	rm -f "$$NOTARY_JSON"; \
	if [ "$$NOTARY_STATUS" != "Accepted" ]; then \
		echo "Notarization status was $$NOTARY_STATUS; skipping stapling."; \
		exit 1; \
	fi; \
	xcrun stapler staple "installer/osx/build/signed/Mach1 Spatial System Installer.pkg"
	@# Rename to include architecture
	mv "installer/osx/build/signed/Mach1 Spatial System Installer.pkg" \
		"installer/osx/build/signed/Mach1 Spatial System Installer-arm64.pkg"
	@echo "ARM64 installer complete!"
	@echo ""
	@# === x86_64 (Intel) ===
	@echo "========================================"
	@echo "Building x86_64 (Intel) Installer"
	@echo "========================================"
	@rm -rf installer/osx/build/Mach1\ Spatial\ System\ Installer.pkg
	@$(MAKE) install-arch-artifacts ARCH=x86
	@$(MAKE) sign-aax-local
	@echo "Building installer package..."
	packagesbuild -v installer/osx/Mach1\ Spatial\ System\ Installer.pkgproj
	codesign --force --sign $(APPLE_CODESIGN_CODE) --timestamp installer/osx/build/Mach1\ Spatial\ System\ Installer.pkg
	productsign --sign $(APPLE_CODESIGN_INSTALLER_ID) \
		"installer/osx/build/Mach1 Spatial System Installer.pkg" \
		"installer/osx/build/signed/Mach1 Spatial System Installer.pkg"
	@echo "Notarizing x86_64 installer..."
	@NOTARY_JSON=$$(mktemp); \
	if ! xcrun notarytool submit --wait --output-format json --keychain-profile 'notarize-app' \
		--apple-id $(APPLE_USERNAME) --password $(ALTOOL_APPPASS) --team-id $(APPLE_TEAM_CODE) \
		"installer/osx/build/signed/Mach1 Spatial System Installer.pkg" > "$$NOTARY_JSON" 2>&1; then \
		cat "$$NOTARY_JSON"; \
		rm -f "$$NOTARY_JSON"; \
		echo "Notarization did not complete successfully; skipping stapling."; \
		exit 1; \
	fi; \
	cat "$$NOTARY_JSON"; \
	NOTARY_STATUS=$$(/usr/bin/python3 -c 'import json,sys; print(json.load(open(sys.argv[1]))["status"])' "$$NOTARY_JSON"); \
	rm -f "$$NOTARY_JSON"; \
	if [ "$$NOTARY_STATUS" != "Accepted" ]; then \
		echo "Notarization status was $$NOTARY_STATUS; skipping stapling."; \
		exit 1; \
	fi; \
	xcrun stapler staple "installer/osx/build/signed/Mach1 Spatial System Installer.pkg"
	@# Rename to include architecture
	mv "installer/osx/build/signed/Mach1 Spatial System Installer.pkg" \
		"installer/osx/build/signed/Mach1 Spatial System Installer-x86_64.pkg"
	@echo "x86_64 installer complete!"
	@echo ""
	@echo "========================================"
	@echo "Both installers created:"
	@echo "  - installer/osx/build/signed/Mach1 Spatial System Installer-arm64.pkg"
	@echo "  - installer/osx/build/signed/Mach1 Spatial System Installer-x86_64.pkg"
	@echo "========================================"
else ifeq ($(detected_OS),Windows)
	@echo "Building Windows installer..."
	$(WIN_INNO_PATH) "${CURDIR}/installer/win/installer.iss"
	@echo "Signing installer..."
	powershell -ExecutionPolicy Bypass -File installer\win\sign-file.ps1 \
		-FilePath "installer\win\Output\Mach1 Spatial System Installer.exe"
	@echo "Installer created at: installer\win\Output\Mach1 Spatial System Installer.exe"
endif

# List available CI builds
list-ci-builds:
	@echo "Available builds in S3:"
	@echo ""
	@echo "By Version:"
	@aws s3 ls "s3://$(ARTIFACTS_BUCKET)/builds/" --region us-east-1 2>/dev/null || echo "  (none or access denied)"
	@echo ""
	@echo "By Commit (recent):"
	@aws s3 ls "s3://$(ARTIFACTS_BUCKET)/commits/" --region us-east-1 2>/dev/null | tail -10 || echo "  (none or access denied)"

# Clean CI artifacts
clean-ci-artifacts:
	@echo "Cleaning CI artifacts..."
ifeq ($(detected_OS),Windows)
	@if exist "$(CI_ARTIFACTS_DIR)" rmdir /s /q "$(CI_ARTIFACTS_DIR)"
else
	rm -rf "$(CI_ARTIFACTS_DIR)"
endif
	@echo "CI artifacts cleaned"

# =============================================================================
# CI/CD Testing (Local Simulation)
# =============================================================================
# Simulates what CI/CD does, but runs locally. Useful for testing before push.
#
# Usage:
#   make test-ci-build              - Simulate full CI build
#   make test-ci-build-player-only  - Just build m1-player (fastest test)
#
test-ci-build:
	@echo "========================================"
	@echo "Simulating CI/CD Build Locally"
	@echo "========================================"
	@echo ""
	@echo "This simulates what GitHub Actions does:"
	@echo "  1. Clean build"
	@echo "  2. Configure all projects"
	@echo "  3. Build all projects"
	@echo "  4. Sign non-AAX plugins"
	@echo "  5. Package artifacts"
	@echo ""
	@echo "Press Ctrl+C to cancel, or wait 5 seconds..."
ifeq ($(detected_OS),Windows)
	@powershell -NoProfile -Command "Start-Sleep -Seconds 5"
else
	@sleep 5
endif
	@echo ""
	$(MAKE) clean
	$(MAKE) configure
	$(MAKE) build
	$(MAKE) codesign-vst3 || true
	$(MAKE) codesign-au || true
	$(MAKE) codesign-apps || true
	@echo ""
	@echo "========================================"
	@echo "CI Build Simulation Complete!"
	@echo "========================================"
	@echo ""
	@echo "Next steps to test full release flow:"
	@echo "  1. Connect USB iLok"
	@echo "  2. Run: make sign-aax-local"
	@echo "  3. Run: make installer-pkg"

test-ci-build-player-only:
	@echo "========================================"
	@echo "Testing m1-player Build (CI Simulation)"
	@echo "========================================"
	@echo ""
	@echo "This tests the VLC build + m1-player compilation"
	@echo "which is the most complex part of CI/CD."
	@echo ""
ifeq ($(detected_OS),Darwin)
	rm -rf m1-player/build-test
	cmake m1-player -Bm1-player/build-test -G "Xcode" \
		-DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF || true
	@if [ ! -f "m1-player/build-test/vlc-install/lib/libvlc.dylib" ]; then \
		echo "Building VLC from source..."; \
		cd m1-player && ./build_vlc.sh build-test && cd ..; \
		cmake m1-player -Bm1-player/build-test -G "Xcode" \
			-DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF; \
	fi
	cmake --build m1-player/build-test --config Release
	@echo ""
	@echo "m1-player build test complete!"
	@echo "   Output: m1-player/build-test/M1-Player_artefacts/"
else
	@echo "This test is currently macOS-only"
endif

# Validate workflow YAML syntax
test-ci-yaml:
	@echo "Validating GitHub Actions workflow syntax..."
	@if command -v actionlint >/dev/null 2>&1; then \
		actionlint .github/workflows/*.yml; \
		echo "Workflow YAML is valid"; \
	elif command -v act >/dev/null 2>&1; then \
		act -l > /dev/null 2>&1 && echo "Workflow YAML is valid (act)"; \
	else \
		echo "Install actionlint or act for YAML validation:"; \
		echo "  brew install actionlint"; \
		echo "  brew install act"; \
	fi

# clean and configure for release
configure: clean update-versions-internal
	cmake m1-monitor -Bm1-monitor/build -DBUILD_VST3=ON -DBUILD_AAX=ON -DBUILD_AU=ON -DBUILD_VST=ON -DVST2_PATH=$(VST2_PATH) -DJUCE_COPY_PLUGIN_AFTER_BUILD=OFF
	cmake m1-panner -Bm1-panner/build -DBUILD_VST3=ON -DBUILD_AAX=ON -DBUILD_AU=ON -DBUILD_VST=ON -DVST2_PATH=$(VST2_PATH) -DJUCE_COPY_PLUGIN_AFTER_BUILD=OFF
ifeq ($(detected_OS),Darwin)
	@echo "Configuring m1-player (release)..."
	cmake m1-player -Bm1-player/build -G "Xcode" -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF || true
	@if [ ! -f "m1-player/build/vlc-install/lib/libvlc.dylib" ]; then \
		echo ""; \
		echo "VLC libraries not found. Building VLC from source..."; \
		echo "This will take 20-40 minutes..."; \
		echo ""; \
		cd m1-player && ./build_vlc.sh build && \
		echo "" && \
		echo "VLC build complete! Reconfiguring CMake..." && \
		echo "" && \
		cd .. && cmake m1-player -Bm1-player/build -G "Xcode" -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF; \
	fi
else ifeq ($(detected_OS),Windows)
	@echo "Configuring m1-player (release)..."
	-cmake m1-player -Bm1-player/build -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF
	@if not exist "m1-player\build\vlc-install\lib\libvlc.lib" ( \
		echo. & \
		echo VLC libraries not found. Run build_vlc.ps1 to download VLC SDK... & \
		echo. & \
		powershell -ExecutionPolicy Bypass -File m1-player\build_vlc.ps1 -BuildDir build & \
		echo. & \
		echo VLC setup complete! Reconfiguring CMake... & \
		echo. & \
		cmake m1-player -Bm1-player/build -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF \
	)
else
	@echo "Configuring m1-player (release)..."
	cmake m1-player -Bm1-player/build -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF || true
	@if [ ! -f "m1-player/build/vlc-install/lib/libvlc.lib" ] && [ ! -f "m1-player/build/vlc-install/lib/libvlc.dll.a" ]; then \
		echo ""; \
		echo "VLC libraries not found. Building VLC from source..."; \
		echo "This will take 20-40 minutes..."; \
		echo ""; \
		cd m1-player && ./build_vlc.sh build && \
		echo "" && \
		echo "VLC build complete! Reconfiguring CMake..." && \
		echo "" && \
		cd .. && cmake m1-player -Bm1-player/build -DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF; \
	fi
endif
	cmake m1-orientationmanager -Bm1-orientationmanager/build
	cmake services/m1-system-helper -Bservices/m1-system-helper/build
ifeq ($(detected_OS),Darwin)
	cd m1-transcoder && ./scripts/setup.sh && npm install
else ifeq ($(detected_OS),Windows)
	cd m1-transcoder && npm install
endif

# Build targets for individual components
build-monitor:
	cmake --build m1-monitor/build --config "Release"

build-panner:
	cmake --build m1-panner/build --config "Release"

build-player:
	cmake --build m1-player/build --config "Release"

# Cross-compile release build for x86_64 on Apple Silicon
build-player-x86:
ifeq ($(detected_OS),Darwin)
	arch -x86_64 cmake --build m1-player/build-x86 --config "Release"
else
	@echo "ERROR: build-player-x86 is only available on macOS"
	@exit 1
endif

# Configure m1-player for x86_64 release (cross-compilation on Apple Silicon)
configure-player-x86:
ifeq ($(detected_OS),Darwin)
	@echo "Configuring m1-player for x86_64 release (cross-compilation via Rosetta)..."
	@if [ ! -d "/usr/local/bin" ]; then \
		echo "ERROR: x86_64 Homebrew not found at /usr/local"; \
		echo "Install it with:"; \
		echo "  arch -x86_64 /bin/bash -c \"\$$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)\""; \
		exit 1; \
	fi
	arch -x86_64 cmake m1-player -Bm1-player/build-x86 -G "Xcode" \
		-DCMAKE_OSX_ARCHITECTURES=x86_64 \
		-DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF || true
	@if [ ! -f "m1-player/build-x86/vlc-install/lib/libvlc.dylib" ]; then \
		echo ""; \
		echo "VLC libraries not found. Building VLC for x86_64..."; \
		echo "This will take 20-40 minutes..."; \
		echo ""; \
		cd m1-player && arch -x86_64 ./build_vlc.sh build-x86 && \
		echo "" && \
		echo "VLC build complete! Reconfiguring CMake..." && \
		echo "" && \
		cd .. && arch -x86_64 cmake m1-player -Bm1-player/build-x86 -G "Xcode" \
			-DCMAKE_OSX_ARCHITECTURES=x86_64 \
			-DLIBVLC_BUILD_FROM_SOURCE=ON -DLIBVLC_STATIC=OFF; \
	fi
else
	@echo "ERROR: configure-player-x86 is only available on macOS"
	@exit 1
endif

# Build VLC from source (happens automatically as part of build-player)
# Use this target if you want to build VLC separately first
#
# ARCHITECTURE NOTE:
# VLC and m1-player are built for the HOST architecture only.
# Universal binaries are NOT supported due to VLC/Homebrew dependencies.
# For distribution:
#   - Build on Apple Silicon Mac for ARM64 (.app for M1/M2/M3 Macs)
#   - Build on Intel Mac for x86_64 (.app for older Intel Macs)
# The installer should be built and deployed separately for each architecture.
#
# CROSS-COMPILATION (macOS only):
# To build x86_64 on Apple Silicon, use the x86 targets:
#   make dev-player-x86   (for development)
#   make build-player-x86 (for release)
# Requires x86_64 Homebrew installed at /usr/local
build-vlc:
	@echo "Building VLC from source..."
ifeq ($(detected_OS),Darwin)
	@if [ -d "m1-player/build-dev" ]; then \
		echo "Using development build directory (build-dev)"; \
		cd m1-player && ./build_vlc.sh build-dev; \
	elif [ -d "m1-player/build" ]; then \
		echo "Using release build directory (build)"; \
		cd m1-player && ./build_vlc.sh build; \
	else \
		echo "Error: Neither m1-player/build nor m1-player/build-dev found."; \
		echo "Run 'make configure' or 'make dev-player' first."; \
		exit 1; \
	fi
else ifeq ($(detected_OS),Windows)
	@if exist "m1-player\build-dev" ( \
		echo Using development build directory (build-dev) & \
		powershell -ExecutionPolicy Bypass -File m1-player\build_vlc.ps1 -BuildDir build-dev \
	) else if exist "m1-player\build" ( \
		echo Using release build directory (build) & \
		powershell -ExecutionPolicy Bypass -File m1-player\build_vlc.ps1 -BuildDir build \
	) else ( \
		echo Error: Neither m1-player\build nor m1-player\build-dev found. & \
		echo Run 'make configure' or 'make dev-player' first. & \
		exit /b 1 \
	)
else
	@if [ -d "m1-player/build-dev" ]; then \
		echo "Using development build directory (build-dev)"; \
		cd m1-player && ./build_vlc.sh build-dev; \
	elif [ -d "m1-player/build" ]; then \
		echo "Using release build directory (build)"; \
		cd m1-player && ./build_vlc.sh build; \
	else \
		echo "Error: Neither m1-player/build nor m1-player/build-dev found."; \
		echo "Run 'make configure' or 'make dev-player' first."; \
		exit 1; \
	fi
endif
	@echo "VLC setup complete"

build-orientationmanager:
	cmake --build m1-orientationmanager/build --config "Release"

build-system-helper:
	cmake --build services/m1-system-helper/build --config "Release"

build-transcoder:
ifeq ($(detected_OS),Darwin)
	cd m1-transcoder && npm run package-mac
else ifeq ($(detected_OS),Windows)
	cd m1-transcoder && npm run package-win
endif

# Build configured release
build: build-monitor build-panner build-player build-orientationmanager build-system-helper build-transcoder

codesign: codesign-aax codesign-vst codesign-vst3 codesign-au codesign-apps
	@echo "All code signing completed"

# Test Azure signing setup
test-azure-signing:
ifeq ($(detected_OS),Windows)
	@echo "=== Testing Azure CodeSigning Setup ==="
	@echo "Checking environment variables..."
	@if not defined AZURE_CLIENT_ID echo WARNING: AZURE_CLIENT_ID not set in environment
	@if not defined AZURE_TENANT_ID echo WARNING: AZURE_TENANT_ID not set in environment
	@if not defined AZURE_CLIENT_SECRET echo WARNING: AZURE_CLIENT_SECRET not set in environment
	@echo ""
	@echo "Checking files..."
	@if exist $(AZURE_DLIB_PATH) (echo [OK] Azure DLL found: $(AZURE_DLIB_PATH)) else (echo [ERROR] Azure DLL not found: $(AZURE_DLIB_PATH))
	@if exist $(AZURE_METADATA_PATH) (echo [OK] Metadata file found: $(AZURE_METADATA_PATH)) else (echo [ERROR] Metadata file not found: $(AZURE_METADATA_PATH))
	@if exist $(WIN_SIGNTOOL_PATH) (echo [OK] SignTool found: $(WIN_SIGNTOOL_PATH)) else (echo [ERROR] SignTool not found: $(WIN_SIGNTOOL_PATH))
	@echo ""
	@echo "Metadata content:"
	@type $(AZURE_METADATA_PATH)
	@echo ""
	@echo "=== Setup Check Complete ==="
	@echo ""
	@echo "To manually test signing, use:"
	@echo "  set AZURE_CLIENT_ID=$(AZURE_CLIENT_ID)"
	@echo "  set AZURE_TENANT_ID=$(AZURE_TENANT_ID)"
	@echo "  set AZURE_CLIENT_SECRET=$(AZURE_CLIENT_SECRET)"
	@echo "  $(WIN_SIGNTOOL_PATH) sign /v /debug /fd SHA256 /tr $(AZURE_TIMESTAMP_URL) /td SHA256 /dlib $(AZURE_DLIB_PATH) /dmdf $(AZURE_METADATA_PATH) <file_to_sign>"
endif

# Verify Windows signatures
verify-win-signing:
ifeq ($(detected_OS),Windows)
	@echo "=== Verifying Windows Code Signatures ==="
	@echo ""
	@echo "--- VST3 Plugins ---"
	@if exist "m1-monitor\build\M1-Monitor_artefacts\Release\VST3\M1-Monitor.vst3\Contents\x86_64-win\M1-Monitor.vst3" ( \
		echo Checking M1-Monitor VST3... && \
		$(WIN_SIGNTOOL_PATH) verify /pa /v "m1-monitor\build\M1-Monitor_artefacts\Release\VST3\M1-Monitor.vst3\Contents\x86_64-win\M1-Monitor.vst3" \
	) else (echo SKIP: M1-Monitor VST3 not found)
	@if exist "m1-panner\build\M1-Panner_artefacts\Release\VST3\M1-Panner.vst3\Contents\x86_64-win\M1-Panner.vst3" ( \
		echo Checking M1-Panner VST3... && \
		$(WIN_SIGNTOOL_PATH) verify /pa /v "m1-panner\build\M1-Panner_artefacts\Release\VST3\M1-Panner.vst3\Contents\x86_64-win\M1-Panner.vst3" \
	) else (echo SKIP: M1-Panner VST3 not found)
	@echo ""
	@echo "--- Applications ---"
	@if exist "m1-player\build\M1-Player_artefacts\Release\M1-Player.exe" ( \
		echo Checking M1-Player... && \
		$(WIN_SIGNTOOL_PATH) verify /pa /v "m1-player\build\M1-Player_artefacts\Release\M1-Player.exe" \
	) else (echo SKIP: M1-Player not found)
	@if exist "m1-orientationmanager\build\m1-orientationmanager_artefacts\Release\m1-orientationmanager.exe" ( \
		echo Checking m1-orientationmanager... && \
		$(WIN_SIGNTOOL_PATH) verify /pa /v "m1-orientationmanager\build\m1-orientationmanager_artefacts\Release\m1-orientationmanager.exe" \
	) else (echo SKIP: m1-orientationmanager not found)
	@if exist "services\m1-system-helper\build\m1-system-helper_artefacts\Release\m1-system-helper.exe" ( \
		echo Checking m1-system-helper... && \
		$(WIN_SIGNTOOL_PATH) verify /pa /v "services\m1-system-helper\build\m1-system-helper_artefacts\Release\m1-system-helper.exe" \
	) else (echo SKIP: m1-system-helper not found)
	@echo ""
	@echo "--- Installer ---"
	@if exist "installer\win\Output\Mach1 Spatial System Installer.exe" ( \
		echo Checking installer... && \
		$(WIN_SIGNTOOL_PATH) verify /pa /v "installer\win\Output\Mach1 Spatial System Installer.exe" && \
		echo Installer signature: OK \
	) else (echo SKIP: Installer not found)
	@echo ""
	@echo "=== Verification Complete ==="
	@echo ""
	@echo "Note: Valid signatures should show 'Successfully verified'"
	@echo "and issuer should be 'Microsoft Identity Verification Root...' for Azure Trusted Signing"
endif

codesign-aax:
ifeq ($(detected_OS),Darwin)
	@echo "Code signing AAX plugins..."
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_MONITOR_ENTITLEMENTS) --timestamp m1-monitor/build/M1-Monitor_artefacts/AAX/M1-Monitor.aaxplugin
	$(WRAPTOOL) sign --verbose --account $(PACE_ACCOUNT) --wcguid "$(MONITOR_FREE_GUID)" --signid $(APPLE_CODESIGN_ID) --in m1-monitor/build/M1-Monitor_artefacts/AAX/M1-Monitor.aaxplugin --out m1-monitor/build/M1-Monitor_artefacts/AAX/M1-Monitor.aaxplugin --autoinstall on
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_PANNER_ENTITLEMENTS) --timestamp m1-panner/build/M1-Panner_artefacts/AAX/M1-Panner.aaxplugin
	$(WRAPTOOL) sign --verbose --account $(PACE_ACCOUNT) --wcguid "$(PANNER_FREE_GUID)" --signid $(APPLE_CODESIGN_ID) --in m1-panner/build/M1-Panner_artefacts/AAX/M1-Panner.aaxplugin --out m1-panner/build/M1-Panner_artefacts/AAX/M1-Panner.aaxplugin --autoinstall on
	@echo "AAX plugins code signed"
else ifeq ($(detected_OS),Windows)
	@echo "Code signing AAX plugins..."
	@echo "Signing M1-Monitor AAX plugin..."
	@if not exist "m1-monitor\build\M1-Monitor_artefacts\Release\AAX\M1-Monitor.aaxplugin" ( \
		echo ERROR: M1-Monitor AAX plugin not found. Run 'make build-monitor' first. && \
		exit 1 \
	)
	@if not exist "installer\win\aax-signtool.bat" ( \
		echo ERROR: Azure signing wrapper not found at installer\win\aax-signtool.bat && \
		exit 1 \
	)
	@echo "Setting up Azure Trusted Signing environment..."
	@echo "Running wraptool for M1-Monitor with Azure Trusted Signing..."
	@set SIGNTOOL_PATH=$(WIN_SIGNTOOL_PATH) && set ACS_DLIB=$(AZURE_DLIB_PATH) && set ACS_JSON=$(AZURE_METADATA_PATH) && set AZURE_TENANT_ID=$(AZURE_TENANT_ID) && set AZURE_CLIENT_ID=$(AZURE_CLIENT_ID) && set AZURE_SECRET_ID=$(AZURE_CLIENT_SECRET) && $(WRAPTOOL) sign --signtool "$(CURDIR)/installer/win/aax-signtool.bat" --signid 1 --verbose --installedbinaries --account $(PACE_ACCOUNT) --wcguid "$(MONITOR_FREE_GUID)" --in m1-monitor/build/M1-Monitor_artefacts/Release/AAX/M1-Monitor.aaxplugin --out m1-monitor/build/M1-Monitor_artefacts/Release/AAX/M1-Monitor.aaxplugin || ( \
		echo ERROR: M1-Monitor signing failed. && \
		exit 1 \
	)
	@echo "M1-Monitor AAX plugin signed successfully"
	@echo "Signing M1-Panner AAX plugin..."
	@if not exist "m1-panner\build\M1-Panner_artefacts\Release\AAX\M1-Panner.aaxplugin" ( \
		echo ERROR: M1-Panner AAX plugin not found. Run 'make build-panner' first. && \
		exit 1 \
	)
	@echo "Setting up Azure Trusted Signing environment..."
	@echo "Running wraptool for M1-Panner with Azure Trusted Signing..."
	@set SIGNTOOL_PATH=$(WIN_SIGNTOOL_PATH) && set ACS_DLIB=$(AZURE_DLIB_PATH) && set ACS_JSON=$(AZURE_METADATA_PATH) && set AZURE_TENANT_ID=$(AZURE_TENANT_ID) && set AZURE_CLIENT_ID=$(AZURE_CLIENT_ID) && set AZURE_SECRET_ID=$(AZURE_CLIENT_SECRET) && $(WRAPTOOL) sign --signtool "$(CURDIR)/installer/win/aax-signtool.bat" --signid 1 --verbose --installedbinaries --account $(PACE_ACCOUNT) --wcguid "$(PANNER_FREE_GUID)" --in m1-panner/build/M1-Panner_artefacts/Release/AAX/M1-Panner.aaxplugin --out m1-panner/build/M1-Panner_artefacts/Release/AAX/M1-Panner.aaxplugin || ( \
		echo ERROR: M1-Panner signing failed. && \
		exit 1 \
	)
	@echo "M1-Panner AAX plugin signed successfully"
	@echo "AAX plugins code signed"
endif

codesign-vst:
ifeq ($(detected_OS),Darwin)
	@echo "Code signing VST plugins..."
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_MONITOR_ENTITLEMENTS) --timestamp m1-monitor/build/M1-Monitor_artefacts/VST/M1-Monitor.vst
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_PANNER_ENTITLEMENTS) --timestamp m1-panner/build/M1-Panner_artefacts/VST/M1-Panner.vst
	@echo "VST plugins code signed"
endif

codesign-vst3:
ifeq ($(detected_OS),Darwin)
	@echo "Code signing VST3 plugins..."
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_MONITOR_ENTITLEMENTS) --timestamp m1-monitor/build/M1-Monitor_artefacts/VST3/M1-Monitor.vst3
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_PANNER_ENTITLEMENTS) --timestamp m1-panner/build/M1-Panner_artefacts/VST3/M1-Panner.vst3
	@echo "VST3 plugins code signed"
else ifeq ($(detected_OS),Windows)
	@echo "Code signing VST3 plugins with Azure Trusted Signing..."
	@if exist "m1-monitor\build\M1-Monitor_artefacts\Release\VST3\M1-Monitor.vst3\Contents\x86_64-win\M1-Monitor.vst3" ( \
		powershell -ExecutionPolicy Bypass -File installer\win\sign-file.ps1 -FilePath "m1-monitor\build\M1-Monitor_artefacts\Release\VST3\M1-Monitor.vst3\Contents\x86_64-win\M1-Monitor.vst3" \
	) else ( \
		echo "SKIP: M1-Monitor VST3 not found" \
	)
	@if exist "m1-panner\build\M1-Panner_artefacts\Release\VST3\M1-Panner.vst3\Contents\x86_64-win\M1-Panner.vst3" ( \
		powershell -ExecutionPolicy Bypass -File installer\win\sign-file.ps1 -FilePath "m1-panner\build\M1-Panner_artefacts\Release\VST3\M1-Panner.vst3\Contents\x86_64-win\M1-Panner.vst3" \
	) else ( \
		echo "SKIP: M1-Panner VST3 not found" \
	)
	@echo "VST3 plugins code signed"
endif

codesign-au:
ifeq ($(detected_OS),Darwin)
	@echo "Code signing AU plugins..."
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_MONITOR_ENTITLEMENTS) --timestamp m1-monitor/build/M1-Monitor_artefacts/AU/M1-Monitor.component
	codesign --force --sign $(APPLE_CODESIGN_CODE) --entitlements $(MAC_PANNER_ENTITLEMENTS) --timestamp m1-panner/build/M1-Panner_artefacts/AU/M1-Panner.component
	@echo "AU plugins code signed"
endif

codesign-apps:
ifeq ($(detected_OS),Darwin)
	@echo "Code signing applications..."
	# Sign bundled libraries and plugins inside M1-Player.app first (required for notarization)
	# This signs all dylibs in Contents (Frameworks and PlugIns) with the same identity
	find "$(MAC_PLAYER_APP_PATH)/Contents" -type f -name "*.dylib" -exec codesign --force --sign $(APPLE_CODESIGN_CODE) --timestamp -o runtime {} \;
	
	codesign -v --force -o runtime --entitlements m1-player/Resources/M1-Player.entitlements --sign $(APPLE_CODESIGN_CODE) --timestamp "$(MAC_PLAYER_APP_PATH)"
	codesign -v --force -o runtime --entitlements m1-orientationmanager/Resources/entitlements.mac.plist --sign $(APPLE_CODESIGN_CODE) --timestamp "$(MAC_ORIENTATION_BIN_PATH)"
	codesign -v --force -o runtime --entitlements services/m1-system-helper/Resources/macos/entitlements.mac.plist --sign $(APPLE_CODESIGN_CODE) --timestamp "$(MAC_HELPER_APP_PATH)"
	@echo "Applications code signed"
else ifeq ($(detected_OS),Windows)
	@echo "Code signing Windows applications with Azure Trusted Signing..."
	@if exist "$(subst /,\,$(WIN_PLAYER_EXE_PATH))" ( \
		powershell -ExecutionPolicy Bypass -File installer\win\sign-file.ps1 -FilePath "$(subst /,\,$(WIN_PLAYER_EXE_PATH))" \
	) else ( \
		echo "SKIP: M1-Player not found" \
	)
	@if exist "$(subst /,\,$(WIN_ORIENTATION_EXE_PATH))" ( \
		powershell -ExecutionPolicy Bypass -File installer\win\sign-file.ps1 -FilePath "$(subst /,\,$(WIN_ORIENTATION_EXE_PATH))" \
	) else ( \
		echo "SKIP: m1-orientationmanager not found" \
	)
	@if exist "$(subst /,\,$(WIN_HELPER_EXE_PATH))" ( \
		powershell -ExecutionPolicy Bypass -File installer\win\sign-file.ps1 -FilePath "$(subst /,\,$(WIN_HELPER_EXE_PATH))" \
	) else ( \
		echo "SKIP: m1-system-helper not found" \
	)
	@echo "Windows applications code signed"
endif

# Notarize VST3 plugins for testing and distribution
notarize-vst3:
ifeq ($(detected_OS),Darwin)
	@echo "=== Notarizing VST3 Plugins for Testing ==="
	@echo "Creating zip archives for notarization..."
	@mkdir -p installer/osx/build/notarize
	# Create zip for M1-Monitor VST3
	@if [ -d "m1-monitor/build/M1-Monitor_artefacts/VST3/M1-Monitor.vst3" ]; then \
		ditto -c -k --keepParent "$(PWD)/m1-monitor/build/M1-Monitor_artefacts/VST3/M1-Monitor.vst3" "$(PWD)/installer/osx/build/notarize/M1-Monitor.vst3.zip"; \
		echo "Created M1-Monitor.vst3.zip"; \
	else \
		echo "ERROR: M1-Monitor VST3 not found. Run 'make build-monitor' first."; \
		exit 1; \
	fi
	# Create zip for M1-Panner VST3
	@if [ -d "m1-panner/build/M1-Panner_artefacts/VST3/M1-Panner.vst3" ]; then \
		ditto -c -k --keepParent "$(PWD)/m1-panner/build/M1-Panner_artefacts/VST3/M1-Panner.vst3" "$(PWD)/installer/osx/build/notarize/M1-Panner.vst3.zip"; \
		echo "Created M1-Panner.vst3.zip"; \
	else \
		echo "ERROR: M1-Panner VST3 not found. Run 'make build-panner' first."; \
		exit 1; \
	fi
	@echo ""
	@echo "Submitting VST3 plugins for notarization..."
	# Notarize M1-Monitor VST3
	@echo "Notarizing M1-Monitor VST3..."
	@xcrun notarytool submit --wait --keychain-profile 'notarize-app' --apple-id $(APPLE_USERNAME) --password $(ALTOOL_APPPASS) --team-id $(APPLE_TEAM_CODE) "installer/osx/build/notarize/M1-Monitor.vst3.zip" || (echo "M1-Monitor VST3 notarization failed" && exit 1)
	# Notarize M1-Panner VST3
	@echo "Notarizing M1-Panner VST3..."
	@xcrun notarytool submit --wait --keychain-profile 'notarize-app' --apple-id $(APPLE_USERNAME) --password $(ALTOOL_APPPASS) --team-id $(APPLE_TEAM_CODE) "installer/osx/build/notarize/M1-Panner.vst3.zip" || (echo "M1-Panner VST3 notarization failed" && exit 1)
	@echo ""
	@echo "Stapling notarization tickets to VST3 plugins..."
	# Staple tickets to the original VST3 bundles
	@xcrun stapler staple m1-monitor/build/M1-Monitor_artefacts/VST3/M1-Monitor.vst3
	@xcrun stapler staple m1-panner/build/M1-Panner_artefacts/VST3/M1-Panner.vst3
	@echo ""
	@echo "Creating notarized zip archives for distribution..."
	# Create final notarized zips
	@ditto -c -k --keepParent "$(PWD)/m1-monitor/build/M1-Monitor_artefacts/VST3/M1-Monitor.vst3" "$(PWD)/installer/osx/build/notarize/M1-Monitor-Notarized.vst3.zip"
	@ditto -c -k --keepParent "$(PWD)/m1-panner/build/M1-Panner_artefacts/VST3/M1-Panner.vst3" "$(PWD)/installer/osx/build/notarize/M1-Panner-Notarized.vst3.zip"
	@echo ""
	@echo "=== VST3 Notarization Complete ==="
	@echo "Notarized VST3 plugins available at:"
	@echo "  installer/osx/build/notarize/M1-Monitor-Notarized.vst3.zip"
	@echo "  installer/osx/build/notarize/M1-Panner-Notarized.vst3.zip"
	@echo ""
	@echo "Verification commands:"
	@echo "  spctl -a -t install -v installer/osx/build/notarize/M1-Monitor-Notarized.vst3.zip"
	@echo "  spctl -a -t install -v installer/osx/build/notarize/M1-Panner-Notarized.vst3.zip"
	@echo ""
	@echo "To install for testing:"
	@echo "  unzip installer/osx/build/notarize/M1-Monitor-Notarized.vst3.zip -d ~/Library/Audio/Plug-Ins/VST3/"
	@echo "  unzip installer/osx/build/notarize/M1-Panner-Notarized.vst3.zip -d ~/Library/Audio/Plug-Ins/VST3/"
else
	@echo "VST3 notarization is only supported on macOS"
endif

# Verify notarized VST3 plugins
verify-vst3:
ifeq ($(detected_OS),Darwin)
	@echo "=== Verifying Notarized VST3 Plugins ==="
	@echo "Checking M1-Monitor VST3..."
	@if [ -f "installer/osx/build/notarize/M1-Monitor-Notarized.vst3.zip" ]; then \
		spctl -a -t install -v installer/osx/build/notarize/M1-Monitor-Notarized.vst3.zip; \
		echo "M1-Monitor VST3: ✓ Notarized and verified"; \
	else \
		echo "M1-Monitor VST3: ✗ Notarized zip not found"; \
	fi
	@echo ""
	@echo "Checking M1-Panner VST3..."
	@if [ -f "installer/osx/build/notarize/M1-Panner-Notarized.vst3.zip" ]; then \
		spctl -a -t install -v installer/osx/build/notarize/M1-Panner-Notarized.vst3.zip; \
		echo "M1-Panner VST3: ✓ Notarized and verified"; \
	else \
		echo "M1-Panner VST3: ✗ Notarized zip not found"; \
	fi
	@echo ""
	@echo "=== VST3 Verification Complete ==="
else
	@echo "VST3 verification is only supported on macOS"
endif

# Clean notarization artifacts
clean-notarize:
ifeq ($(detected_OS),Darwin)
	@echo "Cleaning notarization artifacts..."
	@rm -rf installer/osx/build/notarize
	@echo "Notarization artifacts cleaned"
else
	@echo "Notarization cleanup is only supported on macOS"
endif

# codesigning and notarizing m1-transcoder is done via electron-builder
notarize:
ifeq ($(detected_OS),Darwin)
	# m1-player
	ditto -c -k --keepParent "$(PWD)/$(MAC_PLAYER_APP_PATH)" "$(PWD)/$(MAC_PLAYER_APP_DIR)/M1-Player.app.zip"
	#cd "m1-player/build/M1-Player_artefacts" && zip -qr M1-Player.app.zip M1-Player.app -x "*.DS_Store"
	./installer/osx/macos_utilities.sh -f M1-Player -e .app -z .zip -p "$(MAC_PLAYER_APP_DIR)" -k 'notarize-app' --apple-id $(APPLE_USERNAME) --apple-app-pass $(ALTOOL_APPPASS) -t $(APPLE_TEAM_CODE)
	# m1-orientationmanager
	#ditto -c -k --keepParent "$(PWD)/m1-orientationmanager/build/m1-orientationmanager_artefacts/m1-orientationmanager" "$(PWD)/m1-orientationmanager/build/m1-orientationmanager_artefacts/m1-orientationmanager.zip"
	#cd "m1-orientationmanager/build/m1-orientationmanager_artefacts" && zip -qr m1-orientationmanager.zip m1-orientationmanager -x "*.DS_Store"
	#./installer/osx/macos_utilities.sh -f m1-orientationmanager -z .zip -p m1-orientationmanager/build/m1-orientationmanager_artefacts -k 'notarize-app' --apple-id $(APPLE_USERNAME) --apple-app-pass $(ALTOOL_APPPASS) -t $(APPLE_TEAM_CODE)
	# m1-system-helper
	#ditto -c -k --keepParent "$(PWD)/services/m1-system-helper/build/m1-system-helper/m1-system-helper" "$(PWD)/services/m1-system-helper/build/m1-system-helper_artefacts/m1-system-helper.zip"
	#cd "services/m1-system-helper/build/m1-system-helper" && zip -qr m1-system-helper.zip m1-system-helper -x "*.DS_Store"
	#./installer/osx/macos_utilities.sh -f m1-system-helper -z .zip -p services/m1-system-helper/build/m1-system-helper_artefacts -k 'notarize-app' --apple-id $(APPLE_USERNAME) --apple-app-pass $(ALTOOL_APPPASS) -t $(APPLE_TEAM_CODE)
endif

# Plugin validation with pluginval
download-pluginval:
ifeq ($(detected_OS),Darwin)
	@if [ ! -f "./pluginval.app/Contents/MacOS/pluginval" ]; then \
		echo "Downloading pluginval for macOS..."; \
		curl -LO "https://github.com/Tracktion/pluginval/releases/latest/download/pluginval_macOS.zip"; \
		unzip -o pluginval_macOS.zip; \
		rm pluginval_macOS.zip; \
		echo "pluginval downloaded and extracted"; \
	else \
		echo "pluginval already exists"; \
	fi
else ifeq ($(detected_OS),Windows)
	@if not exist "pluginval.exe" ( \
		echo "Downloading pluginval for Windows..." && \
		curl -LO "https://github.com/Tracktion/pluginval/releases/latest/download/pluginval_Windows.zip" && \
		7z x -aoa pluginval_Windows.zip && \
		del pluginval_Windows.zip && \
		echo "pluginval downloaded and extracted" \
	) else ( \
		echo "pluginval already exists" \
	)
endif

# Helper function to check AAX validator is configured
check-aax-validator:
	@if [ -z "$(AAX_VALIDATOR_PATH)" ]; then \
		echo "ERROR: AAX_VALIDATOR_PATH not set in Makefile.variables"; \
		echo "Please set AAX_VALIDATOR_PATH to the path of the dsh tool."; \
		echo "Example: /path/to/aax-validator-dsh-.../CommandLineTools/dsh"; \
		exit 1; \
	elif [ ! -f "$(AAX_VALIDATOR_PATH)" ]; then \
		echo "ERROR: AAX validator not found at: $(AAX_VALIDATOR_PATH)"; \
		echo "Please check your AAX_VALIDATOR_PATH in Makefile.variables"; \
		exit 1; \
	else \
		echo "Using AAX validator at: $(AAX_VALIDATOR_PATH)"; \
	fi

test-monitor: dev-monitor download-pluginval
	@echo "Building M1-Monitor in development mode..."
	cmake --build m1-monitor/build-dev --config "Debug"
	@echo "Testing M1-Monitor plugin..."
ifeq ($(detected_OS),Darwin)
	./pluginval.app/Contents/MacOS/pluginval --strictness-level 10 --repeat 2 --verbose --validate "m1-monitor/build-dev/M1-Monitor_artefacts/Debug/VST3/M1-Monitor.vst3"
else ifeq ($(detected_OS),Windows)
	./pluginval.exe --strictness-level 10 --repeat 2 --verbose --skip-gui-tests --validate "m1-monitor/build-dev/M1-Monitor_artefacts/Debug/VST3/M1-Monitor.vst3"
endif
	@echo "M1-Monitor validation completed"

test-panner: dev-panner download-pluginval
	@echo "Building M1-Panner in development mode..."
	cmake --build m1-panner/build-dev --config "Debug"
	@echo "Testing M1-Panner plugin..."
ifeq ($(detected_OS),Darwin)
	./pluginval.app/Contents/MacOS/pluginval --strictness-level 10 --repeat 2 --verbose --validate "m1-panner/build-dev/M1-Panner_artefacts/Debug/VST3/M1-Panner.vst3"
else ifeq ($(detected_OS),Windows)
	./pluginval.exe --strictness-level 10 --repeat 2 --verbose --skip-gui-tests --validate "m1-panner/build-dev/M1-Panner_artefacts/Debug/VST3/M1-Panner.vst3"
endif
	@echo "M1-Panner validation completed"

test-plugins: test-monitor test-panner
	@echo "All plugin validations completed successfully!"

# AAX-specific validation and diagnostics
verify-aax-signing:
	@echo "=== Verifying AAX Plugin Code Signing ==="
ifeq ($(detected_OS),Darwin)
	@echo "\n--- M1-Monitor AAX Plugin ---"
	@if [ -f "m1-monitor/build/M1-Monitor_artefacts/AAX/M1-Monitor.aaxplugin/Contents/MacOS/M1-Monitor" ]; then \
		codesign -dvvv m1-monitor/build/M1-Monitor_artefacts/AAX/M1-Monitor.aaxplugin 2>&1 | grep -E "(Authority|TeamIdentifier|Signature|Format)"; \
		echo "Checking PACE wrapping:"; \
		WRAP_OUTPUT=$$($(WRAPTOOL) verify --verbose --in m1-monitor/build/M1-Monitor_artefacts/AAX/M1-Monitor.aaxplugin 2>&1); \
		echo "$$WRAP_OUTPUT"; \
	else \
		echo "ERROR: M1-Monitor AAX plugin not found. Run 'make build-monitor' first."; \
		exit 1; \
	fi
	@echo "\n--- M1-Panner AAX Plugin ---"
	@if [ -f "m1-panner/build/M1-Panner_artefacts/AAX/M1-Panner.aaxplugin/Contents/MacOS/M1-Panner" ]; then \
		codesign -dvvv m1-panner/build/M1-Panner_artefacts/AAX/M1-Panner.aaxplugin 2>&1 | grep -E "(Authority|TeamIdentifier|Signature|Format)"; \
		echo "Checking PACE wrapping:"; \
		WRAP_OUTPUT=$$($(WRAPTOOL) verify --verbose --in m1-panner/build/M1-Panner_artefacts/AAX/M1-Panner.aaxplugin 2>&1); \
		echo "$$WRAP_OUTPUT"; \
	else \
		echo "ERROR: M1-Panner AAX plugin not found. Run 'make build-panner' first."; \
		exit 1; \
	fi
else ifeq ($(detected_OS),Windows)
	@echo "\n--- M1-Monitor AAX Plugin ---"
	@if exist "m1-monitor\build\M1-Monitor_artefacts\Release\AAX\M1-Monitor.aaxplugin" ( \
		$(WRAPTOOL) verify --verbose --in m1-monitor\build\M1-Monitor_artefacts\Release\AAX\M1-Monitor.aaxplugin || echo "WARNING: PACE verification failed" \
	) else ( \
		echo "ERROR: M1-Monitor AAX plugin not found. Run 'make build-monitor' first." && exit 1 \
	)
	@echo "\n--- M1-Panner AAX Plugin ---"
	@if exist "m1-panner\build\M1-Panner_artefacts\Release\AAX\M1-Panner.aaxplugin" ( \
		$(WRAPTOOL) verify --verbose --in m1-panner\build\M1-Panner_artefacts\Release\AAX\M1-Panner.aaxplugin || echo "WARNING: PACE verification failed" \
	) else ( \
		echo "ERROR: M1-Panner AAX plugin not found. Run 'make build-panner' first." && exit 1 \
	)
endif
	@echo "\n=== Code Signing Verification Complete ==="

test-aax-release: check-aax-validator verify-aax-signing
	@echo "=== Testing Release AAX Plugins ==="
	@echo "NOTE: Ensure iLok License Manager is running for PACE support"
	@echo "NOTE: macOS 15+ (Sequoia) may cause validator Ruby errors - this is a known Avid compatibility issue"
ifeq ($(detected_OS),Darwin)
	@echo "\n--- Validating M1-Monitor Release AAX ---"; \
	printf "load_dish aaxval\nruntests \"$(shell pwd)/m1-monitor/build/M1-Monitor_artefacts/AAX/M1-Monitor.aaxplugin\"\nexit\n" | $(AAX_VALIDATOR_PATH) || echo "WARNING: M1-Monitor AAX validation had issues"; \
	echo "\n--- Validating M1-Panner Release AAX ---"; \
	printf "load_dish aaxval\nruntests \"$(shell pwd)/m1-panner/build/M1-Panner_artefacts/AAX/M1-Panner.aaxplugin\"\nexit\n" | $(AAX_VALIDATOR_PATH) || echo "WARNING: M1-Panner AAX validation had issues"
else ifeq ($(detected_OS),Windows)
	@echo "\n--- Validating M1-Monitor Release AAX ---"
	@(echo load_dish aaxval && echo runtests "$(shell pwd)\m1-monitor\build\M1-Monitor_artefacts\Release\AAX\M1-Monitor.aaxplugin" && echo exit) | $(AAX_VALIDATOR_PATH) || echo "WARNING: M1-Monitor AAX validation had issues"
	@echo "\n--- Validating M1-Panner Release AAX ---"
	@(echo load_dish aaxval && echo runtests "$(shell pwd)\m1-panner\build\M1-Panner_artefacts\Release\AAX\M1-Panner.aaxplugin" && echo exit) | $(AAX_VALIDATOR_PATH) || echo "WARNING: M1-Panner AAX validation had issues"
endif
	@echo "\n=== Release AAX Plugin Validation Complete ==="
	@echo "TIP: If tests abort with Ruby errors on macOS 15+, manually test in Pro Tools"
	@echo "TIP: Kill stuck processes with: pkill -f aaxval_test"

diagnose-aax:
	@echo "=== AAX Plugin Diagnostic Report ==="
ifeq ($(detected_OS),Darwin)
	@echo "\n--- System Information ---"
	@echo "macOS Version: $$(sw_vers -productVersion)"
	@echo "Architecture: $$(uname -m)"
	@echo "Pro Tools Installed: $$(if [ -d '/Applications/Pro Tools.app' ]; then echo 'Yes'; else echo 'No'; fi)"
	@echo "\n--- AAX Plugin Directories ---"
	@echo "Global AAX Plugins:"
	@ls -la "/Library/Application Support/Avid/Audio/Plug-Ins/" 2>/dev/null | grep -E "(M1-Monitor|M1-Panner)" || echo "No Mach1 plugins found"
	@echo "\nUser AAX Plugins:"
	@ls -la "$$HOME/Library/Application Support/Avid/Audio/Plug-Ins/" 2>/dev/null | grep -E "(M1-Monitor|M1-Panner)" || echo "No Mach1 plugins found"
	@echo "\n--- Code Signing Status ---"
	@for plugin in "/Library/Application Support/Avid/Audio/Plug-Ins/M1-Monitor.aaxplugin" \
	               "/Library/Application Support/Avid/Audio/Plug-Ins/M1-Panner.aaxplugin" \
	               "$$HOME/Library/Application Support/Avid/Audio/Plug-Ins/M1-Monitor.aaxplugin" \
	               "$$HOME/Library/Application Support/Avid/Audio/Plug-Ins/M1-Panner.aaxplugin"; do \
		if [ -e "$$plugin" ]; then \
			echo "\nChecking: $$plugin"; \
			codesign -dv "$$plugin" 2>&1 | head -5; \
			echo "Valid signature: $$(codesign -v "$$plugin" 2>&1 && echo 'YES' || echo 'NO')"; \
			spctl -a -t install "$$plugin" 2>&1 | head -2; \
		fi \
	done
	@echo "\n--- PACE iLok Status ---"
	@if [ -d "/Applications/iLok License Manager.app" ]; then \
		echo "iLok License Manager: Installed"; \
		ps aux | grep -i ilok | grep -v grep | head -3 || echo "iLok daemon not running"; \
	else \
		echo "iLok License Manager: NOT INSTALLED"; \
	fi
	@echo "\n--- Gatekeeper & Quarantine ---"
	@for plugin in "/Library/Application Support/Avid/Audio/Plug-Ins/M1-Monitor.aaxplugin" \
	               "/Library/Application Support/Avid/Audio/Plug-Ins/M1-Panner.aaxplugin"; do \
		if [ -e "$$plugin" ]; then \
			echo "\nQuarantine attributes for $$plugin:"; \
			xattr -l "$$plugin" 2>/dev/null | grep "com.apple.quarantine" || echo "No quarantine flag"; \
		fi \
	done
	@echo "\n--- Recommendations ---"
	@echo "1. If plugins have quarantine flags, run: sudo xattr -rd com.apple.quarantine '/Library/Application Support/Avid/Audio/Plug-Ins/M1-*.aaxplugin'"
	@echo "2. Ensure iLok License Manager is installed and running"
	@echo "3. Verify PACE signing with: $(WRAPTOOL) verify --in <plugin.aaxplugin>"
	@echo "4. Check Pro Tools logs: ~/Library/Logs/Avid/"
	@echo "5. Try clearing Pro Tools cache: ~/Library/Caches/com.avid.*"
else ifeq ($(detected_OS),Windows)
	@echo "\n--- System Information ---"
	@systeminfo | findstr /C:"OS Name" /C:"OS Version"
	@echo "\n--- AAX Plugin Directories ---"
	@if exist "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\" ( \
		dir "$(ProgramFiles)\Common Files\Avid\Audio\Plug-Ins\M1-*.aaxplugin" /s /b 2>nul || echo "No Mach1 plugins found" \
	) else ( \
		echo "AAX plugin directory does not exist" \
	)
	@echo "\n--- PACE iLok Status ---"
	@if exist "$(ProgramFiles)\iLok License Manager\" ( \
		echo "iLok License Manager: Installed" \
	) else ( \
		echo "iLok License Manager: NOT INSTALLED" \
	)
	@echo "\n--- Recommendations ---"
	@echo "1. Ensure iLok License Manager is installed and running"
	@echo "2. Verify PACE signing with: $(WRAPTOOL) verify --in <plugin.aaxplugin>"
	@echo "3. Check Pro Tools logs in: %%APPDATA%%\Avid\"
	@echo "4. Run Pro Tools as Administrator once to register plugins"
endif
	@echo "\n=== End Diagnostic Report ==="

clean-pluginval:
ifeq ($(detected_OS),Darwin)
	rm -rf pluginval.app
else ifeq ($(detected_OS),Windows)
	del pluginval.exe
endif
	@echo "pluginval cleaned up"

installer-pkg:
ifeq ($(detected_OS),Darwin)
	@# Detect host architecture for naming
	@if [ "$$(uname -m)" = "arm64" ]; then \
		ARCH_SUFFIX="arm64"; \
	else \
		ARCH_SUFFIX="x86_64"; \
	fi; \
	echo "Building installer for $$ARCH_SUFFIX..."; \
	packagesbuild -v installer/osx/Mach1\ Spatial\ System\ Installer.pkgproj; \
	codesign --force --sign $(APPLE_CODESIGN_CODE) --timestamp installer/osx/build/Mach1\ Spatial\ System\ Installer.pkg; \
	mkdir -p installer/osx/build/signed; \
	productsign --sign $(APPLE_CODESIGN_INSTALLER_ID) \
		"installer/osx/build/Mach1 Spatial System Installer.pkg" \
		"installer/osx/build/signed/Mach1 Spatial System Installer.pkg"; \
	echo "Notarizing installer..."; \
	NOTARY_JSON=$$(mktemp); \
	if ! xcrun notarytool submit --wait --output-format json --keychain-profile 'notarize-app' \
		--apple-id $(APPLE_USERNAME) --password $(ALTOOL_APPPASS) --team-id $(APPLE_TEAM_CODE) \
		"installer/osx/build/signed/Mach1 Spatial System Installer.pkg" > "$$NOTARY_JSON" 2>&1; then \
		cat "$$NOTARY_JSON"; \
		rm -f "$$NOTARY_JSON"; \
		echo "Notarization did not complete successfully; skipping stapling."; \
		exit 1; \
	fi; \
	cat "$$NOTARY_JSON"; \
	NOTARY_STATUS=$$(/usr/bin/python3 -c 'import json,sys; print(json.load(open(sys.argv[1]))["status"])' "$$NOTARY_JSON"); \
	rm -f "$$NOTARY_JSON"; \
	if [ "$$NOTARY_STATUS" != "Accepted" ]; then \
		echo "Notarization status was $$NOTARY_STATUS; skipping stapling."; \
		exit 1; \
	fi; \
	xcrun stapler staple "installer/osx/build/signed/Mach1 Spatial System Installer.pkg"; \
	mv "installer/osx/build/signed/Mach1 Spatial System Installer.pkg" \
		"installer/osx/build/signed/Mach1 Spatial System Installer-$$ARCH_SUFFIX.pkg"; \
	echo ""; \
	echo "Installer created: installer/osx/build/signed/Mach1 Spatial System Installer-$$ARCH_SUFFIX.pkg"
else ifeq ($(detected_OS),Windows)
	@echo "Building Windows installer..."
	$(WIN_INNO_PATH) "${CURDIR}/installer/win/installer.iss"
	@echo "Signing Windows installer with Azure Trusted Signing..."
	@if exist "installer\win\Output\Mach1 Spatial System Installer.exe" ( \
		powershell -ExecutionPolicy Bypass -File installer\win\sign-file.ps1 -FilePath "installer\win\Output\Mach1 Spatial System Installer.exe" \
	) else ( \
		echo "ERROR: Installer not found at installer\win\Output\Mach1 Spatial System Installer.exe" && \
		exit 1 \
	)
	@echo "Windows installer built and signed"
endif

deploy-installer:
ifeq ($(detected_OS),Darwin)
	@echo "### DEPLOYING macOS INSTALLERS TO S3 ###"
	@current_version=$$(cat VERSION); \
	suggested_version=$$(find . -maxdepth 2 -name "VERSION" -not -path "./VERSION" -exec cat {} \; | sort -V | tail -1); \
	echo "Current central version: $$current_version"; \
	read -p "Version [$$suggested_version]: " version; \
	if [ -z "$$version" ]; then \
		version=$$suggested_version; \
	fi; \
	echo ""; \
	ARM64_PKG="installer/osx/build/signed/Mach1 Spatial System Installer-arm64.pkg"; \
	X86_PKG="installer/osx/build/signed/Mach1 Spatial System Installer-x86_64.pkg"; \
	UPLOADED=0; \
	if [ -f "$$ARM64_PKG" ]; then \
		echo "Uploading ARM64 (Apple Silicon) installer..."; \
		aws s3 cp "$$ARM64_PKG" \
			"s3://mach1-releases/$$version/Mach1 Spatial System Installer-arm64.pkg" \
			--profile mach1 \
			--content-disposition "Mach1 Spatial System Installer-arm64.pkg"; \
		UPLOADED=$$((UPLOADED + 1)); \
	else \
		echo "NOTE: ARM64 installer not found, skipping"; \
	fi; \
	if [ -f "$$X86_PKG" ]; then \
		echo "Uploading x86_64 (Intel) installer..."; \
		aws s3 cp "$$X86_PKG" \
			"s3://mach1-releases/$$version/Mach1 Spatial System Installer-x86_64.pkg" \
			--profile mach1 \
			--content-disposition "Mach1 Spatial System Installer-x86_64.pkg"; \
		UPLOADED=$$((UPLOADED + 1)); \
	else \
		echo "NOTE: x86_64 installer not found, skipping"; \
	fi; \
	if [ $$UPLOADED -eq 0 ]; then \
		echo "ERROR: No installers found. Run 'make package-from-ci VERSION=x.x' first."; \
		exit 1; \
	fi; \
	echo ""; \
	echo "Deployed $$UPLOADED installer(s) to s3://mach1-releases/$$version/"; \
	echo "REMINDER: Update the Avid Store Submission per version update!"
else ifeq ($(detected_OS),Windows)
	@echo "### DEPLOYING TO S3 ###"
	@if not exist "installer\win\Output\Mach1 Spatial System Installer.exe" ( \
		echo "Installer not found. Please run 'make installer-pkg' first." && \
		exit 1 \
	)
	@powershell -Command "$$current_version = Get-Content VERSION; $$rootPath = (Get-Location).Path; $$rootVersionPath = Join-Path $$rootPath 'VERSION'; $$allVersions = Get-ChildItem -Recurse -Filter 'VERSION'; $$component_versions = @(); foreach ($$file in $$allVersions) { if ($$file.FullName -ne $$rootVersionPath) { $$relDir = $$file.DirectoryName.Replace($$rootPath, '').TrimStart('\', '/'); if ($$relDir) { $$pathParts = $$relDir -split '[\\/]' | Where-Object { $$_ }; if ($$pathParts.Count -le 1) { $$component_versions += Get-Content $$file.FullName } } } }; $$suggested_version = $$component_versions | Sort-Object { [version]$$_ } | Select-Object -Last 1; Write-Host \"Current central version: $$current_version\"; Write-Host \"Newest component version: $$suggested_version\"; Write-Host \"Suggested version: $$suggested_version\"; $$version = Read-Host \"Version [$$suggested_version]\"; if ($$version -eq '') { $$version = $$suggested_version }; aws s3 cp 'installer\win\Output\Mach1 Spatial System Installer.exe' \"s3://mach1-releases/$$version/Mach1 Spatial System Installer.exe\" --profile mach1 --content-disposition \"Mach1 Spatial System Installer.exe\"; Write-Host \"Installer deployed to s3://mach1-releases/$$version/\"; Write-Host \"REMINDER: Update the Avid Store Submission per version update!\""
else
	@echo "Installer deployment is not supported on this platform"
endif