fixes

Author: jonmarkgo

functions/src/generate-sessions-speakers-schedule.ts

@@ -4,7 +4,7 @@ import { getFirestore } from 'firebase-admin/firestore';
 import * as functions from 'firebase-functions';
 import { sessionsSpeakersMap } from './schedule-generator/speakers-sessions-map.js';
 import { sessionsSpeakersScheduleMap } from './schedule-generator/speakers-sessions-schedule-map.js';
-import { isEmpty, ScheduleMap, SessionMap, snapshotToObject, SpeakerMap } from './utils.js';
+import { isEmpty, pickMainTag, ScheduleMap, SessionMap, snapshotToObject, SpeakerMap } from './utils.js';
 
 const isScheduleEnabled = async (): Promise<boolean> => {
   const doc = await getFirestore().collection('config').doc('schedule').get();
@@ -83,10 +83,21 @@ async function generateAndSaveData(changedSpeaker?) {
   }
 
   // Include all sessions (including past years not on current schedule)
-  // This ensures past talk pages are accessible via direct links
+  // Enrich with resolved speaker objects so session pages render correctly
   for (const [sessionId, session] of Object.entries(sessions)) {
     if (!generatedData.sessions[sessionId]) {
-      generatedData.sessions[sessionId] = { ...(session as object), id: sessionId };
+      const raw = session as { speakers?: string[]; tags?: string[]; [key: string]: unknown };
+      const resolvedSpeakers = (raw.speakers || []).map((speakerId: string) => ({
+        id: speakerId,
+        ...(speakers[speakerId] || {}),
+        sessions: null,
+      }));
+      generatedData.sessions[sessionId] = {
+        ...raw,
+        id: sessionId,
+        mainTag: pickMainTag(raw.tags),
+        speakers: resolvedSpeakers,
+      };
     }
   }
 

src/pages/session-page.ts

@@ -236,10 +236,10 @@ export class SessionPage extends ReduxMixin(PolymerElement) {
             on-click="toggleFeaturedSession"
           ></paper-fab>
         </div>
-        <h3 class="meta-info" hidden$="[[disabledSchedule]]">
+        <h3 class="meta-info" hidden$="[[_hideScheduleInfo(disabledSchedule, session.dateReadable)]]">
           [[session.dateReadable]], [[session.startTime]] - [[session.endTime]]
         </h3>
-        <h3 class="meta-info" hidden$="[[disabledSchedule]]">[[getTrackTitle(session.track, session.trackOverride)]]</h3>
+        <h3 class="meta-info" hidden$="[[_hideScheduleInfo(disabledSchedule, session.track)]]">[[getTrackTitle(session.track, session.trackOverride)]]</h3>
         <h3 class="meta-info" hidden$="[[!session.complexity]]">
           [[sessionDetails.contentLevel]]: [[session.complexity]]
         </h3>
@@ -459,4 +459,8 @@ export class SessionPage extends ReduxMixin(PolymerElement) {
   private speakerUrl(id: string) {
     return router.urlForName('speaker-page', { id });
   }
+
+  private _hideScheduleInfo(disabledSchedule: boolean, value: unknown) {
+    return disabledSchedule || !value;
+  }
 }