Skip to content

Commit eb1389d

Browse files
authored
libvncserver: add an explicit cast before shift
Shifting a signed integer can result in undefined behavior.
1 parent da8cdea commit eb1389d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

libvncserver/tableinittctemplate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ rfbInitOneRGBTableOUT (OUT_T *table, int inMax, int outMax, int outShift,
126126
int nEntries = inMax + 1;
127127

128128
for (i = 0; i < nEntries; i++) {
129-
table[i] = ((i * outMax + inMax / 2) / inMax) << outShift;
129+
table[i] = ((OUT_T)((i * outMax + inMax / 2) / inMax)) << outShift;
130130
#if (OUT != 8)
131131
if (swap) {
132132
table[i] = SwapOUT(table[i]);

0 commit comments

Comments
 (0)