test: fix offset used before range check

szsam · web-flow · commit b038c7dfe4c6 · 2023-05-20T12:03:21.000+02:00
This use of offset 'i' should follow the range check.
diff --git a/test/tjbench.c b/test/tjbench.c
@@ -586,7 +586,7 @@ int main(int argc, char *argv[])
 			if(!strcasecmp(argv[i], "-bottomup")) flags|=TJFLAG_BOTTOMUP;
 			if(!strcasecmp(argv[i], "-quiet")) quiet=1;
 			if(!strcasecmp(argv[i], "-qq")) quiet=2;
-			if(!strcasecmp(argv[i], "-scale") && i<argc-1)
+			if(i<argc-1 && !strcasecmp(argv[i], "-scale"))
 			{
 				int temp1=0, temp2=0, match=0;
 				if(sscanf(argv[++i], "%d/%d", &temp1, &temp2)==2)

Original file line number	Diff line number	Diff line change
`@@ -586,7 +586,7 @@ int main(int argc, char *argv[])`
`586`	`586`	`if(!strcasecmp(argv[i], "-bottomup")) flags\|=TJFLAG_BOTTOMUP;`
`587`	`587`	`if(!strcasecmp(argv[i], "-quiet")) quiet=1;`
`588`	`588`	`if(!strcasecmp(argv[i], "-qq")) quiet=2;`
`589`		`- if(!strcasecmp(argv[i], "-scale") && i<argc-1)`
	`589`	`+ if(i<argc-1 && !strcasecmp(argv[i], "-scale"))`
`590`	`590`	`{`
`591`	`591`	`int temp1=0, temp2=0, match=0;`
`592`	`592`	`if(sscanf(argv[++i], "%d/%d", &temp1, &temp2)==2)`