libvncserver: detach client thread before ending it

Before, we were joining the thread in rfbShutdownServer(), which
cleaned up after its resources in that case, but there was no cleanup
when a client disconnected on its own, as noted in #570.

Closes #570.

Builds upon and closes #574.

Author: bk138

src/libvncserver/main.c

@@ -610,6 +610,10 @@ clientInput(void *data)
 
     rfbClientConnectionGone(cl);
 
+    /* We can't reliably join this thread, so detach it here
+       so the associated memory will be freed by the OS. */
+    THREAD_DETACH(cl->client_thread);
+
     return THREAD_ROUTINE_RETURN_VALUE;
 }
 
@@ -1204,10 +1208,7 @@ void rfbShutdownServer(rfbScreenInfoPtr screen,rfbBool disconnectClients) {
       }
 
 #ifdef LIBVNCSERVER_HAVE_LIBPTHREAD
-    if(currentCl->screen->backgroundLoop) {
-      /* Wait for threads to finish. The thread has already been pipe-notified by rfbCloseClient() */
-      pthread_join(currentCl->client_thread, NULL);
-    } else {
+    if(!currentCl->screen->backgroundLoop) {
       /*
 	In threaded mode, rfbClientConnectionGone() is called by the client-to-server thread.
 	Only need to call this here for non-threaded mode.