Skip to content

Commit 2a23c44

Browse files
yan12125bk138
authored andcommitted
libvncclient: improve compatibility with GnuTLS 3.8
Since GnuTLS 3.8, TTLS-SRP is disabled by default at compile time [1]. As a result, connecting to a server via TLS fails with: > Warning: Failed to set TLS priority: The request is invalid. (+SRP). > TLS handshake failed: No or insufficient priorities were set. On the other hand, TLS-SRP is apparently unused in libvncclient. It seems TLS-SRP requires providing serveral parameters, including a username and a password, via specific GnuTLS API [2], which I didn't find in the codebase. [1] https://gitlab.com/gnutls/gnutls/-/merge_requests/1681 [2] https://www.gnutls.org/manual/html_node/Authentication-using-SRP.html
1 parent 27617e1 commit 2a23c44

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/libvncclient/tls_gnutls.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
#include "tls.h"
2626

2727

28-
static const char *rfbTLSPriority = "NORMAL:+DHE-DSS:+RSA:+DHE-RSA:+SRP";
28+
static const char *rfbTLSPriority = "NORMAL:+DHE-DSS:+RSA:+DHE-RSA";
2929
static const char *rfbAnonTLSPriority = "NORMAL:+ANON-ECDH:+ANON-DH";
3030

3131
#define DH_BITS 1024

0 commit comments

Comments
 (0)