added comments and minor changes

Author: markelov208

applications/GeoMechanicsApplication/custom_constitutive/plane_strain.cpp

@@ -20,11 +20,12 @@ namespace Kratos
 
 Matrix PlaneStrain::CalculateElasticConstitutiveTensor(const Properties& rProperties) const
 {
+    // next lines shall be replaced with lines from the prototype when GEO_DRAINAGE_TYPE is merged.
     constexpr auto undrained = false;
-    const double   nu = undrained ? ConstitutiveLawUtilities::GetUndrainedPoissonsRatio(rProperties)
+    const auto     nu = undrained ? ConstitutiveLawUtilities::GetUndrainedPoissonsRatio(rProperties)
                                   : rProperties[POISSON_RATIO];
-    const double E = undrained ? ConstitutiveLawUtilities::GetUndrainedYoungsModulus(rProperties, nu)
-                               : rProperties[YOUNG_MODULUS];
+    const auto E = undrained ? ConstitutiveLawUtilities::GetUndrainedYoungsModulus(rProperties, nu)
+                             : rProperties[YOUNG_MODULUS];
 
     return ConstitutiveLawUtilities::MakeContinuumConstitutiveTensor(
         E, nu, PlaneStrain::GetStrainSize(), PlaneStrain::GetNumberOfNormalComponents());

applications/GeoMechanicsApplication/custom_constitutive/three_dimensional.cpp

@@ -21,12 +21,12 @@ namespace Kratos
 
 Matrix ThreeDimensional::CalculateElasticConstitutiveTensor(const Properties& rProperties) const
 {
+    // next lines shall be replaced with lines from the prototype when GEO_DRAINAGE_TYPE is merged.
     constexpr auto undrained = false;
-
-    const double nu = undrained ? ConstitutiveLawUtilities::GetUndrainedPoissonsRatio(rProperties)
-                                : rProperties[POISSON_RATIO];
-    const double E = undrained ? ConstitutiveLawUtilities::GetUndrainedYoungsModulus(rProperties, nu)
-                               : rProperties[YOUNG_MODULUS];
+    const auto     nu = undrained ? ConstitutiveLawUtilities::GetUndrainedPoissonsRatio(rProperties)
+                                  : rProperties[POISSON_RATIO];
+    const auto E = undrained ? ConstitutiveLawUtilities::GetUndrainedYoungsModulus(rProperties, nu)
+                             : rProperties[YOUNG_MODULUS];
 
     return ConstitutiveLawUtilities::MakeContinuumConstitutiveTensor(
         E, nu, ThreeDimensional::GetStrainSize(), ThreeDimensional::GetNumberOfNormalComponents());

applications/GeoMechanicsApplication/custom_utilities/constitutive_law_utilities.cpp

@@ -231,12 +231,11 @@ double ConstitutiveLawUtilities::GetSkemptonB(const Properties& rProperties)
     KRATOS_ERROR_IF(denominator <= std::numeric_limits<double>::epsilon())
         << "Non-physical values: denominator < epsilon." << std::endl;
 
-    auto result = biot_coefficient / denominator;
+    const auto result = biot_coefficient / denominator;
     KRATOS_ERROR_IF(result < -std::numeric_limits<double>::epsilon() || result > 1.0 + std::numeric_limits<double>::epsilon())
         << "Calculated Skempton B (" << result << ") is out of range [0,1]." << std::endl;
 
-    result = std::max(0.0, std::min(1.0, result));
-    return result;
+    return std::max(0.0, std::min(1.0, result));
 }
 
 Matrix ConstitutiveLawUtilities::MakeContinuumConstitutiveTensor(double      YoungsModulus,