Skip to content

Commit 86a70e5

Browse files
authored
Also handle test dep incompat
1 parent 2bd1ef3 commit 86a70e5

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

.github/workflows/IntegrationTestChainRules.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,15 @@ jobs:
4141
using Pkg
4242
try
4343
# force it to use this PR's version of the package
44-
Pkg.develop(PackageSpec(path="."))
44+
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
4545
Pkg.update()
46+
Pkg.test() # resolver may fail with test time deps
4647
catch err
4748
err isa Pkg.Resolve.ResolverError || rethrow()
4849
# If we can't resolve that means this is incompatible by SemVer and this is fine
4950
# It means we marked this as a breaking change, so we don't need to worry about
5051
# Mistakenly introducing a breaking change, as we have intentionally made one
5152
52-
# Note: this doesn't solve all resolver errors, e.g. might be a mutual dependency
53-
# of this package and a test only dependency of the downstream packagem that are
54-
# incompatible. And this check only catches resolution failures with main dependencies
55-
# (plus this package itself) with this package
56-
5753
@info "Not compatible with this release. No problem." exception=err
5854
exit(0) # Exit immediately, as a success
5955
end
60-
Pkg.test()

0 commit comments

Comments
 (0)