Skip to content

Commit 52ddad9

Browse files
authored
Merge pull request #2289 from IntelPython/use-simplified-python-constructors
Update empty Python data structure constructors
2 parents 8b3f66e + eb92918 commit 52ddad9

12 files changed

Lines changed: 18 additions & 18 deletions

docs/doc_sources/conf.py.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,14 +134,14 @@ if generate_multiversion == "ON":
134134
try:
135135
html_context
136136
except NameError:
137-
html_context = dict()
137+
html_context = {}
138138
html_context["display_lower_left"] = True
139139
templates_path = ["_templates"]
140140
html_context["current_version"] = release
141141
html_context["version"] = version
142142

143143
# POPULATE LINKS TO OTHER VERSIONS
144-
html_context["versions"] = list()
144+
html_context["versions"] = []
145145

146146
# Populate the list of documented versions from the doc_versions.txt
147147
versions = []

dpctl/_sycl_device.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,7 @@ cdef class SyclDevice(_SyclDevice):
12101210
sg_sizes = DPCTLDevice_GetSubGroupSizes(
12111211
self._device_ref, &sg_sizes_len)
12121212
if (sg_sizes is not NULL and sg_sizes_len > 0):
1213-
res = list()
1213+
res = []
12141214
for i in range(sg_sizes_len):
12151215
res.append(sg_sizes[i])
12161216
DPCTLSize_t_Array_Delete(sg_sizes)

dpctl/_sycl_device_factory.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ cdef class _DefaultDeviceCache:
416416
cdef dict __device_map__
417417

418418
def __cinit__(self):
419-
self.__device_map__ = dict()
419+
self.__device_map__ = {}
420420

421421
cdef get_or_create(self):
422422
"""Return instance of SyclDevice and indicator if cache

dpctl/_sycl_queue_manager.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ cdef class _DeviceDefaultQueueCache:
3535
cdef dict __device_queue_map__
3636

3737
def __cinit__(self):
38-
self.__device_queue_map__ = dict()
38+
self.__device_queue_map__ = {}
3939

4040
def get_or_create(self, key):
4141
"""Return instance of SyclQueue and indicator if cache

dpctl/_sycl_timer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def __init__(
190190
self.queue = None
191191
self.host_times = []
192192
self.bracketing_events = []
193-
self._context_data = list()
193+
self._context_data = []
194194
if device_timer is None:
195195
device_timer = "queue_barrier"
196196
if device_timer == "queue_barrier":

dpctl/tests/helper/_helper.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def create_invalid_capsule():
4343
return ctor(id(ctor), b"invalid", 0)
4444

4545

46-
def get_queue_or_skip(args=tuple()):
46+
def get_queue_or_skip(args=()):
4747
try:
4848
q = dpctl.SyclQueue(*args)
4949
except dpctl.SyclQueueCreationError:

dpctl/tests/test_sycl_device.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ def test_peer_device_arg_validation(method):
405405
dev = dpctl.SyclDevice()
406406
except dpctl.SyclDeviceCreationError:
407407
pytest.skip("No default device available")
408-
bad_dev = dict()
408+
bad_dev = {}
409409
callable = getattr(dev, method)
410410
with pytest.raises(TypeError):
411411
callable(bad_dev)

dpctl/tests/test_sycl_event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def test_create_event_from_capsule():
7070

7171
def test_invalid_constructor_arg():
7272
with pytest.raises(TypeError):
73-
dpctl.SyclEvent(list())
73+
dpctl.SyclEvent([])
7474

7575

7676
def test_wait_with_event():

dpctl/tests/test_sycl_queue.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def test_queue_invalid_property():
209209
with pytest.raises(ValueError):
210210
dpctl.SyclQueue(property=4.5)
211211
with pytest.raises(ValueError):
212-
dpctl.SyclQueue(property=["abc", tuple()])
212+
dpctl.SyclQueue(property=["abc", ()])
213213

214214

215215
def test_queue_capsule():
@@ -345,13 +345,13 @@ def test_queue_memops():
345345
q.prefetch(m1, 512)
346346
q.mem_advise(m1, 512, 0)
347347
with pytest.raises(TypeError):
348-
q.memcpy(m1, list(), 512)
348+
q.memcpy(m1, [], 512)
349349
with pytest.raises(TypeError):
350-
q.memcpy(list(), m2, 512)
350+
q.memcpy([], m2, 512)
351351
with pytest.raises(TypeError):
352-
q.prefetch(list(), 512)
352+
q.prefetch([], 512)
353353
with pytest.raises(TypeError):
354-
q.mem_advise(list(), 512, 0)
354+
q.mem_advise([], 512, 0)
355355

356356

357357
@pytest.fixture(scope="session")

dpctl/tests/test_sycl_usm.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ def test_usm_type_exceptions():
265265
with pytest.raises(TypeError):
266266
m.get_usm_type(syclobj=Ellipsis)
267267
with pytest.raises(TypeError):
268-
m.get_usm_type_enum(syclobj=list())
268+
m.get_usm_type_enum(syclobj=[])
269269

270270

271271
def test_sycl_usm_array_interface(memory_ctor):
@@ -419,7 +419,7 @@ def invalid_version(suai_iface):
419419
# data validation
420420
def invalid_data(suai_iface):
421421
"Set data to invalid"
422-
suai_iface["data"] = tuple()
422+
suai_iface["data"] = ()
423423
return suai_iface
424424

425425
v = View(

0 commit comments

Comments
 (0)