Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Commit 66cd0e6

Browse files
charlesccychenaaltay
authored andcommitted
Rename OutputTimeFn.OUTPUT_AT_MAX to OUTPUT_AT_LATEST for clarity
----Release Notes---- [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=117973512
1 parent eb4f582 commit 66cd0e6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

google/cloud/dataflow/transforms/trigger_transcripts.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ transcript:
4141
name: output_time_fn_latest
4242
window_fn: FixedWindows(10)
4343
trigger_fn: Default
44-
output_time_fn: OUTPUT_AT_MAX
44+
output_time_fn: OUTPUT_AT_LATEST
4545
transcript:
4646
- input: [1, 2, 3, 10, 11, 25]
4747
- watermark: 100

google/cloud/dataflow/transforms/window.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class OutputTimeFn(object):
6060

6161
OUTPUT_AT_EOW = 'OUTPUT_AT_EOW'
6262
OUTPUT_AT_EARLIEST = 'OUTPUT_AT_EARLIEST'
63-
OUTPUT_AT_MAX = 'OUTPUT_AT_MAX'
63+
OUTPUT_AT_LATEST = 'OUTPUT_AT_LATEST'
6464
OUTPUT_AT_EARLIEST_TRANSFORMED = 'OUTPUT_AT_EARLIEST_TRANSFORMED'
6565

6666
@staticmethod
@@ -69,7 +69,7 @@ def get_impl(output_time_fn, window_fn):
6969
return timeutil.OutputAtEndOfWindowImpl()
7070
elif output_time_fn == OutputTimeFn.OUTPUT_AT_EARLIEST:
7171
return timeutil.OutputAtEarliestInputTimestampImpl()
72-
elif output_time_fn == OutputTimeFn.OUTPUT_AT_MAX:
72+
elif output_time_fn == OutputTimeFn.OUTPUT_AT_LATEST:
7373
return timeutil.OutputAtLatestInputTimestampImpl()
7474
elif output_time_fn == OutputTimeFn.OUTPUT_AT_EARLIEST_TRANSFORMED:
7575
return timeutil.OutputAtEarliestTransformedInputTimestampImpl(window_fn)

0 commit comments

Comments
 (0)