chore: update tests following switch to sinon

Author: GabrielCousin

src/lib/authentication.ts

@@ -7,7 +7,8 @@ import {
   WebviewView,
   workspace,
 } from "vscode";
-import { spawn, SpawnOptionsWithoutStdio } from "child_process";
+import { SpawnOptionsWithoutStdio } from "child_process";
+import { childProcess } from "./child-process";
 import * as os from "os";
 import {
   StatusBarStatus,
@@ -137,7 +138,7 @@ export async function loginGGShield(
   }
 
   return new Promise<void>((resolve, reject) => {
-    const proc = spawn(ggshieldPath, args, options);
+    const proc = childProcess.spawn(ggshieldPath, args, options);
 
     proc.stdout.on("data", (data) => {
       const urlLine = data.toString().match(/https:\/\/[^\s]+/);

src/lib/child-process.ts

@@ -0,0 +1,16 @@
+import * as cp from "child_process";
+
+// Plain object wrapper so tests can stub these with Sinon.
+// Node.js 22+ makes built-in module properties non-configurable,
+// which prevents sinon.stub(childProcess, "spawnSync") from working.
+export const childProcess = {
+  spawnSync: cp.spawnSync.bind(cp),
+  spawn: cp.spawn.bind(cp),
+};
+
+export type {
+  ChildProcessWithoutNullStreams,
+  SpawnOptionsWithoutStdio,
+  SpawnSyncOptionsWithStringEncoding,
+  SpawnSyncReturns,
+} from "child_process";

src/lib/run-ggshield.ts

@@ -1,8 +1,8 @@
 import {
-  spawnSync,
-  SpawnSyncOptionsWithStringEncoding,
-  SpawnSyncReturns,
-} from "child_process";
+  type SpawnSyncOptionsWithStringEncoding,
+  type SpawnSyncReturns,
+  childProcess,
+} from "./child-process";
 import { GGShieldConfiguration } from "./ggshield-configuration";
 import { workspace } from "vscode";
 
@@ -58,7 +58,11 @@ export function runGGShieldCommand(
     };
   }
 
-  const proc = spawnSync(configuration.ggshieldPath, args, options);
+  const proc = childProcess.spawnSync(
+    configuration.ggshieldPath,
+    args,
+    options,
+  );
 
   return proc;
 }

src/test/suite/lib/authentication.test.ts

@@ -1,8 +1,10 @@
 import { GGShieldConfiguration } from "../../../lib/ggshield-configuration";
 import * as sinon from "sinon";
 import * as runGGShield from "../../../lib/run-ggshield";
-import * as childProcess from "child_process";
-import { ChildProcessWithoutNullStreams } from "child_process";
+import {
+  childProcess,
+  type ChildProcessWithoutNullStreams,
+} from "../../../lib/child-process";
 import * as statusBar from "../../../gitguardian-interface/gitguardian-status-bar";
 import assert from "assert";
 import { EventEmitter } from "events";

src/test/suite/lib/run-ggshield.test.ts

@@ -1,5 +1,5 @@
 import * as sinon from "sinon";
-import * as childProcess from "child_process";
+import { childProcess } from "../../../lib/child-process";
 import * as vscode from "vscode";
 import * as runGGShield from "../../../lib/run-ggshield";
 import assert from "assert";

src/utils.ts

@@ -1,9 +1,9 @@
 import * as vscode from "vscode";
-import { spawnSync } from "child_process";
+import { childProcess } from "./lib/child-process";
 import * as path from "path";
 
 export function checkGitInstalled(): boolean {
-  const proc = spawnSync("git", ["--version"]);
+  const proc = childProcess.spawnSync("git", ["--version"]);
   const success = proc.status === 0;
   if (!success) {
     vscode.window.showErrorMessage(
@@ -15,7 +15,7 @@ export function checkGitInstalled(): boolean {
 
 // Since git is required to use ggshield, we know that it is installed
 export function isFileGitignored(filePath: string): boolean {
-  const proc = spawnSync("git", ["check-ignore", filePath], {
+  const proc = childProcess.spawnSync("git", ["check-ignore", filePath], {
     cwd: path.dirname(filePath),
   });
   return proc.status === 0;