Skip to content

Commit 1ba6d9d

Browse files
committed
fix: pass httpx.Client args directly to satisfy ty type checker
Avoid **dict unpacking which ty cannot type-check. Made-with: Cursor
1 parent aecc0ce commit 1ba6d9d

1 file changed

Lines changed: 28 additions & 16 deletions

File tree

getstream/base.py

Lines changed: 28 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -173,16 +173,22 @@ def __init__(
173173
self.client = http_client
174174
self._owns_http_client = False
175175
else:
176-
client_kwargs = dict(
177-
base_url=self.base_url or "",
178-
headers=self.headers,
179-
params=self.params,
180-
timeout=httpx.Timeout(self.timeout),
181-
)
182176
transport = getattr(self, "_transport", None)
183177
if transport is not None:
184-
client_kwargs["transport"] = transport
185-
self.client = httpx.Client(**client_kwargs)
178+
self.client = httpx.Client(
179+
base_url=self.base_url or "",
180+
headers=self.headers,
181+
params=self.params,
182+
timeout=httpx.Timeout(self.timeout),
183+
transport=transport,
184+
)
185+
else:
186+
self.client = httpx.Client(
187+
base_url=self.base_url or "",
188+
headers=self.headers,
189+
params=self.params,
190+
timeout=httpx.Timeout(self.timeout),
191+
)
186192
self._owns_http_client = True
187193

188194
def __enter__(self):
@@ -408,16 +414,22 @@ def __init__(
408414
self.client = http_client
409415
self._owns_http_client = False
410416
else:
411-
client_kwargs = dict(
412-
base_url=self.base_url or "",
413-
headers=self.headers,
414-
params=self.params,
415-
timeout=httpx.Timeout(self.timeout),
416-
)
417417
transport = getattr(self, "_transport", None)
418418
if transport is not None:
419-
client_kwargs["transport"] = transport
420-
self.client = httpx.AsyncClient(**client_kwargs)
419+
self.client = httpx.AsyncClient(
420+
base_url=self.base_url or "",
421+
headers=self.headers,
422+
params=self.params,
423+
timeout=httpx.Timeout(self.timeout),
424+
transport=transport,
425+
)
426+
else:
427+
self.client = httpx.AsyncClient(
428+
base_url=self.base_url or "",
429+
headers=self.headers,
430+
params=self.params,
431+
timeout=httpx.Timeout(self.timeout),
432+
)
421433
self._owns_http_client = True
422434

423435
async def __aenter__(self):

0 commit comments

Comments
 (0)