Skip to content

Commit 32e7327

Browse files
Marty Heaveygerrit-scoped@luci-project-accounts.iam.gserviceaccount.com
authored andcommitted
upload: Clarify partial sync message on hook failure
Demote the partial sync warning from error to info and rephrase it to be a tip rather than an error. This prevents users from thinking that a partial sync is the cause of their hook failures when it is often a linting failure. The message now suggests that a full sync might help if there are cross-project dependencies, instead of implying it will fix any issue. Change-Id: I5d8c52b53ac315aa9f145ed069798bf201fa0815 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/574262 Tested-by: Marty Heavey <mheavey@google.com> Commit-Queue: Marty Heavey <mheavey@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com>
1 parent 4f707ff commit 32e7327

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

subcmds/upload.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -803,9 +803,10 @@ def _ProcessResults(_pool, _out, results):
803803
project_list=pending_proj_names, worktree_list=pending_worktrees
804804
):
805805
if LocalSyncState(manifest).IsPartiallySynced():
806-
logger.error(
807-
"Partially synced tree detected. Syncing all projects "
808-
"may resolve issues you're seeing."
806+
logger.info(
807+
"Tip: A partially synced tree was detected. "
808+
"If this failure involves cross-project dependencies, "
809+
"a full `repo sync` might help."
809810
)
810811
ret = 1
811812
if ret:

0 commit comments

Comments
 (0)