Improve NRT annotations and update Foundatio to 13.0.0-beta6.2

- Add [DisallowNull] to collection/connection string options properties

- Use null! for poison message queue entry creation with explicit comment

Author: niemyjski

src/Foundatio.AWS/Foundatio.AWS.csproj

@@ -9,7 +9,7 @@
     <PackageReference Include="AWSSDK.SimpleNotificationService" Version="4.0.2.27" />
     <PackageReference Include="AWSSDK.SQS" Version="4.0.2.25" />
 
-    <PackageReference Include="Foundatio" Version="13.0.0-beta6" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
+    <PackageReference Include="Foundatio" Version="13.0.0-beta6.2" Condition="'$(ReferenceFoundatioSource)' == '' OR '$(ReferenceFoundatioSource)' == 'false'" />
     <ProjectReference Include="..\..\..\Foundatio\src\Foundatio\Foundatio.csproj" Condition="'$(ReferenceFoundatioSource)' == 'true'" />
   </ItemGroup>
 </Project>

src/Foundatio.AWS/Messaging/SQSMessageBusOptions.cs

@@ -90,10 +90,9 @@ public class SQSMessageBusOptionsBuilder : SharedMessageBusOptionsBuilder<SQSMes
     /// <summary>
     /// Sets the connection string containing AWS credentials and configuration.
     /// </summary>
-    public SQSMessageBusOptionsBuilder ConnectionString(string connectionString)
+    public SQSMessageBusOptionsBuilder ConnectionString(string? connectionString)
     {
-        ArgumentException.ThrowIfNullOrWhiteSpace(connectionString);
-        Target.ConnectionString = connectionString;
+        Target.ConnectionString = String.IsNullOrWhiteSpace(connectionString) ? null : connectionString;
         return this;
     }
 

src/Foundatio.AWS/Queues/SQSQueue.cs

@@ -213,7 +213,8 @@ Task<ReceiveMessageResponse> ReceiveMessageAsync()
             _logger.LogWarning(deserializeException, "Error deserializing message {MessageId} (receive count {ReceiveCount}), abandoning for retry",
                 message.MessageId, message.ApproximateReceiveCount());
 
-            var poisonEntry = new SQSQueueEntry<T>(message, null, this);
+            // Poison message: null! is intentional — deserialization failed, entry is immediately abandoned.
+            var poisonEntry = new SQSQueueEntry<T>(message, null!, this);
             await AbandonAsync(poisonEntry).AnyContext();
             return null;
         }

src/Foundatio.AWS/Queues/SQSQueueEntry.cs

@@ -8,7 +8,7 @@ public class SQSQueueEntry<T>
 {
     public Message UnderlyingMessage { get; }
 
-    public SQSQueueEntry(Message message, T? value, IQueue<T> queue)
+    public SQSQueueEntry(Message message, T value, IQueue<T> queue)
         : base(message.MessageId, message.CorrelationId(), value, queue, message.SentTimestamp(), message.ApproximateReceiveCount())
     {
         if (message.MessageAttributes is not null)

src/Foundatio.AWS/Queues/SQSQueueOptions.cs

@@ -28,11 +28,9 @@ public class SQSQueueOptions<T> : SharedQueueOptions<T> where T : class
 
 public class SQSQueueOptionsBuilder<T> : SharedQueueOptionsBuilder<T, SQSQueueOptions<T>, SQSQueueOptionsBuilder<T>> where T : class
 {
-    public SQSQueueOptionsBuilder<T> ConnectionString(string connectionString)
+    public SQSQueueOptionsBuilder<T> ConnectionString(string? connectionString)
     {
-        if (string.IsNullOrEmpty(connectionString))
-            throw new ArgumentNullException(nameof(connectionString));
-        Target.ConnectionString = connectionString;
+        Target.ConnectionString = string.IsNullOrEmpty(connectionString) ? null : connectionString;
         return this;
     }
 

src/Foundatio.AWS/Storage/S3FileStorageOptions.cs

@@ -20,11 +20,9 @@ public class S3FileStorageOptions : SharedOptions
 
 public class S3FileStorageOptionsBuilder : SharedOptionsBuilder<S3FileStorageOptions, S3FileStorageOptionsBuilder>
 {
-    public S3FileStorageOptionsBuilder ConnectionString(string connectionString)
+    public S3FileStorageOptionsBuilder ConnectionString(string? connectionString)
     {
-        if (String.IsNullOrEmpty(connectionString))
-            throw new ArgumentNullException(nameof(connectionString));
-        Target.ConnectionString = connectionString;
+        Target.ConnectionString = String.IsNullOrEmpty(connectionString) ? null : connectionString;
         return this;
     }