Clean up a bunch of stuff

Author: wjohnstondrip

.rubocop.yml

@@ -19,3 +19,6 @@ Style/BracesAroundHashParameters:
 
 Layout/AccessModifierIndentation:
   EnforcedStyle: outdent
+
+Metrics/LineLength:
+  Enabled: false

.rubocop_todo.yml

@@ -6,50 +6,12 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented, indented_relative_to_receiver
-Layout/MultilineMethodCallIndentation:
-  Exclude:
-    - 'lib/drip/collection.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideHashLiteralBraces:
-  Exclude:
-    - 'test/drip/client_test.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-Layout/Tab:
-  Exclude:
-    - 'lib/drip/client/orders.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/drip/client/orders.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 Lint/ScriptPermission:
   Exclude:
     - 'Rakefile'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'lib/drip/response.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
@@ -142,17 +104,3 @@ Style/NumericLiterals:
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiteralsInInterpolation:
-  Exclude:
-    - 'test/drip/client_test.rb'
-
-# Offense count: 102
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 126

lib/drip/client/orders.rb

@@ -27,12 +27,12 @@ def create_or_update_orders(orders)
       # Public: Create or update a refund.
       #
       # options      - Required. A Hash of refund properties
-      #                 amount	            - Required. The amount of the refund.
+      #                 amount              - Required. The amount of the refund.
       #                 provider            - Required. The provider for the Order being refunded.
       #                 order_upstream_id   - Required. The upstream_id for the Order being refunded.
-      #                 upstream_id	        - The unique id of refund in the order management system.
-      #                 note	              - A note about the refund.
-      #                 processed_at        - The String time at which the refund was processed in 
+      #                 upstream_id         - The unique id of refund in the order management system.
+      #                 note                - A note about the refund.
+      #                 processed_at        - The String time at which the refund was processed in
       #                                       ISO-8601 format.
       #
       # Returns a Drip::Response.

lib/drip/collection.rb

@@ -19,7 +19,7 @@ def self.resource_name
 
     def item_class
       @item_class ||= Drip::Resources.
-        find_class(self.class.resource_name)
+                      find_class(self.class.resource_name)
     end
 
     def parse_items

lib/drip/response.rb

@@ -65,7 +65,7 @@ def parse_members
 
     def member_map
       @member_map ||= {}.tap do |map|
-        members.each { |key, value| map[key.to_sym] = key }
+        members.each { |key, _value| map[key.to_sym] = key }
       end
     end
   end

test/drip/client_test.rb

@@ -79,7 +79,7 @@ class Drip::ClientTest < Drip::TestCase
 
       @client.get("testpath")
 
-      header = "Basic #{Base64.encode64(@key + ":")}".strip
+      header = "Basic #{Base64.encode64(@key + ':')}".strip
       assert_requested :get, "https://api.getdrip.com/v2/testpath", headers: { 'Authorization' => header }
     end
   end
@@ -127,7 +127,7 @@ class Drip::ClientTest < Drip::TestCase
 
     should "follow redirect" do
       stub_request(:get, "https://api.getdrip.com/v2/testpath").
-        to_return(status: 301, body: "", headers: {"Location" => "https://api.example.com/mytestpath"})
+        to_return(status: 301, body: "", headers: { "Location" => "https://api.example.com/mytestpath" })
       stub_request(:get, "https://api.example.com/mytestpath").
         to_return(status: 200, body: "mybody")
       response = @client.get("testpath")
@@ -138,9 +138,9 @@ class Drip::ClientTest < Drip::TestCase
 
     should "not follow too many redirects" do
       stub_request(:get, "https://api.getdrip.com/v2/testpath").
-        to_return(status: 301, body: "", headers: {"Location" => "https://api.example.com/mytestpath"})
+        to_return(status: 301, body: "", headers: { "Location" => "https://api.example.com/mytestpath" })
       stub_request(:get, "https://api.example.com/mytestpath").
-        to_return(status: 302, body: "", headers: {"Location" => "https://api.getdrip.com/v2/testpath"})
+        to_return(status: 302, body: "", headers: { "Location" => "https://api.getdrip.com/v2/testpath" })
       assert_raises(Drip::TooManyRedirectsError) { @client.get("testpath") }
       assert_requested :get, "https://api.getdrip.com/v2/testpath", times: 5
       assert_requested :get, "https://api.example.com/mytestpath", times: 5