Correct refund method

Author: samudary

README.md

@@ -126,7 +126,7 @@ as methods on the client object. The following methods are currently available:
 | :------------------------- | :--------------------------------------------------- |
 | Create or update an order  | `#create_or_update_order(email, options = {})`       |
 | Create or update a batch of orders  | `#create_or_update_orders(orders = {})`     |
-| Create or update a refund  | `#create_or_update_refund(order_id, amount, options = {})` |
+| Create or update a refund  | `#create_or_update_refund(options = {})`             |
 
 #### Subscribers
 

lib/drip/client/orders.rb

@@ -26,19 +26,19 @@ def create_or_update_orders(orders)
 
       # Public: Create or update a refund.
       #
-      # order_id     - Required. The String id of the order.
-      # amount	     - Required. The amount of the refund.
-      # options      - Optional. A Hash of refund properties
-      #                 upstream_id	 - The unique id of refund in the order management system.
-      #                 note	       - A note about the refund.
-      #                 processed_at - The String time at which the refund was processed in 
-      #                                ISO-8601 format.
+      # options      - Required. A Hash of refund properties
+      #                 amount	            - Required. The amount of the refund.
+      #                 provider            - Required. The provider for the Order being refunded.
+      #                 order_upstream_id   - Required. The upstream_id for the Order being refunded.
+      #                 upstream_id	        - The unique id of refund in the order management system.
+      #                 note	              - A note about the refund.
+      #                 processed_at        - The String time at which the refund was processed in 
+      #                                       ISO-8601 format.
       #
       # Returns a Drip::Response.
       # See https://developer.drip.com/#create-or-update-a-refund
-      def create_or_update_refund(order_id, amount, options)
-        data = options.merge(amount: amount)
-        post "#{account_id}/orders/#{order_id}/refunds", generate_resource("refunds", data)
+      def create_or_update_refund(options)
+        post "#{account_id}/refunds", generate_resource("refunds", options)
       end
     end
   end

test/drip/client/orders_test.rb

@@ -94,10 +94,10 @@ def setup
 
   context "#create_or_update_refund" do
     setup do
-      @amount = 4900
-      @order_id = "98457h"
       @options = {
-        "amount": @amount,
+        "provider": "shopify",
+        "order_upstream_id": "abcdef",
+        "amount": 4900,
         "upstream_id": "tuvwx",
         "note": "Incorrect size",
         "processed_at": "2013-06-22T10:41:11Z"
@@ -107,14 +107,14 @@ def setup
       @response_status = 202
       @response_body = stub
 
-      @stubs.post "12345/orders/#{@order_id}/refunds", @payload do
+      @stubs.post "12345/refunds", @payload do
         [@response_status, {}, @response_body]
       end
     end
 
     should "send the correct request" do
       expected = Drip::Response.new(@response_status, @response_body)
-      assert_equal expected, @client.create_or_update_refund(@order_id, @amount, @options)
+      assert_equal expected, @client.create_or_update_refund(@options)
     end
   end
 end