refactor(ui): set @typescript-eslint/no-non-null-assertion to error

xiejay97 · xiejay97 · commit 237f5aa5d5c5 · 2023-03-16T10:09:38.000+08:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -81,6 +81,7 @@
             "ignoreProperties": true
           }
         ],
+        "@typescript-eslint/no-non-null-assertion": "error",
         "no-unused-vars": "off",
         "@typescript-eslint/no-unused-vars": [
           "error",
diff --git a/packages/platform/src/app/Routes.tsx b/packages/platform/src/app/Routes.tsx
@@ -238,11 +238,12 @@ export const AppRoutes = React.memo(() => {
 
   const title = (() => {
     if (matches) {
-      const match = nth(matches, -1)!;
-      const { title } = match.route.data ?? {};
-      return isFunction(title) ? title(match.params) : title;
+      const match = nth(matches, -1);
+      if (match) {
+        const { title } = match.route.data ?? {};
+        return isFunction(title) ? title(match.params) : title;
+      }
     }
-    return undefined;
   })();
   useEffect(() => {
     if (isUndefined(title)) {
diff --git a/packages/platform/src/app/components/map/MapMarkerCluster.tsx b/packages/platform/src/app/components/map/MapMarkerCluster.tsx
@@ -103,6 +103,7 @@ export function AppMapMarkerCluster<T extends MarkerClusterDataOption>(props: Ap
               if (!isUndefined(color)) {
                 content.style.color = color;
               }
+              // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
               content.firstElementChild!.innerHTML = String(context.count);
 
               context.marker.setOffset(new AMap.Pixel(-size / 2, -size / 2));
diff --git a/packages/platform/src/app/components/table/Table.tsx b/packages/platform/src/app/components/table/Table.tsx
@@ -174,6 +174,7 @@ export function AppTable<T = any>(props: AppTableProps<T>): JSX.Element | null {
                                     dPlacement="bottom-right"
                                     onItemClick={(id) => {
                                       if (actions[id].link) {
+                                        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                                         navigate(actions[id].link!);
                                       } else {
                                         return actions[id].onclick?.();
@@ -261,6 +262,7 @@ export function AppTable<T = any>(props: AppTableProps<T>): JSX.Element | null {
                                 dPlacement="bottom-right"
                                 onItemClick={(id) => {
                                   if (actions[id].link) {
+                                    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                                     navigate(actions[id].link!);
                                   } else {
                                     return actions[id].onclick?.();
@@ -313,6 +315,7 @@ export function AppTable<T = any>(props: AppTableProps<T>): JSX.Element | null {
                         <DCard.Action
                           title="edit"
                           onClick={() => {
+                            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                             navigate(action.link!);
                           }}
                         >
@@ -341,6 +344,7 @@ export function AppTable<T = any>(props: AppTableProps<T>): JSX.Element | null {
                                   dPlacement="bottom-right"
                                   onItemClick={(id) => {
                                     if (actions[id].link) {
+                                      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                                       navigate(actions[id].link!);
                                     } else {
                                       return actions[id].onclick?.();
diff --git a/packages/platform/src/app/core/http/mock.ts b/packages/platform/src/app/core/http/mock.ts
@@ -127,6 +127,7 @@ if (environment.http.mock) {
   mock.onGet(/\/api\/v1\/device\/[0-9]+/).reply((config) => {
     return new Promise((resolve) => {
       setTimeout(() => {
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         resolve([200, deviceList.find((device) => device.id === Number(config.url!.match(/[0-9]+$/)![0]))]);
       }, 500);
     });
diff --git a/packages/platform/src/app/core/http/useHttp.ts b/packages/platform/src/app/core/http/useHttp.ts
@@ -30,7 +30,7 @@ export function useHttp() {
 
   const http = useEventCallback(
     <T = any, D = any>(
-      config: AxiosRequestConfig<D>,
+      config: AxiosRequestConfig<D> & { url: string },
       options?: { unmount?: boolean; authorization?: boolean }
     ): Observable<T> & { abort: () => void } => {
       const { unmount = true, authorization = true } = options ?? {};
@@ -55,7 +55,7 @@ export function useHttp() {
       const req = of({
         ...config,
         baseURL: environment.http.baseURL,
-        url: environment.http.transformURL(config.url!),
+        url: environment.http.transformURL(config.url),
         headers,
         signal: controller.signal,
       }).pipe(
diff --git a/packages/platform/src/app/routes/list/standard-table/detail/Detail.tsx b/packages/platform/src/app/routes/list/standard-table/detail/Detail.tsx
@@ -22,6 +22,7 @@ export default AppRoute(() => {
   const deviceApi = useAPI(http, '/device');
 
   const { id: _id } = useParams();
+  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
   const id = Number(_id!);
 
   const [deviceLoading, setDeviceLoading] = useState(true);
diff --git a/packages/platform/src/app/routes/login/Login.tsx b/packages/platform/src/app/routes/login/Login.tsx
@@ -79,8 +79,8 @@ export default AppRoute(() => {
       error: (error) => {
         setLoginLoading(false);
         NotificationService.open({
-          dTitle: error.response!.status,
-          dDescription: error.response!.statusText,
+          dTitle: error.response.status,
+          dDescription: error.response.statusText,
           dType: 'error',
         });
       },
@@ -134,16 +134,16 @@ export default AppRoute(() => {
                       <DForm.Item
                         dFormControls={{
                           username: {
-                            required: t('routes.login.Please enter your name')!,
-                            checkValue: t('routes.login.Username')!,
+                            required: t('routes.login.Please enter your name'),
+                            checkValue: t('routes.login.Username'),
                           },
                         }}
                       >
                         {({ username }) => (
                           <DInput dFormControl={username} dPrefix={<UserOutlined />} dPlaceholder={t('routes.login.Username')} />
                         )}
                       </DForm.Item>
-                      <DForm.Item dFormControls={{ password: t('routes.login.Please enter your password')! }}>
+                      <DForm.Item dFormControls={{ password: t('routes.login.Please enter your password') }}>
                         {({ password }) => (
                           <DInput
                             dFormControl={password}
@@ -164,12 +164,12 @@ export default AppRoute(() => {
                 panel: (
                   <DForm onSubmit={handleSubmit} dUpdate={updatePhoneForm} dLabelWidth={0}>
                     <DForm.Group dFormGroup={phoneForm}>
-                      <DForm.Item dFormControls={{ phone: t('routes.login.Please enter your phone number')! }}>
+                      <DForm.Item dFormControls={{ phone: t('routes.login.Please enter your phone number') }}>
                         {({ phone }) => (
                           <DInput dFormControl={phone} dPrefix={<MobileOutlined />} dPlaceholder={t('routes.login.Phone number')} />
                         )}
                       </DForm.Item>
-                      <DForm.Item dFormControls={{ code: t('routes.login.Please enter verification code')! }} dSpan>
+                      <DForm.Item dFormControls={{ code: t('routes.login.Please enter verification code') }} dSpan>
                         {({ code }) => <DInput dFormControl={code} dPlaceholder={t('routes.login.Verification code')} />}
                       </DForm.Item>
                       <DForm.Item dLabelWidth={8} dSpan="auto">
diff --git a/packages/site/executors/build-base/build-base.impl.ts b/packages/site/executors/build-base/build-base.impl.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import type { ExecutorContext } from '@nrwl/devkit';
 import type { FSWatcher } from 'fs-extra';
 
diff --git a/packages/site/src/app/components/route/component/DemoBox.tsx b/packages/site/src/app/components/route/component/DemoBox.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { useRef, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useLocation } from 'react-router-dom';
diff --git a/packages/site/src/app/components/route/component/Icon.tsx b/packages/site/src/app/components/route/component/Icon.tsx
@@ -48,6 +48,7 @@ export function AppIcon() {
           dType="success"
           onClose={() => {
             setToasts((draft) => {
+              // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
               draft.find((n) => n.key === key)!.visible = false;
             });
           }}
diff --git a/packages/ui/src/components/_transition/CollapseTransition.tsx b/packages/ui/src/components/_transition/CollapseTransition.tsx
@@ -7,12 +7,12 @@ import { DTransition } from './Transition';
 
 export interface DCollapseTransitionProps extends Omit<DTransitionProps, 'children'> {
   children: (ref: React.RefObject<any>, style: React.CSSProperties, state: DTransitionState) => JSX.Element | null;
-  dOriginalSize?: {
+  dOriginalSize: {
     width?: string | number;
     height?: string | number;
     padding?: [string | number, string | number, string | number, string | number];
   };
-  dCollapsedStyle?: {
+  dCollapsedStyle: {
     width?: string | number;
     height?: string | number;
     padding?: [string | number, string | number, string | number, string | number];
@@ -26,13 +26,13 @@ export interface DCollapseTransitionProps extends Omit<DTransitionProps, 'childr
 export function DCollapseTransition(props: DCollapseTransitionProps): JSX.Element | null {
   const {
     children,
+    dOriginalSize,
+    dCollapsedStyle,
     dStyles,
 
     ...restProps
   } = props;
 
-  const [dOriginalSize, dCollapsedStyle] = [restProps.dOriginalSize!, restProps.dCollapsedStyle!];
-
   const ref = useRef<HTMLElement>(null);
 
   const dataRef = useRef<{
diff --git a/packages/ui/src/components/cascader/Cascader.tsx b/packages/ui/src/components/cascader/Cascader.tsx
@@ -312,7 +312,15 @@ function Cascader<V extends DId, T extends DCascaderItem<V>>(
     let suffixNode: React.ReactNode = null;
     let selectedLabel: string | undefined;
     if (dMultiple) {
-      const selectedNodes = (_select as V[]).map((v) => nodesMap.get(v) as MultipleTreeNode<V, T>);
+      const selectedNodes: MultipleTreeNode<V, T>[] = [];
+      for (const v of _select as V[]) {
+        const node = nodesMap.get(v);
+        if (node) {
+          selectedNodes.push(node as MultipleTreeNode<V, T>);
+        } else {
+          console.warn(`Can't find item that value field is ${v}!`);
+        }
+      }
 
       suffixNode = (
         <DDropdown
@@ -361,9 +369,13 @@ function Cascader<V extends DId, T extends DCascaderItem<V>>(
       ));
     } else {
       if (!isNull(select)) {
-        const node = nodesMap.get(select as V)!;
-        selectedLabel = getText(node);
-        selectedNode = dCustomSelected ? dCustomSelected(node.origin) : selectedLabel;
+        const node = nodesMap.get(select as V);
+        if (node) {
+          selectedLabel = getText(node);
+          selectedNode = dCustomSelected ? dCustomSelected(node.origin) : selectedLabel;
+        } else {
+          console.warn(`Can't find item that value field is ${select}!`);
+        }
       }
     }
     return [selectedNode, suffixNode, selectedLabel];
diff --git a/packages/ui/src/components/form/FormItem.tsx b/packages/ui/src/components/form/FormItem.tsx
@@ -63,6 +63,7 @@ export function DFormItem<T extends { [index: string]: DErrorInfo }>(props: DFor
   //#region Context
   const dPrefix = usePrefixConfig();
   const { gLabelWidth, gLabelColon, gRequiredType, gLayout, gInlineSpan, gFeedbackIcon } = useContextRequired(DFormContext);
+  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
   const formGroup = useContext(DFormGroupContext)!;
   //#endregion
 
diff --git a/packages/ui/src/components/image/ImagePreview.tsx b/packages/ui/src/components/image/ImagePreview.tsx
@@ -15,7 +15,7 @@ import { DInput } from '../input';
 import { useComponentConfig, usePrefixConfig } from '../root';
 
 export interface DImagePreviewProps extends React.HTMLAttributes<HTMLDivElement> {
-  dList: React.ImgHTMLAttributes<HTMLImageElement>[];
+  dList: (React.ImgHTMLAttributes<HTMLImageElement> & { src: string })[];
   dActive?: number;
   dVisible?: boolean;
   dZIndex?: number | string;
@@ -72,7 +72,7 @@ export function DImagePreview(props: DImagePreviewProps): JSX.Element | null {
   });
 
   const [activeIndex, changeActiveIndex] = useDValue<number>(0, dActive, onActiveChange);
-  const activeSrc = dList[activeIndex].src!;
+  const activeSrc = dList[activeIndex].src;
 
   const [offset, setOffset] = useState(3);
 
diff --git a/packages/ui/src/components/menu/Menu.tsx b/packages/ui/src/components/menu/Menu.tsx
@@ -380,6 +380,7 @@ function Menu<ID extends DId, T extends DMenuItem<ID>>(props: DMenuProps<ID, T>,
                 dStep={step}
                 dSpace={space}
                 dIcon={itemIcon}
+                // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                 dPosinset={posinset.get(itemId)!}
                 dMode={dMode}
                 dInNav={inNav}
@@ -418,6 +419,7 @@ function Menu<ID extends DId, T extends DMenuItem<ID>>(props: DMenuProps<ID, T>,
                 dList={children && getNodes(children as T[], dMode === 'vertical' ? level + 1 : 0, _subParents)}
                 dPopupState={popupState?.visible}
                 dTrigger={dExpandTrigger ?? (dMode === 'vertical' ? 'click' : 'hover')}
+                // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                 dPosinset={posinset.get(itemId)!}
                 dMode={dMode}
                 dInNav={inNav}
diff --git a/packages/ui/src/components/select/Select.tsx b/packages/ui/src/components/select/Select.tsx
@@ -338,7 +338,15 @@ function Select<V extends DId, T extends DSelectItem<V>>(
     let suffixNode: React.ReactNode = null;
     let selectedLabel: string | undefined;
     if (dMultiple) {
-      const selectedItems: T[] = (_select as V[]).map((v) => itemsMap.get(v)!);
+      const selectedItems: T[] = [];
+      for (const v of _select as V[]) {
+        const item = itemsMap.get(v);
+        if (item) {
+          selectedItems.push(item);
+        } else {
+          console.warn(`Can't find item that value field is ${v}!`);
+        }
+      }
 
       suffixNode = (
         <DDropdown
@@ -384,9 +392,13 @@ function Select<V extends DId, T extends DSelectItem<V>>(
       ));
     } else {
       if (!isNull(select)) {
-        const item = itemsMap.get(select as V)!;
-        selectedLabel = item.label;
-        selectedNode = dCustomSelected ? dCustomSelected(item) : selectedLabel;
+        const item = itemsMap.get(select as V);
+        if (item) {
+          selectedLabel = item.label;
+          selectedNode = dCustomSelected ? dCustomSelected(item) : selectedLabel;
+        } else {
+          console.warn(`Can't find item that value field is ${select}!`);
+        }
       }
     }
     return [selectedNode, suffixNode, selectedLabel];
diff --git a/packages/ui/src/components/slides/Slides.tsx b/packages/ui/src/components/slides/Slides.tsx
@@ -105,6 +105,7 @@ export function DSlides<ID extends DId, T extends DSlideItem<ID>>(props: DSlides
         if (index < activeIndex) {
           size += el[dVertical ? 'offsetHeight' : 'offsetWidth'];
         } else if (index === activeIndex) {
+          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
           slidesRef.current!.style.height = (el as HTMLDivElement).offsetHeight + 'px';
         }
       });
diff --git a/packages/ui/src/components/table/TableEmpty.tsx b/packages/ui/src/components/table/TableEmpty.tsx
@@ -39,6 +39,7 @@ export function DTableEmpty(props: DTableEmptyProps): JSX.Element | null {
         const cells = (tableEl as HTMLTableElement).rows.item(0)?.cells;
         if (cells) {
           for (let index = 0; index < cells.length; index++) {
+            // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             colSpan += cells.item(index)!.colSpan ?? 1;
           }
           tdRef.current.colSpan = colSpan;
diff --git a/packages/ui/src/components/transfer/Transfer.tsx b/packages/ui/src/components/transfer/Transfer.tsx
@@ -39,8 +39,8 @@ export interface DTransferProps<V extends DId, T extends DTransferItem<V>> exten
     filter?: (value: string, item: T) => boolean;
     sort?: (a: T, b: T) => number;
   };
-  onModelChange?: (value: T['value'][], item: T[]) => void;
-  onSelectedChange?: (value: T['value'][], item: T[]) => void;
+  onModelChange?: (value: T['value'][], item: (T | undefined)[]) => void;
+  onSelectedChange?: (value: T['value'][], item: (T | undefined)[]) => void;
   onSearchValueChange?: (value: [string, string]) => void;
   onScrollBottom?: (direction: 'left' | 'right') => void;
 }
@@ -84,7 +84,7 @@ export function DTransfer<V extends DId, T extends DTransferItem<V>>(props: DTra
       if (onModelChange) {
         onModelChange(
           value,
-          value.map((v) => itemsMap.get(v)!)
+          value.map((v) => itemsMap.get(v))
         );
       }
     },
@@ -97,7 +97,7 @@ export function DTransfer<V extends DId, T extends DTransferItem<V>>(props: DTra
     if (onSelectedChange) {
       onSelectedChange(
         value,
-        value.map((v) => itemsMap.get(v)!)
+        value.map((v) => itemsMap.get(v))
       );
     }
   });
diff --git a/packages/ui/src/components/tree-select/TreeSelect.tsx b/packages/ui/src/components/tree-select/TreeSelect.tsx
diff --git a/packages/ui/src/components/tree/Tree.tsx b/packages/ui/src/components/tree/Tree.tsx
diff --git a/packages/ui/src/components/upload/List.tsx b/packages/ui/src/components/upload/List.tsx
diff --git a/packages/ui/src/components/upload/PictureList.tsx b/packages/ui/src/components/upload/PictureList.tsx
diff --git a/packages/ui/src/components/upload/Upload.tsx b/packages/ui/src/components/upload/Upload.tsx
diff --git a/packages/ui/src/components/upload/UploadAction.tsx b/packages/ui/src/components/upload/UploadAction.tsx
diff --git a/packages/ui/src/components/virtual-scroll/VirtualScroll.tsx b/packages/ui/src/components/virtual-scroll/VirtualScroll.tsx

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@`
`81`	`81`	`"ignoreProperties": true`
`82`	`82`	`}`
`83`	`83`	`],`
	`84`	`+ "@typescript-eslint/no-non-null-assertion": "error",`
`84`	`85`	`"no-unused-vars": "off",`
`85`	`86`	`"@typescript-eslint/no-unused-vars": [`
`86`	`87`	`"error",`
Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,7 @@ export function AppMapMarkerCluster<T extends MarkerClusterDataOption>(props: Ap`
`103`	`103`	`if (!isUndefined(color)) {`
`104`	`104`	`content.style.color = color;`
`105`	`105`	`}`
	`106`	`+ // eslint-disable-next-line @typescript-eslint/no-non-null-assertion`
`106`	`107`	`content.firstElementChild!.innerHTML = String(context.count);`
`107`	`108`
`108`	`109`	`context.marker.setOffset(new AMap.Pixel(-size / 2, -size / 2));`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/* eslint-disable @typescript-eslint/no-non-null-assertion */`
`1`	`2`	`import type { ExecutorContext } from '@nrwl/devkit';`
`2`	`3`	`import type { FSWatcher } from 'fs-extra';`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/* eslint-disable @typescript-eslint/no-non-null-assertion */`
`1`	`2`	`import { useRef, useState } from 'react';`
`2`	`3`	`import { useTranslation } from 'react-i18next';`
`3`	`4`	`import { useLocation } from 'react-router-dom';`