chore: fix warnings

Author: mchav

app/Synthesis.hs

@@ -118,8 +118,8 @@ clean tdf =
 
 -- | Extract title (e.g. "Mr", "Mrs") from a full Titanic passenger name.
 extractTitle :: T.Text -> T.Text
-extractTitle name =
-    case filter (T.isSuffixOf ".") (T.words name) of
+extractTitle fullName =
+    case filter (T.isSuffixOf ".") (T.words fullName) of
         (w : _) -> T.dropEnd 1 w
         [] -> ""
 
@@ -133,10 +133,10 @@ computeAccuracy df =
                 DT.unsafeFreeze @RawPredSchema $
                     df |> D.select ["Survived", "prediction"]
         survived = DT.col @"Survived"
-        pred = DT.col @"prediction"
+        predCol = DT.col @"prediction"
         count expr = fromIntegral (DT.nRows (DT.filterWhere expr tdf))
-        tp = count ((survived DT..==. DT.lit 1) DT..&&. (pred DT..==. DT.lit 1))
-        tn = count ((survived DT..==. DT.lit 0) DT..&&. (pred DT..==. DT.lit 0))
-        fp = count ((survived DT..==. DT.lit 0) DT..&&. (pred DT..==. DT.lit 1))
-        fn = count ((survived DT..==. DT.lit 1) DT..&&. (pred DT..==. DT.lit 0))
+        tp = count ((survived DT..==. DT.lit 1) DT..&&. (predCol DT..==. DT.lit 1))
+        tn = count ((survived DT..==. DT.lit 0) DT..&&. (predCol DT..==. DT.lit 0))
+        fp = count ((survived DT..==. DT.lit 0) DT..&&. (predCol DT..==. DT.lit 1))
+        fn = count ((survived DT..==. DT.lit 1) DT..&&. (predCol DT..==. DT.lit 0))
      in (tp + tn) / (tp + tn + fp + fn)

dataframe.cabal

@@ -40,13 +40,8 @@ source-repository head
   location: https://github.com/mchav/dataframe
 
 common warnings
-    -- TODO add more warnings, eventually -Wall
     ghc-options:
-        -Wincomplete-patterns
-        -Wincomplete-uni-patterns
-        -Wunused-imports
-        -Wunused-packages
-        -Wunused-local-binds
+        -Wall
 
 library
     import: warnings

src/DataFrame/DecisionTree.hs

@@ -395,8 +395,8 @@ identifyCarePoints ::
 identifyCarePoints target df indices leftTree rightTree =
     case interpret @a df (Col target) of
         Left _ -> []
-        Right (TColumn col) ->
-            case toVector @a col of
+        Right (TColumn column) ->
+            case toVector @a column of
                 Left _ -> []
                 Right targetVals ->
                     V.toList $ V.mapMaybe (checkPoint targetVals) indices
@@ -424,12 +424,12 @@ predictWithTree ::
     Int -> -- Row index
     Tree a ->
     a
-predictWithTree target df idx (Leaf v) = v
+predictWithTree _target _df _idx (Leaf v) = v
 predictWithTree target df idx (Branch cond left right) =
     case interpret @Bool df cond of
         Left _ -> predictWithTree @a target df idx left -- Default to left on error
-        Right (TColumn col) ->
-            case toVector @Bool col of
+        Right (TColumn column) ->
+            case toVector @Bool column of
                 Left _ -> predictWithTree @a target df idx left
                 Right boolVals ->
                     if boolVals V.! idx
@@ -440,8 +440,8 @@ countCarePointErrors :: Expr Bool -> DataFrame -> [CarePoint] -> Int
 countCarePointErrors cond df carePoints =
     case interpret @Bool df cond of
         Left _ -> length carePoints
-        Right (TColumn col) ->
-            case toVector @Bool col of
+        Right (TColumn column) ->
+            case toVector @Bool column of
                 Left _ -> length carePoints
                 Right boolVals ->
                     length $ filter (isMisclassified boolVals) carePoints
@@ -457,8 +457,8 @@ partitionIndices ::
 partitionIndices cond df indices =
     case interpret @Bool df cond of
         Left _ -> (indices, V.empty)
-        Right (TColumn col) ->
-            case toVector @Bool col of
+        Right (TColumn column) ->
+            case toVector @Bool column of
                 Left _ -> (indices, V.empty)
                 Right boolVals ->
                     V.partition (boolVals V.!) indices
@@ -473,13 +473,13 @@ majorityValueFromIndices ::
 majorityValueFromIndices target df indices =
     case interpret @a df (Col target) of
         Left e -> throw e
-        Right (TColumn col) ->
-            case toVector @a col of
+        Right (TColumn column) ->
+            case toVector @a column of
                 Left e -> throw e
                 Right vals ->
                     let counts =
                             V.foldl'
-                                (\acc i -> M.insertWith (+) (vals V.! i) 1 acc)
+                                (\acc i -> M.insertWith (+) (vals V.! i) (1 :: Int) acc)
                                 M.empty
                                 indices
                      in if M.null counts
@@ -499,8 +499,8 @@ computeTreeLoss target df indices tree
     | otherwise =
         case interpret @a df (Col target) of
             Left _ -> 1.0
-            Right (TColumn col) ->
-                case toVector @a col of
+            Right (TColumn column) ->
+                case toVector @a column of
                     Left _ -> 1.0
                     Right targetVals ->
                         let
@@ -699,24 +699,26 @@ numericExprsWithTerms cfg df =
 numericCols :: DataFrame -> [NumExpr]
 numericCols df = concatMap extract (columnNames df)
   where
-    extract col = case unsafeGetColumn col df of
+    extract colName = case unsafeGetColumn colName df of
         UnboxedColumn Nothing (_ :: VU.Vector b) ->
             case testEquality (typeRep @b) (typeRep @Double) of
-                Just Refl -> [NDouble (Col col)]
+                Just Refl -> [NDouble (Col colName)]
                 Nothing -> case sIntegral @b of
-                    STrue -> [NDouble (F.toDouble (Col @b col))]
+                    STrue -> [NDouble (F.toDouble (Col @b colName))]
                     SFalse -> []
         BoxedColumn (Just _) (_ :: V.Vector b) ->
             case testEquality (typeRep @b) (typeRep @Double) of
-                Just Refl -> [NMaybeDouble (Col @(Maybe b) col)]
+                Just Refl -> [NMaybeDouble (Col @(Maybe b) colName)]
                 Nothing -> case sIntegral @b of
-                    STrue -> [NMaybeDouble (F.whenPresent (realToFrac @b @Double) (Col @(Maybe b) col))]
+                    STrue ->
+                        [NMaybeDouble (F.whenPresent (realToFrac @b @Double) (Col @(Maybe b) colName))]
                     SFalse -> []
         UnboxedColumn (Just _) (_ :: VU.Vector b) ->
             case testEquality (typeRep @b) (typeRep @Double) of
-                Just Refl -> [NMaybeDouble (Col @(Maybe b) col)]
+                Just Refl -> [NMaybeDouble (Col @(Maybe b) colName)]
                 Nothing -> case sIntegral @b of
-                    STrue -> [NMaybeDouble (F.whenPresent (realToFrac @b @Double) (Col @(Maybe b) col))]
+                    STrue ->
+                        [NMaybeDouble (F.whenPresent (realToFrac @b @Double) (Col @(Maybe b) colName))]
                     SFalse -> []
         _ -> []
 
@@ -766,16 +768,18 @@ generateConditionsOld cfg df =
         ords = columnOrdering cfg
         genConds :: T.Text -> [Expr Bool]
         genConds colName = case unsafeGetColumn colName df of
-            (BoxedColumn Nothing (col :: V.Vector a)) ->
-                case withOrdFrom @a ords (map (Lit . (`percentileOrd'` col)) [1, 25, 75, 99]) of
+            (BoxedColumn Nothing (column :: V.Vector a)) ->
+                case withOrdFrom @a ords (map (Lit . (`percentileOrd'` column)) [1, 25, 75, 99]) of
                     Just ps -> map (F.lift2 (==) (Col @a colName)) ps
                     Nothing -> []
-            (BoxedColumn (Just _) (col :: V.Vector a)) -> case sFloating @a of
+            (BoxedColumn (Just _) (column :: V.Vector a)) -> case sFloating @a of
                 STrue -> [] -- handled by numericCols / numericExprs
                 SFalse -> case sIntegral @a of
                     STrue -> [] -- handled by numericCols / numericExprs
                     SFalse ->
-                        case withOrdFrom @a ords (map (Lit . Just . (`percentileOrd'` col)) [1, 25, 75, 99]) of
+                        case withOrdFrom @a
+                            ords
+                            (map (Lit . Just . (`percentileOrd'` column)) [1, 25, 75, 99]) of
                             Just ps -> map (F.lift2 (==) (Col @(Maybe a) colName)) ps
                             Nothing -> []
             (UnboxedColumn _ (_ :: VU.Vector a)) -> []
@@ -794,7 +798,7 @@ generateConditionsOld cfg df =
                 ]
           where
             colConds (!l, !r) = case (unsafeGetColumn l df, unsafeGetColumn r df) of
-                ( BoxedColumn Nothing (col1 :: V.Vector a)
+                ( BoxedColumn Nothing (_col1 :: V.Vector a)
                     , BoxedColumn Nothing (_ :: V.Vector b)
                     ) ->
                         case testEquality (typeRep @a) (typeRep @b) of
@@ -826,7 +830,7 @@ calculateGini target df =
         counts = getCounts @a target df
         numClasses = fromIntegral $ M.size counts
         probs = map (\c -> (fromIntegral c + 1) / (n + numClasses)) (M.elems counts)
-     in if n == 0 then 0 else 1 - sum (map (^ 2) probs)
+     in if n == 0 then 0 else 1 - sum (map (^ (2 :: Int)) probs)
 
 majorityValue :: forall a. (Columnable a, Ord a) => T.Text -> DataFrame -> a
 majorityValue target df =
@@ -840,17 +844,17 @@ getCounts ::
 getCounts target df =
     case interpret @a df (Col target) of
         Left e -> throw e
-        Right (TColumn col) ->
-            case toVector @a col of
+        Right (TColumn column) ->
+            case toVector @a column of
                 Left e -> throw e
                 Right vals -> foldl' (\acc x -> M.insertWith (+) x 1 acc) M.empty (V.toList vals)
 
 percentile :: Int -> Expr Double -> DataFrame -> Double
 percentile p expr df =
     case interpret @Double df expr of
         Left _ -> 0
-        Right (TColumn col) ->
-            case toVector @Double col of
+        Right (TColumn column) ->
+            case toVector @Double column of
                 Left _ -> 0
                 Right vals ->
                     let sorted = V.fromList $ sort $ V.toList vals
@@ -898,13 +902,13 @@ probsFromIndices ::
 probsFromIndices target df indices =
     case interpret @a df (Col target) of
         Left _ -> M.empty
-        Right (TColumn col) ->
-            case toVector @a col of
+        Right (TColumn column) ->
+            case toVector @a column of
                 Left _ -> M.empty
                 Right vals ->
                     let counts =
                             V.foldl'
-                                (\acc i -> M.insertWith (+) (vals V.! i) 1 acc)
+                                (\acc i -> M.insertWith (+) (vals V.! i) (1 :: Int) acc)
                                 M.empty
                                 indices
                         total = fromIntegral (V.length indices) :: Double

src/DataFrame/Display/Terminal/Plot.hs

@@ -171,16 +171,16 @@ plotCorrelationMatrix df = do
                         numericCols
                 )
                 numericCols
-    print (zip [0 ..] numericCols)
+    print (zip [(0 :: Int) ..] numericCols)
     T.putStrLn $ heatmap correlations (defPlot{plotTitle = "Correlation Matrix"})
   where
     correlation xs ys =
         let n = fromIntegral $ length xs
             meanX = sum xs / n
             meanY = sum ys / n
             covXY = sum [(x - meanX) * (y - meanY) | (x, y) <- zip xs ys] / n
-            stdX = sqrt $ sum [(x - meanX) ^ 2 | x <- xs] / n
-            stdY = sqrt $ sum [(y - meanY) ^ 2 | y <- ys] / n
+            stdX = sqrt $ sum [(x - meanX) ^ (2 :: Int) | x <- xs] / n
+            stdY = sqrt $ sum [(y - meanY) ^ (2 :: Int) | y <- ys] / n
          in covXY / (stdX * stdY)
 
 plotBars :: (HasCallStack) => T.Text -> DataFrame -> IO ()
@@ -254,7 +254,7 @@ plotGroupedBarsWithN n groupCol valCol config df = do
                     M.toList $
                         M.fromListWith
                             (+)
-                            [(g <> " - " <> v, 1) | (g, v) <- pairs]
+                            [(g <> " - " <> v, 1 :: Int) | (g, v) <- pairs]
                 finalCounts = groupWithOther n [(k, fromIntegral v) | (k, v) <- counts]
             T.putStrLn $ bars finalCounts (plotSettings config)
 
@@ -388,7 +388,7 @@ getCategoricalCounts colName df =
     countByShow xs =
         map (Data.Bifunctor.bimap T.pack fromIntegral) $
             M.toList $
-                L.foldl' (\acc x -> M.insertWith (+) (show x) 1 acc) M.empty xs
+                L.foldl' (\acc x -> M.insertWith (+) (show x) (1 :: Int) acc) M.empty xs
 
 isNumericColumnCheck :: T.Text -> DataFrame -> Bool
 isNumericColumnCheck colName df = isNumericColumn df colName
@@ -579,7 +579,7 @@ plotPieGroupedWith groupCol valCol config df = do
             let groups = extractStringColumn groupCol df
                 vals = extractStringColumn valCol df
                 combined = zipWith (\g v -> g <> " - " <> v) groups vals
-                counts = M.toList $ M.fromListWith (+) [(c, 1) | c <- combined]
+                counts = M.toList $ M.fromListWith (+) [(c, 1 :: Int) | c <- combined]
                 finalCounts = groupWithOtherForPie 10 [(k, fromIntegral v) | (k, v) <- counts]
             T.putStrLn $ pie finalCounts (plotSettings config)
 

src/DataFrame/Display/Terminal/PrettyPrint.hs

@@ -62,7 +62,7 @@ showTable properMarkdown header types rows =
         separator = T.intercalate "-|-" [T.replicate width (T.singleton '-') | width <- widths]
         fillCols fill cols =
             T.intercalate " | " [fill c width col | (c, width, col) <- zip3 cs widths cols]
-        lines =
+        outputLines =
             if properMarkdown
                 then
                     T.concat ["| ", fillCols colTitleFill consolidatedHeader, " |"]
@@ -75,4 +75,4 @@ showTable properMarkdown header types rows =
                         : fillCols colTitleFill types
                         : separator
                         : map (fillCols colValueFill) rows
-     in T.unlines lines
+     in T.unlines outputLines

src/DataFrame/Display/Web/Plot.hs

@@ -447,7 +447,7 @@ plotSingleBars colName config df = do
             let values = extractNumericColumn colName df
                 labels' =
                     if length values > 20
-                        then take 20 ["Item " <> T.pack (show i) | i <- [1 ..]]
+                        then take 20 ["Item " <> T.pack (show i) | i <- [(1 :: Int) ..]]
                         else ["Item " <> T.pack (show i) | i <- [1 .. length values]]
                 vals = if length values > 20 then take 20 values else values
                 labels = T.intercalate "," ["\"" <> label <> "\"" | label <- labels']
@@ -794,7 +794,7 @@ plotGroupedBarsWithN n groupCol valCol config df = do
                     M.toList $
                         M.fromListWith
                             (+)
-                            [(g <> " - " <> v, 1) | (g, v) <- pairs]
+                            [(g <> " - " <> v, 1 :: Int) | (g, v) <- pairs]
                 finalCounts = groupWithOther n [(k, fromIntegral v) | (k, v) <- counts]
                 labels = T.intercalate "," ["\"" <> label <> "\"" | (label, _) <- finalCounts]
                 dataPoints = T.intercalate "," [T.pack (show val) | (_, val) <- finalCounts]
@@ -946,7 +946,7 @@ getCategoricalCounts colName df =
     countByShow xs =
         map (Data.Bifunctor.bimap T.pack fromIntegral) $
             M.toList $
-                L.foldl' (\acc x -> M.insertWith (+) (show x) 1 acc) M.empty xs
+                L.foldl' (\acc x -> M.insertWith (+) (show x) (1 :: Int) acc) M.empty xs
 
 groupWithOther :: Int -> [(T.Text, Double)] -> [(T.Text, Double)]
 groupWithOther n items =

src/DataFrame/Errors.hs

@@ -108,14 +108,14 @@ columnsNotFound missingColumns callPoint availableColumns =
             ++ "]"
 
 typeMismatchError :: String -> String -> String
-typeMismatchError givenType expectedType =
+typeMismatchError givenType expType =
     red $
         red "\n\n[Error]: Type Mismatch"
             ++ "\n\tWhile running your code I tried to "
             ++ "get a column of type: "
             ++ red (show givenType)
             ++ " but the column in the dataframe was actually of type: "
-            ++ green (show expectedType)
+            ++ green (show expType)
 
 emptyDataSetError :: T.Text -> String
 emptyDataSetError callPoint =