Commit 62bc671
committed
Two small TLS bug fixes
This commit from @jwwilcox fixes two TLS bugs.
The first is that in OpenSSL 1.1.0 and later, the client's certificate is
actually the first in the stack, not the last. (The corresponding function
for previous versions of OpenSSL remains unchanged.)
The second change fixes an off-by-one error in the loop searching for a
matching cert-to-name mapping. (The bug is evident when there is more than
one cert-to-name mapping present.)
These two fixes will allow the following three failing test cases in
[ADTRAN:netopeer2-integration-tests](https://github.com/ADTRAN/netopeer2-integration-tests/blob/master/tests/test_tls.py#L175)
to pass:
* `test_tls_only_client_leaf_trusted_and_fingerprint_of_client_CA()`
* `test_tls_only_client_leaf_trusted_and_fingerprint_of_client_leaf()`
* `test_tls_fingerprint_cascade()`
(The Travis CI results are available [here](https://travis-ci.org/ADTRAN/netopeer2-integration-tests/builds/421746115#L7435).)1 parent bd53d50 commit 62bc671
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
513 | 513 | | |
514 | 514 | | |
515 | 515 | | |
516 | | - | |
| 516 | + | |
517 | 517 | | |
518 | 518 | | |
519 | 519 | | |
| |||
1406 | 1406 | | |
1407 | 1407 | | |
1408 | 1408 | | |
1409 | | - | |
| 1409 | + | |
1410 | 1410 | | |
1411 | 1411 | | |
1412 | 1412 | | |
| |||
0 commit comments