client session BUGFIX double free

michalvasko · michalvasko · commit 3250b496c8c7 · 2019-08-15T13:59:49.000+02:00
Fixes CESNET/netopeer2#454
diff --git a/src/session_client_ssh.c b/src/session_client_ssh.c
@@ -1845,7 +1845,7 @@ nc_accept_callhome_ssh_sock(int sock, const char *host, uint16_t port, struct ly
 
     session = _nc_connect_libssh(sess, ctx, &ssh_ch_opts, timeout);
     if (!session) {
-        ssh_free(sess);
+        /* sess is freed */
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1845,7 +1845,7 @@ nc_accept_callhome_ssh_sock(int sock, const char *host, uint16_t port, struct ly`
`1845`	`1845`
`1846`	`1846`	`session = _nc_connect_libssh(sess, ctx, &ssh_ch_opts, timeout);`
`1847`	`1847`	`if (!session) {`
`1848`		`- ssh_free(sess);`
	`1848`	`+ /* sess is freed */`
`1849`	`1849`	`return NULL;`
`1850`	`1850`	`}`
`1851`	`1851`