++

Author: Zainullin Damir

include/ipfixprobe/outputPlugin/outputStorage/b2OutputStorage.hpp

@@ -129,7 +129,7 @@ class B2OutputStorage : public BOutputStorage<ElementType> {
 			__builtin_prefetch(
 				&this->m_buckets[readerData.readPosition + this->m_expectedReadersCount],
 				PrefetchMode::Write,
-				Locality::Medium);
+				Locality::High);
 			if (overflowed) {
 				if (!this->writersPresent()) {
 					readerData.generation.fetch_add(1, std::memory_order_release);
@@ -173,7 +173,8 @@ class B2OutputStorage : public BOutputStorage<ElementType> {
 			| std::views::transform(
 				  [](const CacheAlligned<typename BOutputStorage<ElementType>::ReaderData>&
 						 readerDataAlligned) {
-					  return readerDataAlligned->generation.load(std::memory_order_acquire);
+					  // TODO get back acquired
+					  return readerDataAlligned->generation.load(std::memory_order_relaxed);
 				  })
 			| std::ranges::to<boost::container::static_vector<
 				uint64_t,

include/ipfixprobe/outputPlugin/outputStorage/bOutputStorage.hpp

@@ -219,7 +219,8 @@ class BOutputStorage : public OutputStorage<ElementType> {
 			readerGenerations
 			= m_readersData
 			| std::views::transform([](const CacheAlligned<ReaderData>& readerDataAlligned) {
-				  return readerDataAlligned->generation.load(std::memory_order_acquire);
+				  // TODO changed to relaxed from acquire
+				  return readerDataAlligned->generation.load(std::memory_order_relaxed);
 			  })
 			| std::ranges::to<boost::container::static_vector<
 				uint64_t,
@@ -242,7 +243,7 @@ class BOutputStorage : public OutputStorage<ElementType> {
 		return *std::ranges::max_element(writerGenerations);
 	}
 
-	uint64_t getHighestReaderGeneration() const noexcept
+	/*uint64_t getHighestReaderGeneration() const noexcept
 	{
 		boost::container::static_vector<uint64_t, OutputStorage<ElementType>::MAX_READERS_COUNT>
 			readerGenerations
@@ -254,7 +255,8 @@ class BOutputStorage : public OutputStorage<ElementType> {
 				uint64_t,
 				OutputStorage<ElementType>::MAX_READERS_COUNT>>();
 		return *std::ranges::max_element(readerGenerations);
-	}
+	}*/
+
 	struct ReaderData {
 		BucketAllocation bucketAllocation {};
 		uint16_t readPosition;