Testing improvements

Author: GrahamCampbell

.gitattributes

@@ -4,7 +4,7 @@
 /.gitattributes export-ignore
 /.gitignore export-ignore
 /.travis.yml export-ignore
-/phpunit.xml export-ignore
+/phpunit.xml.dist export-ignore
 /CHANGELOG.md export-ignore
 /CONTRIBUTING.md export-ignore
 /README.md export-ignore

.gitignore

@@ -1,2 +1,4 @@
+/.idea
 /vendor
 composer.lock
+phpunit.xml

.travis.yml

@@ -8,11 +8,11 @@ php:
 
 before_script:
   - travis_retry composer self-update
-  - travis_retry composer install --no-interaction --prefer-source --dev
+  - travis_retry composer install --no-interaction --prefer-source
 
 script:
-  - bash -c 'if [ "$TRAVIS_PHP_VERSION" == "hhvm" ]; then vendor/bin/phpunit --verbose; fi;'
-  - bash -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then vendor/bin/phpunit --verbose --coverage-clover build/logs/clover.xml; fi;'
+  - bash -c 'if [ "$TRAVIS_PHP_VERSION" == "hhvm" ]; then vendor/bin/phpunit; fi;'
+  - bash -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then vendor/bin/phpunit --coverage-clover build/logs/clover.xml; fi;'
 
 after_success:
   - bash -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then wget https://scrutinizer-ci.com/ocular.phar; fi;'

phpunit.xml phpunit.xml.distphpunit.xml renamed to phpunit.xml.dist

@@ -7,23 +7,22 @@
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
          processIsolation="false"
+         stopOnError="false"
          stopOnFailure="false"
          syntaxCheck="true"
+         strict="true"
+         verbose="true">
 >
     <testsuites>
-        <testsuite name="Package Test Suite">
-            <directory suffix=".php">./tests</directory>
+        <testsuite name="Laravel Navigation Test Suite">
+            <directory suffix="Test.php">./tests</directory>
         </testsuite>
     </testsuites>
     <filter>
-        <whitelist addUncoveredFilesFromWhitelist="true">
+        <whitelist processUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">./src</directory>
             <exclude>
                 <directory>./src/config</directory>
-                <directory>./src/migrations</directory>
-                <directory>./src/views</directory>
-                <directory>./tests</directory>
-                <directory>./vendor</directory>
             </exclude>
         </whitelist>
     </filter>

tests/NavigationTest.php

@@ -56,7 +56,7 @@ public function testMainDefault()
             array('title' => 'Laravel', 'url' => 'http://laravel.com/url', 'active' => false)
         );
 
-        $this->assertEquals($expected, $return);
+        $this->assertSame($expected, $return);
     }
 
     public function testMainOther()
@@ -84,7 +84,7 @@ public function testMainOther()
             array('title' => 'Laravel', 'url' => 'http://laravel.com/url', 'active' => false)
         );
 
-        $this->assertEquals($expected, $return);
+        $this->assertSame($expected, $return);
     }
 
     public function testMainEmpty()
@@ -98,7 +98,7 @@ public function testMainEmpty()
 
         $expected = array();
 
-        $this->assertEquals($expected, $return);
+        $this->assertSame($expected, $return);
     }
 
     public function testBarDefault()
@@ -123,7 +123,7 @@ public function testBarDefault()
             array('title' => 'Laravel', 'url' => 'http://laravel.com/url')
         );
 
-        $this->assertEquals($expected, $return);
+        $this->assertSame($expected, $return);
     }
 
     public function testBarOther()
@@ -148,7 +148,7 @@ public function testBarOther()
             array('title' => 'Laravel', 'url' => 'http://laravel.com/url')
         );
 
-        $this->assertEquals($expected, $return);
+        $this->assertSame($expected, $return);
     }
 
     public function testBarEmpty()
@@ -162,7 +162,7 @@ public function testBarEmpty()
 
         $expected = array();
 
-        $this->assertEquals($expected, $return);
+        $this->assertSame($expected, $return);
     }
 
     public function testAddToMain()
@@ -171,7 +171,7 @@ public function testAddToMain()
 
         $return = $navigation->addToMain(array('title' => 'Test', 'slug' => 'test'));
 
-        $this->assertEquals($navigation, $return);
+        $this->assertSame($navigation, $return);
     }
 
     public function testAddToBar()
@@ -180,7 +180,7 @@ public function testAddToBar()
 
         $return = $navigation->addToBar(array('title' => 'Test', 'slug' => 'test'));
 
-        $this->assertEquals($navigation, $return);
+        $this->assertSame($navigation, $return);
     }
 
     public function testGetHTMLNoBar()
@@ -203,7 +203,7 @@ public function testGetHTMLNoBar()
 
         $return = $navigation->render('default', false);
 
-        $this->assertEquals($return, 'html goes here');
+        $this->assertSame('html goes here', $return);
     }
 
     public function testGetHTMLEmptyBar()
@@ -228,7 +228,7 @@ public function testGetHTMLEmptyBar()
 
         $return = $navigation->render('default', 'default');
 
-        $this->assertEquals($return, 'html goes here');
+        $this->assertSame('html goes here', $return);
     }
 
     public function testGetHTMLWithBar()
@@ -254,7 +254,7 @@ public function testGetHTMLWithBar()
 
         $return = $navigation->render('default', 'default');
 
-        $this->assertEquals($return, 'html goes here');
+        $this->assertSame('html goes here', $return);
     }
 
     public function testSetRequest()
@@ -267,7 +267,7 @@ public function testSetRequest()
 
         $return = $navigation->getRequest();
 
-        $this->assertEquals($request, $return);
+        $this->assertSame($request, $return);
     }
 
     protected function getNavigation()