hwmon: (ina3221) return prober error code

marcusfolkesson · groeck · commit c93f5e2ab532 · 2023-03-12T11:13:25.000-07:00
ret is set to 0 which do not indicate an error. Return -EINVAL instead. Fixes: a9e9dd9 ("hwmon: (ina3221) Read channel input source info from DT") Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> Link: https://lore.kernel.org/r/20230310075035.246083-1-marcus.folkesson@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
@@ -772,7 +772,7 @@ static int ina3221_probe_child_from_dt(struct device *dev,
 		return ret;
 	} else if (val > INA3221_CHANNEL3) {
 		dev_err(dev, "invalid reg %d of %pOFn\n", val, child);
-		return ret;
+		return -EINVAL;
 	}
 
 	input = &ina->inputs[val];

Original file line number	Diff line number	Diff line change
`@@ -772,7 +772,7 @@ static int ina3221_probe_child_from_dt(struct device *dev,`
`772`	`772`	`return ret;`
`773`	`773`	`} else if (val > INA3221_CHANNEL3) {`
`774`	`774`	`dev_err(dev, "invalid reg %d of %pOFn\n", val, child);`
`775`		`- return ret;`
	`775`	`+ return -EINVAL;`
`776`	`776`	`}`
`777`	`777`
`778`	`778`	`input = &ina->inputs[val];`