Skip to content

Commit 1367322

Browse files
manjunath3divakarchetan-rathore
authored andcommitted
fix: move S_L3_01 skip rule from scripts to acs_run_config.ini
- Removes UEFI hardcoded --skip to avoid overlapping - Update Linux and UEFI scripts to match the handling Signed-off-by: Manjunatha D <manjunatha.d@arm.com> Change-Id: Ib1bbe5c698fa00d4fbf9c3a9f4997f3e211a5b26
1 parent f39ea50 commit 1367322

3 files changed

Lines changed: 13 additions & 14 deletions

File tree

common/config/acs_run_config.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ sbsa_level = 4
3737
# Add selected rules to run here.
3838
sbsa_select_rules =
3939
# Add rules which you want to skip here.
40-
sbsa_skip_rules =
40+
sbsa_skip_rules = S_L3_01
4141
# valid values 1,2,3,4,5
4242
sbsa_verbose = 3
4343

common/linux_scripts/init.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,6 @@ if [ $ADDITIONAL_CMD_OPTION != "noacs" ]; then
246246
fi
247247
fi
248248

249-
250249
# Linux SBSA Execution
251250
echo "Running Linux SBSA tests"
252251
if [ "$automation_enabled" == "True" ]; then
@@ -257,8 +256,8 @@ if [ $ADDITIONAL_CMD_OPTION != "noacs" ]; then
257256
if [ -f /lib/modules/sbsa_acs.ko ]; then
258257
insmod /lib/modules/sbsa_acs.ko
259258
echo "${SR_VERSION}" > /mnt/acs_results/linux/SbsaResultsApp.log
260-
echo "Running command $sbsa_command --skip S_L3_01,PCI_MM_03 --skip-dp-nic-ms"
261-
$sbsa_command --skip S_L3_01,PCI_MM_03 --skip-dp-nic-ms >> /mnt/acs_results/linux/SbsaResultsApp.log
259+
echo "Running command $sbsa_command --skip PCI_MM_03 --skip-dp-nic-ms"
260+
$sbsa_command --skip PCI_MM_03 --skip-dp-nic-ms >> /mnt/acs_results/linux/SbsaResultsApp.log
262261
dmesg | sed -n 'H; /PE_INFO/h; ${g;p;}' > /mnt/acs_results/linux/SbsaResultsKernel.log
263262
sync /mnt
264263
sleep 5

common/uefi_scripts/sbsa.nsh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ for %i in 0 1 2 3 4 5 6 7 8 9 A B C D E F then
4646
if "%1" == "" then
4747
FS%i:
4848
acs_tests\parser\Parser.efi -sbsa
49-
echo "UEFI EE SBSA Command: %SbsaCommand% -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log"
50-
FS%i:\acs_tests\bsa\sbsa\%SbsaCommand% -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log
49+
echo "UEFI EE SBSA Command: %SbsaCommand% -skip-dp-nic-ms -f SbsaTempResults.log"
50+
FS%i:\acs_tests\bsa\sbsa\%SbsaCommand% -skip-dp-nic-ms -f SbsaTempResults.log
5151
goto SbsaEE
5252
endif
5353
if exist FS%i:\acs_tests\bsa\sbsa\Sbsa.efi then
@@ -70,8 +70,8 @@ for %i in 0 1 2 3 4 5 6 7 8 9 A B C D E F then
7070
goto SbsaNormalMode
7171
endif
7272
:SbsaVerboseRun
73-
echo "SBSA Command: Sbsa.efi -v 1 -skip S_L3_01 -skip-dp-nic-ms -f SbsaVerboseTempResults.log"
74-
FS%i:\acs_tests\bsa\sbsa\Sbsa.efi -v 1 -skip S_L3_01 -skip-dp-nic-ms -f SbsaVerboseTempResults.log
73+
echo "SBSA Command: Sbsa.efi -v 1 -skip-dp-nic-ms -f SbsaVerboseTempResults.log"
74+
FS%i:\acs_tests\bsa\sbsa\Sbsa.efi -v 1 -skip-dp-nic-ms -f SbsaVerboseTempResults.log
7575
stall 200000
7676
if exist FS%i:\acs_results\uefi\SbsaVerboseTempResults.log then
7777
cp SbsaVerboseTempResults.log SbsaVerboseResults.log
@@ -100,16 +100,16 @@ for %i in 0 1 2 3 4 5 6 7 8 9 A B C D E F then
100100
endif
101101
:SbsaNormalRun
102102
if "%1" == "false" then
103-
echo "SBSA Command: Sbsa.efi -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log"
104-
FS%i:\acs_tests\bsa\sbsa\Sbsa.efi -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log
103+
echo "SBSA Command: Sbsa.efi -skip-dp-nic-ms -f SbsaTempResults.log"
104+
FS%i:\acs_tests\bsa\sbsa\Sbsa.efi -skip-dp-nic-ms -f SbsaTempResults.log
105105
else
106106
if "%SbsaCommand%" == "" then
107107
echo "SbsaCommand variable does not exist, running default command Sbsa.efi"
108-
echo "SBSA Command: Sbsa.efi -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log"
109-
FS%i:\acs_tests\bsa\sbsa\Sbsa.efi -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log
108+
echo "SBSA Command: Sbsa.efi -skip-dp-nic-ms -f SbsaTempResults.log"
109+
FS%i:\acs_tests\bsa\sbsa\Sbsa.efi -skip-dp-nic-ms -f SbsaTempResults.log
110110
else
111-
echo "SBSA Command: %SbsaCommand% -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log"
112-
FS%i:\acs_tests\bsa\sbsa\%SbsaCommand% -skip S_L3_01 -skip-dp-nic-ms -f SbsaTempResults.log
111+
echo "SBSA Command: %SbsaCommand% -skip-dp-nic-ms -f SbsaTempResults.log"
112+
FS%i:\acs_tests\bsa\sbsa\%SbsaCommand% -skip-dp-nic-ms -f SbsaTempResults.log
113113
endif
114114
endif
115115
stall 200000

0 commit comments

Comments
 (0)