Skip to content

Commit 8f32edc

Browse files
authored
Minor documentation update (#32)
1 parent a0ede61 commit 8f32edc

1 file changed

Lines changed: 30 additions & 32 deletions

File tree

Source/DV_ETH.c

Lines changed: 30 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -287,10 +287,10 @@ void ETH_MAC_GetCapabilities (void) {
287287
\brief Function: ETH_MAC_Initialization
288288
\details
289289
The function \b ETH_MAC_Initialization verifies the Ethernet MAC functions in the following order:
290-
- \b Initialize without callback
291-
- \b Uninitialize
292-
- \b Initialize with callback if supported
293-
- \b Uninitialize
290+
- Initialize without callback
291+
- Uninitialize
292+
- Initialize with callback if supported
293+
- Uninitialize
294294
*/
295295
void ETH_MAC_Initialization (void) {
296296

@@ -312,12 +312,12 @@ void ETH_MAC_Initialization (void) {
312312
\brief Function: ETH_MAC_CheckInvalidInit
313313
\details
314314
The function \b ETH_MAC_CheckInvalidInit verifies the driver behavior when receiving an invalid initialization sequence:
315-
- \b Uninitialize
316-
- \b PowerControl with Power off
317-
- \b PowerControl with Power on
318-
- \b Control
319-
- \b PowerControl with Power off
320-
- \b Uninitialize
315+
- Uninitialize
316+
- PowerControl with Power off
317+
- PowerControl with Power on
318+
- Control
319+
- PowerControl with Power off
320+
- Uninitialize
321321
*/
322322
void ETH_MAC_CheckInvalidInit (void) {
323323

@@ -814,8 +814,8 @@ The function \b ETH_MAC_VLAN_Filter verifies the Ethernet MAC Virtual LAN filter
814814
- Buffer allocation
815815
- Initialize
816816
- Power on
817-
- Transfer VLAN packets
818-
- Receive VLAN packets
817+
- Transfer VLAN packets of varying lengths
818+
- Transfer non-tagged packet
819819
- Power off
820820
- Uninitialize
821821
@@ -869,6 +869,7 @@ void ETH_MAC_VLAN_Filter (void) {
869869
TEST_ASSERT(eth_mac->Control(ARM_ETH_MAC_CONFIGURE, ARM_ETH_MAC_SPEED_100M | ARM_ETH_MAC_DUPLEX_FULL |
870870
ARM_ETH_MAC_ADDRESS_MULTICAST | ARM_ETH_MAC_LOOPBACK) == ARM_DRIVER_OK);
871871

872+
/* Transfer tagged VLAN frame */
872873
for (i = 0; i < ARRAY_SIZE(vlan_id); i++) {
873874
TEST_ASSERT(eth_mac->Control (ARM_ETH_MAC_VLAN_FILTER,
874875
ARM_ETH_MAC_VLAN_FILTER_ID_ONLY | vlan_id[i]) == ARM_DRIVER_OK);
@@ -901,7 +902,7 @@ void ETH_MAC_VLAN_Filter (void) {
901902
TEST_ASSERT(eth_mac->Control (ARM_ETH_MAC_VLAN_FILTER,
902903
ARM_ETH_MAC_VLAN_FILTER_ID_ONLY | vlan_id[0]) == ARM_DRIVER_OK);
903904

904-
/* Test non-tagged frame */
905+
/* Transfer non-tagged frame */
905906
buffer_out[14] = 0xFF;
906907
buffer_out[15] = 0xFF;
907908
if (ETH_RunTransfer(buffer_out, buffer_in, 64, 0) == ARM_DRIVER_OK) {
@@ -1047,13 +1048,13 @@ void ETH_PHY_Initialization (void) {
10471048
\brief Function: ETH_PHY_CheckInvalidInit
10481049
\details
10491050
The function \b ETH_PHY_CheckInvalidInit verifies the driver behavior when receiving an invalid initialization sequence:
1050-
- \b Uninitialize
1051-
- \b PowerControl with Power off
1052-
- \b PowerControl with Power on
1053-
- \b SetInterface to configure the Ethernet PHY bus
1054-
- \b SetMode to configure the Ethernet PHY bus
1055-
- \b PowerControl with Power off
1056-
- \b Uninitialize
1051+
- Uninitialize
1052+
- PowerControl with Power off
1053+
- PowerControl with Power on
1054+
- SetInterface to configure the Ethernet PHY bus
1055+
- SetMode to configure the Ethernet PHY bus
1056+
- PowerControl with Power off
1057+
- Uninitialize
10571058
*/
10581059
void ETH_PHY_CheckInvalidInit (void) {
10591060

@@ -1093,8 +1094,8 @@ The function \b ETH_PHY_PowerControl verifies the Ethernet PHY \b PowerControl f
10931094
- Uninitialize
10941095
10951096
\note
1096-
When the Ethernet PHY is the 50 MHz clock source for the MAC in RMII mode, the MAC may lock up if the PHY power is off
1097-
and therefore not generating a reference clock.
1097+
When the Ethernet PHY provides the 50 MHz reference clock for the MAC in RMII mode, the MAC may lock up if the PHY
1098+
is powered down and no clock is generated.
10981099
*/
10991100
void ETH_PHY_PowerControl (void) {
11001101
int32_t retv;
@@ -1180,11 +1181,8 @@ The function \b ETH_Loopback_Transfer verifies data transfer via Ethernet with t
11801181
- Buffer allocation
11811182
- Initialize
11821183
- Power on
1183-
- Set output buffer pattern
1184-
- Transfer data chunks
1185-
- Set output buffer with random data
1186-
- Transfer data chunks
1187-
- Transfer data by sending in two fragments
1184+
- Transfer contiguous blocks of varying lengths
1185+
- Transfer fragmented blocks of varying lengths
11881186
- Power off
11891187
- Uninitialize
11901188
@@ -1291,9 +1289,9 @@ The function \b ETH_Loopback_External verifies data transfer via Ethernet with t
12911289
- Initialize
12921290
- Power on
12931291
- Set output buffer pattern
1294-
- Transfer data on PHY internal loopback
1295-
- Ethernet connection
1296-
- Transfer data on external cable loopback
1292+
- Transfer using the PHY internal loopback
1293+
- Check external cable loopback
1294+
- Transfer using the external cable loopback
12971295
- Power off
12981296
- Uninitialize
12991297
@@ -1341,7 +1339,7 @@ void ETH_Loopback_External (void) {
13411339
buffer_out[14+i] = (i ^ 0x20) & 0x7F;
13421340
}
13431341

1344-
/* Clear input buffer*/
1342+
/* Transfer using the PHY internal loopback */
13451343
memset(buffer_in, 0, 14+ETH_MTU);
13461344
if (ETH_RunTransfer(buffer_out, buffer_in, 14+ETH_MTU, 0) != ARM_DRIVER_OK) {
13471345
TEST_MESSAGE("[WARNING] PHY internal loopback is not active");
@@ -1367,7 +1365,7 @@ void ETH_Loopback_External (void) {
13671365
(uint32_t)info.duplex << ARM_ETH_MAC_DUPLEX_Pos |
13681366
ARM_ETH_MAC_ADDRESS_BROADCAST) == ARM_DRIVER_OK);
13691367

1370-
/* Clear input buffer */
1368+
/* Transfer using the external cable loopback */
13711369
memset(buffer_in, 0, 14+ETH_MTU);
13721370
if (ETH_RunTransfer(buffer_out, buffer_in, 14+ETH_MTU, 0) != ARM_DRIVER_OK) {
13731371
TEST_FAIL_MESSAGE("[FAILED] Transfer external cable loopback");

0 commit comments

Comments
 (0)